touchups and dynamic allocation.

This commit is contained in:
Dane Jensen
2026-09-05 12:15:02 -07:00
parent 54bd67d83f
commit 20fff55a08
3 changed files with 284 additions and 275 deletions

307
json.c
View File

@@ -40,9 +40,11 @@
* are not decoded, duplicate keys may go undetected.
*/
#define TOKENS_MAX 8192
#define ERROR_CTX_LEN 8
/* Input. */
static const char *g_input;
/* JSON Token types. */
enum json_token_type {
TOK_OPENOBJECT,
@@ -58,15 +60,16 @@ enum json_token_type {
/* JSON token. */
struct json_token {
enum json_token_type type;
const char *loc;
int len;
enum json_token_type type;
int offset;
int len;
};
/* JSON tokens. */
struct json_tokens {
struct json_token *toks;
int size;
int capacity;
struct json_token *toks;
};
/* JSON node type. */
@@ -87,11 +90,11 @@ TAILQ_HEAD(json_members, json_node);
/* JSON node. */
struct json_node {
enum json_node_type type;
const char *key;
char *key;
const char *loc;
struct json_node *parent;
union {
const char *str;
char *str;
int64_t num;
int boolean;
struct json_fields fields;
@@ -104,18 +107,17 @@ struct json_node {
static struct json_tokens *json_tokenize_input(const char *, char **);
static int json_tokenize_value(struct json_tokens *, const char *);
static struct json_tokens *json_create_tokens(void);
static void json_free_tokens(struct json_tokens *);
static int json_add_token(struct json_tokens *,
static void json_destroy_tokens(struct json_tokens *);
static void json_add_token(struct json_tokens *,
enum json_token_type, const char *, int);
static const struct json_token *json_tokens_tail(struct json_tokens *);
static void json_error(char **, const char *, const char *);
static void json_error(char **, const char *, int);
static struct json_node *json_create_node(struct json_node *,
enum json_node_type, const char *, const char *,
const void *);
static void json_assign_value(struct json_node *, const void *);
void *);
static void json_assign_value(struct json_node *, void *);
static struct json_node *json_parse_tokens(struct json_tokens **, char **);
static const char *json_parse_key(struct json_token **, char **);
static char *json_parse_key(struct json_token **, char **);
static struct json_node *json_parse_object(struct json_token **, const char *,
struct json_node *, char **);
static struct json_node *json_parse_array(struct json_token **, const char *,
@@ -142,6 +144,7 @@ json_parse(const char *input, char **cause)
{
struct json_tokens *tokens;
g_input = input;
if ((tokens = json_tokenize_input(input, cause)) == NULL)
return (NULL);
@@ -150,20 +153,20 @@ json_parse(const char *input, char **cause)
/* Returns a field node from an object node. */
struct json_node *
json_find(const struct json_node *jn, const char *key)
json_find(struct json_node *jn, const char *key)
{
struct json_node *node = (struct json_node *)jn, tmp = { 0 };
if (jn->type != NODE_OBJECT)
return (NULL);
tmp.key = key;
tmp.key = (char *)key;
return (RB_FIND(json_fields, &node->fields, &tmp));
}
/* Returns the first member of an array node. */
struct json_node *
json_array_first(const struct json_node *jn)
json_array_first(struct json_node *jn)
{
if (jn->type != NODE_ARRAY)
return (NULL);
@@ -173,7 +176,7 @@ json_array_first(const struct json_node *jn)
/* Returns the next member of an array's member node. */
struct json_node *
json_array_next(const struct json_node *member)
json_array_next(struct json_node *member)
{
if (member == NULL || member->parent->type != NODE_ARRAY)
return (NULL);
@@ -238,7 +241,7 @@ json_get_array(struct json_node *jn, struct json_node **a)
/* Returns the string value from a given key in an object node. */
int
json_find_string(const struct json_node *jn, const char *key, const char **out,
json_find_string(struct json_node *jn, const char *key, const char **out,
char **cause)
{
struct json_node *field;
@@ -261,7 +264,7 @@ json_find_string(const struct json_node *jn, const char *key, const char **out,
/* Returns the number value from a given key in an object node. */
int
json_find_number(const struct json_node *jn, const char *key, int64_t *out,
json_find_number(struct json_node *jn, const char *key, int64_t *out,
char **cause)
{
struct json_node *field;
@@ -284,7 +287,7 @@ json_find_number(const struct json_node *jn, const char *key, int64_t *out,
/* Returns the boolean value from a given key in an object node. */
int
json_find_boolean(const struct json_node *jn, const char *key, int *out,
json_find_boolean(struct json_node *jn, const char *key, int *out,
char **cause)
{
struct json_node *field;
@@ -307,8 +310,8 @@ json_find_boolean(const struct json_node *jn, const char *key, int *out,
/* Returns the object value from a given key in an object node. */
int
json_find_object(const struct json_node *jn, const char *key,
struct json_node **out, char **cause)
json_find_object(struct json_node *jn, const char *key, struct json_node **out,
char **cause)
{
struct json_node *field;
@@ -330,8 +333,8 @@ json_find_object(const struct json_node *jn, const char *key,
/* Returns the array value from a given key in an object node. */
int
json_find_array(const struct json_node *jn, const char *key,
struct json_node **out, char **cause)
json_find_array(struct json_node *jn, const char *key, struct json_node **out,
char **cause)
{
struct json_node *field;
@@ -353,39 +356,38 @@ json_find_array(const struct json_node *jn, const char *key,
/* Fill an error cause. */
static void
json_error(char **cause, const char *reason, const char *input)
json_error(char **cause, const char *reason, int offset)
{
const char *ellipsis = "...";
const char *loc = g_input + offset;
int i;
if (input == NULL || *input == '\0') {
if (offset == -1 || *loc == '\0') {
xasprintf(cause, "%s", reason);
return;
}
for (i = 0; i < ERROR_CTX_LEN + 1; i++) {
if (input[i] == '\0') {
if (loc[i] == '\0') {
ellipsis = "";
break;
}
}
xasprintf(cause, "%s: %.*s%s", reason, ERROR_CTX_LEN, input, ellipsis);
xasprintf(cause, "%s: %.*s%s", reason, ERROR_CTX_LEN, loc, ellipsis);
}
/* Tokenize the json string. */
static struct json_tokens *
json_tokenize_input(const char *input, char **cause)
{
struct json_tokens *tokens = json_create_tokens();
struct json_tokens *tokens;
enum json_token_type type;
const char *loc;
const char *loc, *start = input;
int scan;
tokens = json_create_tokens();
while (*input != '\0') {
if (tokens->size >= TOKENS_MAX)
goto fail;
loc = input;
scan = 1;
@@ -424,19 +426,17 @@ json_tokenize_input(const char *input, char **cause)
goto fail;
input += scan - 1;
}
if (json_add_token(tokens, type, loc, scan) != 0)
goto fail;
json_add_token(tokens, type, loc, scan);
input++;
}
if (json_add_token(tokens, TOK_EOF, NULL, 0) != 0)
goto fail;
json_add_token(tokens, TOK_EOF, loc, 0);
return (tokens);
fail:
json_error(cause, "tokenization error", input);
json_free_tokens(tokens);
json_error(cause, "tokenization error", loc - start);
json_destroy_tokens(tokens);
return (NULL);
}
@@ -447,11 +447,13 @@ fail:
static int
json_tokenize_value(struct json_tokens *tokens, const char *loc)
{
const struct json_token *prev = json_tokens_tail(tokens);
struct json_token *prev;
int scan = 0, escaping = 0;
if (prev == NULL)
if (tokens->size == 0)
return (-1);
prev = &tokens->toks[tokens->size - 1];
if (prev->type == TOK_QUOTE) {
do {
if (loc[scan] == '\0')
@@ -483,14 +485,15 @@ json_create_tokens(void)
tokens = xmalloc(sizeof *tokens);
tokens->size = 0;
tokens->toks = xmalloc(sizeof *tokens->toks * TOKENS_MAX);
tokens->capacity = 1024;
tokens->toks = xmalloc(tokens->capacity * sizeof *tokens->toks);
return (tokens);
}
/* Free a token container. */
static void
json_free_tokens(struct json_tokens *tokens)
json_destroy_tokens(struct json_tokens *tokens)
{
free(tokens->toks);
tokens->toks = NULL;
@@ -498,36 +501,28 @@ json_free_tokens(struct json_tokens *tokens)
}
/* Add a token to tokens. */
static int
static void
json_add_token(struct json_tokens *tokens, enum json_token_type type,
const char *loc, int len)
{
struct json_token *tok;
if (tokens->size >= TOKENS_MAX)
return (-1);
while (tokens->size >= tokens->capacity) {
tokens->capacity *= 2;
tokens->toks = xrealloc(tokens->toks,
sizeof *tokens->toks * tokens->capacity);
}
tok = &tokens->toks[tokens->size++];
tok->type = type;
tok->loc = loc;
tok->offset = loc - g_input;
tok->len = len;
return (0);
}
/* Returns a reference to the last token. */
static const struct json_token *
json_tokens_tail(struct json_tokens *tokens)
{
if (tokens->size == 0)
return (NULL);
return (&tokens->toks[tokens->size - 1]);
}
/* Create a node and assign given values. */
static struct json_node *
json_create_node(struct json_node *parent, enum json_node_type type,
const char *key, const char *loc, const void *val)
const char *key, const char *loc, void *val)
{
struct json_node *node;
@@ -558,7 +553,7 @@ json_destroy_node(struct json_node *node)
switch (node->type) {
case NODE_STRING:
free((char *)node->str);
free(node->str);
break;
case NODE_NUMBER:
case NODE_BOOLEAN:
@@ -579,19 +574,19 @@ json_destroy_node(struct json_node *node)
}
if (node->key != NULL)
free((char *)node->key);
free(node->key);
free(node);
}
/* Assign a value to a node. */
static void
json_assign_value(struct json_node *node, const void *val)
json_assign_value(struct json_node *node, void *val)
{
struct json_node *child = (struct json_node *)val;
struct json_node *child = val;
switch (node->type) {
case NODE_STRING:
node->str = (const char *)val;
node->str = val;
break;
case NODE_NUMBER:
node->num = *(int64_t *)val;
@@ -614,24 +609,24 @@ json_assign_value(struct json_node *node, const void *val)
static struct json_node *
json_parse_tokens(struct json_tokens **tokens, char **cause)
{
struct json_token *toks = (*tokens)->toks;
struct json_token *tok = (*tokens)->toks;
struct json_node *json = NULL;
if (toks->type == TOK_OPENOBJECT)
json = json_parse_object(&toks, NULL, NULL, cause);
if (tok->type == TOK_OPENOBJECT)
json = json_parse_object(&tok, NULL, NULL, cause);
else {
json_error(cause, "expected object", toks->loc);
json_error(cause, "expected object", tok->offset);
goto fail;
}
if (json == NULL)
goto fail;
if (toks->type != TOK_EOF) {
json_error(cause, "unexpected trailing data", toks->loc);
if (tok->type != TOK_EOF) {
json_error(cause, "unexpected trailing data", tok->offset);
goto fail;
}
json_free_tokens(*tokens);
json_destroy_tokens(*tokens);
*tokens = NULL;
return (json);
@@ -639,142 +634,146 @@ json_parse_tokens(struct json_tokens **tokens, char **cause)
fail:
if (json != NULL)
json_destroy_node(json);
json_free_tokens(*tokens);
json_destroy_tokens(*tokens);
*tokens = NULL;
return (NULL);
}
/* Parse and return a key string, and advance the token pointer. */
static const char *
json_parse_key(struct json_token **toks, char **cause)
static char *
json_parse_key(struct json_token **tok, char **cause)
{
const char *key, *loc = (*toks)->loc;
int len;
int len, offset = (*tok)->offset;
const char *loc;
char *key;
if ((*toks)->type != TOK_QUOTE)
if ((*tok)->type != TOK_QUOTE)
goto fail;
(*toks)++;
(*tok)++;
loc = (*toks)->loc;
len = (*toks)->len;
loc = g_input + (*tok)->offset;
len = (*tok)->len;
if ((*toks)->type != TOK_VALUE)
if ((*tok)->type != TOK_VALUE)
goto fail;
(*toks)++;
if ((*toks)->type != TOK_QUOTE)
(*tok)++;
if ((*tok)->type != TOK_QUOTE)
goto fail;
key = xstrndup(loc, len);
(*toks)++;
(*tok)++;
return (key);
fail:
json_error(cause, "invalid key", loc);
json_error(cause, "invalid key", offset);
return (NULL);
}
/* Parse an object value, return the node, and advance the token pointer. */
static struct json_node *
json_parse_object(struct json_token **toks, const char *key,
json_parse_object(struct json_token **tok, const char *key,
struct json_node *parent, char **cause)
{
struct json_node *object, *field;
const char *loc, *fkey = NULL;
const char *loc;
char *fkey = NULL;
u_char *valstr;
if ((*toks)->type != TOK_OPENOBJECT)
if ((*tok)->type != TOK_OPENOBJECT)
return (NULL);
loc = (*toks)->loc;
(*toks)++;
loc = g_input + (*tok)->offset;
(*tok)++;
object = json_create_node(parent, NODE_OBJECT, key, loc, NULL);
while ((*toks)->type != TOK_CLOSEOBJECT) {
if ((fkey = json_parse_key(toks, cause)) == NULL)
while ((*tok)->type != TOK_CLOSEOBJECT) {
if ((fkey = json_parse_key(tok, cause)) == NULL)
goto fail;
if (json_find(object, fkey) != NULL) {
json_error(cause, "duplicate key", (*toks)->loc);
json_error(cause, "duplicate key", (*tok)->offset);
goto fail;
}
if ((*toks)->type != TOK_COLON) {
json_error(cause, "missing colon", (*toks)->loc);
if ((*tok)->type != TOK_COLON) {
json_error(cause, "missing colon", (*tok)->offset);
goto fail;
}
(*toks)++;
(*tok)++;
switch ((*toks)->type) {
switch ((*tok)->type) {
case TOK_QUOTE:
field = json_parse_string(toks, fkey, object, cause);
field = json_parse_string(tok, fkey, object, cause);
break;
case TOK_VALUE:
valstr = (u_char *)(*toks)->loc;
valstr = (u_char *)(g_input + (*tok)->offset);
if ((*valstr == '-' && isdigit(valstr[1])) ||
isdigit(*valstr)) {
field = json_parse_number(toks, fkey, object,
field = json_parse_number(tok, fkey, object,
cause);
} else
field = json_parse_boolean(toks, fkey, object,
field = json_parse_boolean(tok, fkey, object,
cause);
break;
case TOK_OPENOBJECT:
field = json_parse_object(toks, fkey, object, cause);
field = json_parse_object(tok, fkey, object, cause);
break;
case TOK_OPENARRAY:
field = json_parse_array(toks, fkey, object, cause);
field = json_parse_array(tok, fkey, object, cause);
break;
default:
json_error(cause, "unsupported object token",
(*toks)->loc);
json_error(cause,
"unexpected value when parsing object",
(*tok)->offset);
goto fail;
}
if (field == NULL)
goto fail;
json_assign_value(object, field);
if ((*toks)->type == TOK_COMMA) {
if ((*toks)[1].type == TOK_CLOSEOBJECT) {
if ((*tok)->type == TOK_COMMA) {
if ((*tok)[1].type == TOK_CLOSEOBJECT) {
json_error(cause, "invalid object",
(*toks)->loc);
(*tok)->offset);
goto fail;
}
(*toks)++;
} else if ((*toks)->type != TOK_CLOSEOBJECT) {
json_error(cause, "invalid object", (*toks)->loc);
(*tok)++;
} else if ((*tok)->type != TOK_CLOSEOBJECT) {
json_error(cause, "invalid object", (*tok)->offset);
goto fail;
}
free((char *)fkey);
free(fkey);
}
(*toks)++;
(*tok)++;
return (object);
fail:
if (fkey != NULL)
free((char *)fkey);
free(fkey);
json_destroy_node(object);
return (NULL);
}
/* Parse an array value, return the node, and advance the token pointer. */
static struct json_node *
json_parse_array(struct json_token **toks, const char *key,
json_parse_array(struct json_token **tok, const char *key,
struct json_node *parent, char **cause)
{
struct json_node *array, *member;
const char *loc;
if ((*toks)->type != TOK_OPENARRAY)
if ((*tok)->type != TOK_OPENARRAY)
return (NULL);
loc = (*toks)->loc;
(*toks)++;
loc = g_input + (*tok)->offset;
(*tok)++;
array = json_create_node(parent, NODE_ARRAY, key, loc, NULL);
while ((*toks)->type != TOK_CLOSEARRAY) {
switch ((*toks)->type) {
while ((*tok)->type != TOK_CLOSEARRAY) {
switch ((*tok)->type) {
case TOK_OPENOBJECT:
member = json_parse_object(toks, NULL, array, cause);
member = json_parse_object(tok, NULL, array, cause);
break;
default:
json_error(cause, "invalid array member", (*toks)->loc);
json_error(cause, "invalid array member",
(*tok)->offset);
goto fail;
}
if (member == NULL)
@@ -782,18 +781,19 @@ json_parse_array(struct json_token **toks, const char *key,
json_assign_value(array, member);
if ((*toks)->type == TOK_COMMA) {
if ((*toks)[1].type == TOK_CLOSEARRAY) {
json_error(cause, "invalid array", (*toks)->loc);
if ((*tok)->type == TOK_COMMA) {
if ((*tok)[1].type == TOK_CLOSEARRAY) {
json_error(cause, "invalid array",
(*tok)->offset);
goto fail;
}
(*toks)++;
} else if ((*toks)->type != TOK_CLOSEARRAY) {
json_error(cause, "invalid array", (*toks)->loc);
(*tok)++;
} else if ((*tok)->type != TOK_CLOSEARRAY) {
json_error(cause, "invalid array", (*tok)->offset);
goto fail;
}
}
(*toks)++;
(*tok)++;
return (array);
fail:
@@ -803,63 +803,66 @@ fail:
/* Parse a string value, return the node, and advance the token pointer. */
static struct json_node *
json_parse_string(struct json_token **toks, const char *key,
json_parse_string(struct json_token **tok, const char *key,
struct json_node *parent, char **cause)
{
const char *str, *start = (*toks)->loc;
int offset = (*tok)->offset;
const char *loc, *start = g_input + offset;
char *str;
int len;
if ((*toks)->type != TOK_QUOTE)
if ((*tok)->type != TOK_QUOTE)
goto fail;
(*toks)++;
if ((*toks)->type != TOK_VALUE)
(*tok)++;
if ((*tok)->type != TOK_VALUE)
goto fail;
str = (*toks)->loc;
len = (*toks)->len;
(*toks)++;
loc = g_input + (*tok)->offset;
len = (*tok)->len;
(*tok)++;
if ((*toks)->type != TOK_QUOTE)
if ((*tok)->type != TOK_QUOTE)
goto fail;
(*toks)++;
(*tok)++;
str = xstrndup(str, len);
str = xstrndup(loc, len);
return (json_create_node(parent, NODE_STRING, key, start, str));
fail:
json_error(cause, "invalid string", start);
json_error(cause, "invalid string", offset);
return (NULL);
}
/* Parse a number value, return the node, and advance the token pointer. */
static struct json_node *
json_parse_number(struct json_token **toks, const char *key,
json_parse_number(struct json_token **tok, const char *key,
struct json_node *parent, char **cause)
{
const char *start = (*toks)->loc;
int offset = (*tok)->offset;
const char *start = g_input + offset;
char *endptr;
int64_t num;
errno = 0;
num = strtoll(start, &endptr, 10);
if (errno != 0 || endptr != start + (*toks)->len)
if (errno != 0 || endptr != start + (*tok)->len)
goto fail;
(*toks)++;
(*tok)++;
return (json_create_node(parent, NODE_NUMBER, key, start, &num));
fail:
json_error(cause, "invalid number", start);
json_error(cause, "invalid number", offset);
return (NULL);
}
/* Parse a boolean value, return the node, and advance the token pointer. */
static struct json_node *
json_parse_boolean(struct json_token **toks, const char *key,
json_parse_boolean(struct json_token **tok, const char *key,
struct json_node *parent, char **cause)
{
const char *start = (*toks)->loc;
int len = (*toks)->len, boolean;
int offset = (*tok)->offset, len = (*tok)->len, boolean;
const char *start = g_input + offset;
if (strncmp(start, "true", len) == 0 && len == 4)
boolean = 1;
@@ -868,11 +871,11 @@ json_parse_boolean(struct json_token **toks, const char *key,
else
goto fail;
(*toks)++;
(*tok)++;
return (json_create_node(parent, NODE_BOOLEAN, key, start, &boolean));
fail:
json_error(cause, "invalid boolean", start);
json_error(cause, "invalid boolean", offset);
return (NULL);
}

View File

@@ -54,12 +54,11 @@
* "z": z-index, if a floating pane
*/
#define LAYOUT_STRING_MAX (1 << 14)
/* Layout string. */
struct layout_string {
char *write;
char dat[LAYOUT_STRING_MAX];
char *dat;
size_t size; /* length written, not including terminator */
size_t capacity; /* bytes allocated */
};
struct layout_parse_cell_ctx {
@@ -76,9 +75,9 @@ struct layout_parse_ctx {
struct layout_cell *root;
char **cause;
#define CCTX_MAX (LAYOUT_STRING_MAX >> 5) /* min 32 bytes per pane */
int clen;
struct layout_parse_cell_ctx cctxs[CCTX_MAX];
int size; /* number used */
int capacity; /* number allocated */
struct layout_parse_cell_ctx *cctxs;
};
static struct layout_cell *layout_find_bottomright(struct layout_cell *);
@@ -91,8 +90,7 @@ static void layout_assign(struct window *,
struct layout_parse_ctx *);
static void layout_parse_apply_ctx(struct window *,
struct layout_parse_ctx *);
static struct layout_cell *layout_parse_json_layout(
const struct json_node *,
static struct layout_cell *layout_parse_json_layout( struct json_node *,
struct layout_cell *,
struct layout_parse_ctx *);
static int layout_parse_ctx_check_indexes(
@@ -147,27 +145,43 @@ layout_parse_last_cmp(const void *a, const void *b)
static void
layout_string_init(struct layout_string *ls)
{
ls->capacity = 1024;
ls->dat = xmalloc(ls->capacity);
ls->dat[0] = '\0';
ls->write = ls->dat;
ls->size = 0;
}
/* Free a layout string. */
static void
layout_string_free(struct layout_string *ls)
{
free(ls->dat);
ls->dat = NULL;
ls->size = 0;
ls->capacity = 0;
}
/* Write an optionally formatted string to the end of the layout string. */
static int
static void printflike(2, 3)
layout_string_write(struct layout_string *ls, const char *fmt, ...)
{
int len, remaining = sizeof ls->dat - (ls->write - ls->dat);
va_list ap;
va_list ap;
char *s;
size_t slen;
va_start(ap, fmt);
len = vsnprintf(ls->write, remaining, fmt, ap);
slen = xvasprintf(&s, fmt, ap);
va_end(ap);
if (len < 0 || len >= remaining)
return (-1);
ls->write += len;
while (ls->size + slen + 1 > ls->capacity) {
ls->dat = xreallocarray(ls->dat, 2, ls->capacity);
ls->capacity *= 2;
}
memcpy(ls->dat + ls->size, s, slen);
ls->size += slen;
ls->dat[ls->size] = '\0';
return (0);
free(s);
}
static void
@@ -177,27 +191,42 @@ layout_parse_init_ctx(struct layout_parse_ctx *pctx, char **cause)
pctx->num_active = 0;
pctx->root = NULL;
pctx->cause = cause;
pctx->clen = 0;
pctx->size = 0;
pctx->capacity = 64;
pctx->cctxs = xcalloc(pctx->capacity, sizeof *pctx->cctxs);
}
/* Free a parse context. */
static void
layout_parse_free_ctx(struct layout_parse_ctx *pctx)
{
layout_free_cell(pctx->root, 0);
pctx->root = NULL;
free(pctx->cctxs);
pctx->cctxs = NULL;
pctx->size = 0;
pctx->capacity = 0;
}
/* Add a cell context to the parse context. */
static int
static void
layout_parse_add_cctx(struct layout_parse_ctx *pctx, struct layout_cell *lc,
int active, int last, int index, int zindex)
{
struct layout_parse_cell_ctx *cctx;
if (pctx->clen == CCTX_MAX)
return (-1);
cctx = &pctx->cctxs[pctx->clen++];
if (pctx->size >= pctx->capacity) {
pctx->capacity *= 2;
pctx->cctxs = xreallocarray(pctx->cctxs, pctx->capacity,
sizeof *pctx->cctxs);
}
cctx = &pctx->cctxs[pctx->size++];
cctx->lc = lc;
cctx->active = active;
cctx->last = last;
cctx->index = index;
cctx->zindex = zindex;
return (0);
}
/* Remove a cell context from the parse context. Does not preserve ordering. */
@@ -207,9 +236,9 @@ layout_parse_remove_cctx(struct layout_parse_ctx *pctx, struct layout_cell *lc)
struct layout_parse_cell_ctx *cctx;
int i;
for (i = 0; i < pctx->clen; i++) {
for (i = 0; i < pctx->size; i++) {
if (lc == pctx->cctxs[i].lc) {
cctx = &pctx->cctxs[--pctx->clen];
cctx = &pctx->cctxs[--pctx->size];
memmove(&pctx->cctxs[i], cctx, sizeof *cctx);
return (0);
}
@@ -246,18 +275,19 @@ char *
layout_dump(__unused struct window *w, struct layout_cell *root, int flags)
{
struct layout_string layout;
char *out;
char *out = NULL;
layout_string_init(&layout);
if (layout_append(root, &layout, flags) != 0)
return (NULL);
if (layout_append(root, &layout, flags) == 0) {
if (flags & LAYOUT_CUSTOM_OLD_FORMAT)
xasprintf(&out, "%04hx,%s", layout_checksum(layout.dat),
layout.dat);
else
xasprintf(&out, "{\"V\":2,\"L\":%s}", layout.dat);
}
layout_string_free(&layout);
if (flags & LAYOUT_CUSTOM_OLD_FORMAT)
xasprintf(&out, "%04hx,%s", layout_checksum(layout.dat),
layout.dat);
else
xasprintf(&out, "{\"V\":2,\"L\":%s}", layout.dat);
return (out);
}
@@ -284,56 +314,38 @@ layout_append_v2(struct layout_cell *lc, struct layout_string *ls)
else
return (-1);
if (layout_string_write(ls, "{\"t\":\"%c\",\"w\":%u,\"h\":%u,\"x\":%d"
",\"y\":%d", c, lc->g.sx, lc->g.sy, lc->g.xoff, lc->g.yoff) != 0)
return (-1);
layout_string_write(ls, "{\"t\":\"%c\",\"w\":%u,\"h\":%u,\"x\":%d"
",\"y\":%d", c, lc->g.sx, lc->g.sy, lc->g.xoff, lc->g.yoff);
if (type != LAYOUT_WINDOWPANE) {
if (layout_string_write(ls, ",\"c\":[") != 0)
return (-1);
layout_string_write(ls, ",\"c\":[");
n = 0;
TAILQ_FOREACH(lcchild, &lc->cells, entry) {
if (layout_append_v2(lcchild, ls) != 0)
return (-1);
if (layout_string_write(ls, ",") != 0)
return (-1);
layout_string_write(ls, ",");
n++;
}
if (n == 0)
return (-1);
*(--ls->write) = '\0'; /* removing trailing comma */
if (layout_string_write(ls, "]") != 0)
return (-1);
ls->dat[--ls->size] = '\0'; /* removing trailing comma */
layout_string_write(ls, "]");
} else {
wp = lc->wp;
if (wp == NULL)
return (-1);
if (wp == wp->window->active) {
if (layout_string_write(ls, ",\"a\":true") != 0)
return (-1);
} else {
if (window_pane_last_index(wp, &i) == 0) {
if (layout_string_write(ls, ",\"l\":%u", i)
!= 0)
return (-1);
}
}
if (window_pane_index(wp, &i) == 0) {
if (layout_string_write(ls, ",\"i\":%u", i) != 0)
return (-1);
}
if (lc->flags & LAYOUT_CELL_FLOATING) {
if (window_pane_zindex(wp, &i) == 0) {
if (layout_string_write(ls, ",\"z\":%u", i)
!= 0)
return (-1);
}
}
if (layout_string_write(ls, ",\"I\":\"%%%u\"", wp->id) != 0)
return (-1);
if (wp == wp->window->active)
layout_string_write(ls, ",\"a\":true");
else if (window_pane_last_index(wp, &i) == 0)
layout_string_write(ls, ",\"l\":%u", i);
if (window_pane_index(wp, &i) == 0)
layout_string_write(ls, ",\"i\":%u", i);
if ((lc->flags & LAYOUT_CELL_FLOATING) &&
window_pane_zindex(wp, &i) == 0)
layout_string_write(ls, ",\"z\":%u", i);
layout_string_write(ls, ",\"I\":\"%%%u\"", wp->id);
}
if (layout_string_write(ls, "}") != 0)
return (-1);
layout_string_write(ls, "}");
return (0);
}
@@ -350,21 +362,18 @@ layout_append_v1(struct layout_cell *lc, struct layout_string *ls)
return (0);
if (lc->wp != NULL) {
if (layout_string_write(ls, "%ux%u,%d,%d,%u", lc->g.sx,
lc->g.sy, lc->g.xoff, lc->g.yoff, lc->wp->id) != 0)
return (-1);
layout_string_write(ls, "%ux%u,%d,%d,%u", lc->g.sx, lc->g.sy,
lc->g.xoff, lc->g.yoff, lc->wp->id);
} else {
if (layout_string_write(ls, "%ux%u,%d,%d", lc->g.sx,
lc->g.sy, lc->g.xoff, lc->g.yoff) != 0)
return (-1);
layout_string_write(ls, "%ux%u,%d,%d", lc->g.sx, lc->g.sy,
lc->g.xoff, lc->g.yoff);
}
switch (lc->type) {
case LAYOUT_LEFTRIGHT:
brackets = "{}";
/* FALLTHROUGH */
case LAYOUT_TOPBOTTOM:
if (layout_string_write(ls, "%c", brackets[0]) != 0)
return (-1);
layout_string_write(ls, "%c", brackets[0]);
n = 0;
TAILQ_FOREACH(lcchild, &lc->cells, entry) {
if (!layout_cell_is_tiled(lcchild) &&
@@ -372,16 +381,14 @@ layout_append_v1(struct layout_cell *lc, struct layout_string *ls)
continue;
if (layout_append_v1(lcchild, ls) != 0)
return (-1);
if (layout_string_write(ls, ",") != 0)
return (-1);
layout_string_write(ls, ",");
n++;
}
if (n == 0)
return (-1);
*(--ls->write) = '\0'; /* removing trailing comma */
if (layout_string_write(ls, "%c", brackets[1]) != 0)
return (-1);
ls->dat[--ls->size] = '\0'; /* removing trailing comma */
layout_string_write(ls, "%c", brackets[1]);
break;
case LAYOUT_WINDOWPANE:
break;
@@ -454,8 +461,7 @@ layout_parse(struct window *w, const char *layout, char **cause)
/* Build the layout. */
layout_parse_init_ctx(&pctx, cause);
if (layout_construct(layout, &pctx) != 0) {
if (pctx.root != NULL)
layout_free_cell(pctx.root, 0);
layout_parse_free_ctx(&pctx);
return (-1);
}
with_floating = pctx.version >= 2;
@@ -497,7 +503,9 @@ layout_parse(struct window *w, const char *layout, char **cause)
lc->parent = pctx.root;
}
}
/* The root is now owned by lc. */
lc = pctx.root;
pctx.root = NULL;
/*
* It appears older versions of tmux were able to generate layouts with
@@ -562,10 +570,12 @@ layout_parse(struct window *w, const char *layout, char **cause)
if (pctx.version == 1)
events_fire_window("window-layout-changed", w);
layout_parse_free_ctx(&pctx);
return (0);
fail:
layout_free_cell(lc, 0);
layout_parse_free_ctx(&pctx);
return (-1);
}
@@ -577,11 +587,11 @@ layout_assign_from_ctx(struct window *w, struct layout_parse_ctx *pctx)
struct window_pane *wp;
int i;
qsort(pctx->cctxs, pctx->clen, sizeof pctx->cctxs[0],
qsort(pctx->cctxs, pctx->size, sizeof pctx->cctxs[0],
layout_parse_index_cmp);
wp = TAILQ_FIRST(&w->panes);
for (i = 0; i < pctx->clen; i++) {
for (i = 0; i < pctx->size; i++) {
lc = pctx->cctxs[i].lc;
layout_make_leaf(lc, wp);
wp = TAILQ_NEXT(wp, entry);
@@ -624,10 +634,10 @@ layout_assign(struct window *w, struct layout_parse_ctx *pctx)
{
struct window_pane *wp = TAILQ_FIRST(&w->panes);
if (pctx->clen > 0)
if (pctx->size > 0)
layout_assign_from_ctx(w, pctx);
else
layout_assign_fallback(&wp, pctx->root);
layout_assign_fallback(&wp, w->layout_root);
}
/* Construct a cell from the legacy (v1) format. */
@@ -774,8 +784,8 @@ fail:
/* Parse nodes into layout cells. */
static struct layout_cell *
layout_parse_json_layout(const struct json_node *node,
struct layout_cell *lcparent, struct layout_parse_ctx *pctx)
layout_parse_json_layout(struct json_node *node, struct layout_cell *lcparent,
struct layout_parse_ctx *pctx)
{
struct json_node *member, *array;
struct layout_cell *lc = layout_create_cell(lcparent), *lcchild;
@@ -873,11 +883,7 @@ layout_parse_json_layout(const struct json_node *node,
} else
zindex = INT_MAX;
if (layout_parse_add_cctx(pctx, lc, active, last, index,
zindex) != 0) {
*cause = xstrdup("too many panes");
goto fail;
}
layout_parse_add_cctx(pctx, lc, active, last, index, zindex);
} else {
if (json_find_array(node, "c", &array, cause) != 0)
goto fail;
@@ -943,7 +949,7 @@ layout_construct(const char *layout, struct layout_parse_ctx *pctx)
*pctx->cause = xstrdup("more than one active pane");
return (-1);
}
if (pctx->clen == 0) {
if (pctx->size == 0) {
*pctx->cause = xstrdup("no panes");
return (-1);
}
@@ -971,10 +977,10 @@ layout_parse_apply_ctx(struct window *w, struct layout_parse_ctx *pctx)
wp = wpnext;
}
qsort(pctx->cctxs, pctx->clen, sizeof pctx->cctxs[0],
qsort(pctx->cctxs, pctx->size, sizeof pctx->cctxs[0],
layout_parse_zindex_cmp);
for (i = 0; i < pctx->clen; i++) {
for (i = 0; i < pctx->size; i++) {
cctx = &pctx->cctxs[i];
wp = cctx->lc->wp;
if (window_pane_is_floating(wp))
@@ -982,7 +988,7 @@ layout_parse_apply_ctx(struct window *w, struct layout_parse_ctx *pctx)
}
/* Set the active pane. */
for (i = 0; i < pctx->clen; i++) {
for (i = 0; i < pctx->size; i++) {
cctx = &pctx->cctxs[i];
if (cctx->active == 1) {
window_set_active_pane(w, cctx->lc->wp, 1);
@@ -996,10 +1002,10 @@ layout_parse_apply_ctx(struct window *w, struct layout_parse_ctx *pctx)
window_pane_stack_remove(&w->last_panes, wp);
}
qsort(pctx->cctxs, pctx->clen, sizeof pctx->cctxs[0],
qsort(pctx->cctxs, pctx->size, sizeof pctx->cctxs[0],
layout_parse_last_cmp);
for (i = 0; i < pctx->clen; i++) {
for (i = 0; i < pctx->size; i++) {
cctx = &pctx->cctxs[i];
wp = cctx->lc->wp;
if (cctx->last < 0 || cctx->active == 1)
@@ -1014,17 +1020,17 @@ layout_parse_ctx_check_indexes(struct layout_parse_ctx *pctx)
{
int i, n;
qsort(pctx->cctxs, pctx->clen, sizeof pctx->cctxs[0],
qsort(pctx->cctxs, pctx->size, sizeof pctx->cctxs[0],
layout_parse_index_cmp);
for (i = 1; i < pctx->clen; i++) {
for (i = 1; i < pctx->size; i++) {
if (pctx->cctxs[i].index == pctx->cctxs[i - 1].index) {
*pctx->cause = xstrdup("duplicate pane index");
return (0);
}
}
qsort(pctx->cctxs, pctx->clen, sizeof pctx->cctxs[0],
qsort(pctx->cctxs, pctx->size, sizeof pctx->cctxs[0],
layout_parse_zindex_cmp);
/*
@@ -1032,16 +1038,16 @@ layout_parse_ctx_check_indexes(struct layout_parse_ctx *pctx)
* and the floating panes run to the end.
*/
n = 0;
while (n < pctx->clen && pctx->cctxs[n].zindex == INT_MAX)
while (n < pctx->size && pctx->cctxs[n].zindex == INT_MAX)
n++;
for (i = n + 1; i < pctx->clen; i++) {
for (i = n + 1; i < pctx->size; i++) {
if (pctx->cctxs[i].zindex == pctx->cctxs[i - 1].zindex) {
*pctx->cause = xstrdup("duplicate pane z-index");
return (0);
}
}
qsort(pctx->cctxs, pctx->clen, sizeof pctx->cctxs[0],
qsort(pctx->cctxs, pctx->size, sizeof pctx->cctxs[0],
layout_parse_last_cmp);
/*
@@ -1049,7 +1055,7 @@ layout_parse_ctx_check_indexes(struct layout_parse_ctx *pctx)
* last.
*/
n = 0;
while (n < pctx->clen && pctx->cctxs[n].last >= 0)
while (n < pctx->size && pctx->cctxs[n].last >= 0)
n++;
for (i = 1; i < n; i++) {
if (pctx->cctxs[i].last == pctx->cctxs[i - 1].last) {

26
tmux.h
View File

@@ -4277,9 +4277,9 @@ void hyperlinks_free(struct hyperlinks *);
/* json.c */
struct json_node *json_parse(const char *, char **);
void json_destroy_node(struct json_node *);
struct json_node *json_find(const struct json_node *, const char *);
struct json_node *json_array_first(const struct json_node *);
struct json_node *json_array_next(const struct json_node *);
struct json_node *json_find(struct json_node *, const char *);
struct json_node *json_array_first(struct json_node *);
struct json_node *json_array_next(struct json_node *);
int json_get_string(struct json_node *, const char **);
int json_get_number(struct json_node *, int64_t *);
int json_get_boolean(struct json_node *, int *);
@@ -4287,15 +4287,15 @@ int json_get_object(struct json_node *,
struct json_node **);
int json_get_array(struct json_node *,
struct json_node **);
int json_find_string(const struct json_node *,
const char *, const char **, char **);
int json_find_number(const struct json_node *,
const char *, int64_t *, char **);
int json_find_boolean(const struct json_node *,
const char *, int *, char **);
int json_find_object(const struct json_node *,
const char *, struct json_node **, char **);
int json_find_array(const struct json_node *,
const char *, struct json_node **, char **);
int json_find_string(struct json_node *, const char *,
const char **, char **);
int json_find_number(struct json_node *, const char *,
int64_t *, char **);
int json_find_boolean(struct json_node *, const char *,
int *, char **);
int json_find_object(struct json_node *, const char *,
struct json_node **, char **);
int json_find_array(struct json_node *, const char *,
struct json_node **, char **);
#endif /* TMUX_H */