mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-11-13 22:08:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

D3D12 GPU: Prevent reading out of bounds when uploading textures.

Browse Source 
When the upload needs realignment, a new buffer is created to do the
upload, and the source data is copied to the new buffer. This commit
fixes the issue where the memcopy can read off the end of the source
buffer since it is reading based on destination pitch instead of source
pitch.
This commit is contained in:
Chris Genova
2025-11-07 17:32:37 -05:00
committed by Sam Lantinga
parent 1fb663b429
commit 6a01d6e7d3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/gpu/d3d12/SDL_gpu_d3d12.c
View File

@@ -5941,7 +5941,7 @@ static void D3D12_UploadToTexture(
SDL_memcpy( SDL_memcpy(
temporaryBuffer->mapPointer + (sliceIndex * rowsPerSlice) + (rowIndex * alignedRowPitch), temporaryBuffer->mapPointer + (sliceIndex * rowsPerSlice) + (rowIndex * alignedRowPitch),
transferBufferContainer->activeBuffer->mapPointer + source->offset + (sliceIndex * bytesPerSlice) + (rowIndex * rowPitch), transferBufferContainer->activeBuffer->mapPointer + source->offset + (sliceIndex * bytesPerSlice) + (rowIndex * rowPitch),
alignedRowPitch); rowPitch);
} }
Uint32 offset = source->offset + (sliceIndex * bytesPerSlice) + ((rowsPerSlice - 1) * rowPitch); Uint32 offset = source->offset + (sliceIndex * bytesPerSlice) + ((rowsPerSlice - 1) * rowPitch);
SDL_memcpy( SDL_memcpy(