mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-09-17 02:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

dbus: Use the minimum privileges when opening an fd for the OpenURI portal

Browse Source 
Open files and directories as read-only, as the fd is only used as proof of access by the portal, and a mismatch between fd write permissions and the portal write parameter will cause the fd to be rejected.
This commit is contained in:
Frank Praznik
2026-09-13 12:33:57 -04:00
parent f7cb5a8814
commit fb8cdf0aa8
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/core/linux/SDL_dbus.c
View File

@@ -27,6 +27,7 @@
#include "SDL_dbus.h"
#include <fcntl.h>
#include <sys/stat.h>
#include <unistd.h>
#ifdef SDL_USE_LIBDBUS
@@ -543,7 +544,19 @@ bool SDL_DBus_OpenURI(const char *uri, const char *window_id, const char *activa
}
uri = decoded_path;
}
fd = open(uri, O_RDWR | O_CLOEXEC);
struct stat st;
if (stat(uri, &st) == 0) {
/* Open files and directories as read-only, as the fd is only used as proof
* of access by the portal, and a mismatch between fd write permissions and
* the portal write parameter will cause the fd to be rejected.
*/
int oflags = O_RDONLY | O_CLOEXEC;
if (S_ISDIR(st.st_mode)) {
oflags |= O_DIRECTORY;
}
fd = open(uri, oflags);
}
SDL_free(decoded_path);
if (fd >= 0) {
msg = dbus.message_new_method_call(bus_name, path, interface, "OpenFile");