Update CHANGES and tests.

whinging about not supporting it, GitHub issue 5626 from Pete Dietl.

.github/workflows/regress.yml

@@ -27,10 +27,10 @@ jobs:
             runner: ubuntu-24.04
             make: make
             configure: --enable-utf8proc --enable-asan
-          - name: ubuntu-24.04-arm64
-            runner: ubuntu-24.04-arm
-            make: make
-            configure: --enable-utf8proc --enable-asan
+          #- name: ubuntu-24.04-arm64
+          #  runner: ubuntu-24.04-arm
+          #  make: make
+          #  configure: --enable-utf8proc --enable-asan
           - name: macos-26-arm64
             runner: macos-26
             make: gmake

CHANGES

@@ -10,8 +10,8 @@ CHANGES FROM 3.7c TO 3.8
   - modal panes may be created with new-pane -O; a window can have one modal
     pane and it prevents interaction with the other panes while it is active.
     -C closes the pane when the mouse is clicked outside it and -K sends all
-    keys, including the prefix key, to the pane. A modal pane is now used for
-    the editor in buffer mode;
+    keys, including the prefix key, to the pane. -D closes the modal pane with
+    Escape or C-c. A modal pane is now used for the editor in buffer mode;
 
   - new-pane -A creates a floating pane which remains above a zoomed pane;
     modal panes do this by default;
@@ -39,6 +39,9 @@ CHANGES FROM 3.7c TO 3.8
   The old format is still accepted; control mode clients receive old layouts
   unless they set the new-layouts flag.
 
+* Add remain-on-exit failed-key to keep a pane open after a failed command
+  until a key is pressed.
+
 * Add support for themes and improve default colours:
 
   - tmux now has builtin light and dark colour themes for terminals with 256 or
@@ -115,6 +118,12 @@ CHANGES FROM 3.7c TO 3.8
   in terminal-features, and add a utf8 feature for terminals which support
   UTF-8 output.
 
+* Add an appesc terminal feature for mintty's application escape key mode,
+  avoiding unsupported sequences on other terminals (Pete Dietl, issue 5626).
+
+* Preserve existing Ss and Se terminfo capabilities for cursor styles and
+  restoring the default cursor (issue 5476).
+
 * Add a #{A/count:frames} modifier to show a series of frames as an animation
   in the status line (issue 5412 from Fernando Daciuk).
 
@@ -189,10 +198,23 @@ CHANGES FROM 3.7c TO 3.8
   sent inside %begin/%end (issue 5458), do not let a stuck client prevent the
   server from exiting (issue 5444), and reset control mode offsets when a pane
   is respawned (issue 5498). Bound buffered command replies so a control mode
-  client that stops reading cannot consume unlimited memory (issue 5565).
+  client that stops reading cannot consume unlimited memory (issue 5565), and
+  fix a collision between the output discard and bracketed paste flags (issue
+  5622).
 
 * Fix grouped sessions sometimes being left as unusable command targets while
-  they are being killed (Bryce Miller, issue 5180).
+  they are being killed (Bryce Miller, issue 5180), and prevent reuse of a
+  session with no windows while detaching (Heon Jeong, issue 5620).
+
+* Free wait-for clients when they disconnect and do not run their remaining
+  queued commands (issue 5614).
+
+* Expand formats in run-shell -c like other start-directory flags (reported by
+  Saul Nogueras).
+
+* Fix session alert flag formats to check all windows (issue 5599).
+
+* Do not clear the marked pane when clicking on a pane border.
 
 * Fix choose mode filtering when more than one pane exists (issue 5326), and
   fix an infinite loop in customize mode when a filter does not match.
@@ -203,11 +225,18 @@ CHANGES FROM 3.7c TO 3.8
   status lines, menus, popups, wide characters and floating panes. This
   includes fixes for flicker with alternate screen applications and scrollbars
   (Michael Grant, issue 5351; Noam Stolero, issue 5350; Aung Myo Kyaw, issue
-  5098).
+  5098), and misplaced wrapped lines during partial redraws (Ben Maurer, issue
+  5625).
 
 * Do not crash looking for the next or previous session (issue 5344), or when
   no client is available.
 
+* Fix crashes when destroying a zoomed pane (Romain Francoise, issue 5591),
+  copying from a blank source pane (Kaixuan Li), or opening a mode prompt when
+  the client is offset into the window.
+
+* Avoid an infinite loop when assigning a width to WCHAR_MAX (issue 5602).
+
 CHANGES FROM 3.7b TO 3.7c
 
 * Build with jemalloc on macOS to avoid what appears to be a bug in calloc

Makefile.am

@@ -188,6 +188,7 @@ dist_tmux_SOURCES = \
 	options-table.c \
 	options.c \
 	paste.c \
+	popup.c \
 	proc.c \
 	prompt-history.c \
 	prompt.c \
@@ -257,8 +258,7 @@ check_PROGRAMS = \
 	fuzz/input-fuzzer \
 	fuzz/cmd-parse-fuzzer \
 	fuzz/format-fuzzer \
-	fuzz/style-fuzzer \
-	fuzz/layout-fuzzer
+	fuzz/style-fuzzer
 fuzz_input_fuzzer_LDFLAGS = $(FUZZING_LIBS)
 fuzz_input_fuzzer_LDADD = $(LDADD) $(tmux_OBJECTS)
 fuzz_cmd_parse_fuzzer_LDFLAGS = $(FUZZING_LIBS)
@@ -267,8 +267,6 @@ fuzz_format_fuzzer_LDFLAGS = $(FUZZING_LIBS)
 fuzz_format_fuzzer_LDADD = $(LDADD) $(tmux_OBJECTS)
 fuzz_style_fuzzer_LDFLAGS = $(FUZZING_LIBS)
 fuzz_style_fuzzer_LDADD = $(LDADD) $(tmux_OBJECTS)
-fuzz_layout_fuzzer_LDFLAGS = $(FUZZING_LIBS)
-fuzz_layout_fuzzer_LDADD = $(LDADD) $(tmux_OBJECTS)
 endif
 
 # Install tmux.1 in the right format.

SYNCING.md

@@ -35,7 +35,7 @@ The usual local layout is:
 ```sh
 cd /some/where/useful
 git clone https://github.com/tmux/tmux.git tmux-portable
-git clone https://github.com/tmux/tmux-openbsd-cutover.git tmux-openbsd-cutover
+git clone https://github.com/ThomasAdam/tmux-obsd.git tmux-openbsd-cutover
 ```
 
 The exact directory names do not matter, but the examples below use:
@@ -56,19 +56,18 @@ The cutover repository has three important branches:
 
 # Adding the OpenBSD remote to portable
 
-In the portable repository, add the published cutover repository as a remote.
-This works regardless of which branch is checked out in a local cutover clone:
+In the portable repository, add the cutover repository as a remote:
 
 ```sh
 cd /path/to/tmux-portable
-git remote add tmux-openbsd https://github.com/tmux/tmux-openbsd-cutover.git
+git remote add tmux-openbsd /path/to/tmux-openbsd-cutover
 git config remote.tmux-openbsd.tagOpt --no-tags
 ```
 
 If the remote already exists, update it instead:
 
 ```sh
-git remote set-url tmux-openbsd https://github.com/tmux/tmux-openbsd-cutover.git
+git remote set-url tmux-openbsd /path/to/tmux-openbsd-cutover
 git config remote.tmux-openbsd.tagOpt --no-tags
 ```
 
@@ -78,32 +77,6 @@ Fetch the cutover master branch explicitly:
 git fetch --no-tags tmux-openbsd master:refs/remotes/tmux-openbsd/master
 ```
 
-To merge unpublished changes from a local cutover clone instead, first ensure
-it has an up-to-date local `master` branch. A normal clone may check out
-`automation` and have only `origin/master`; fetching `master` from that clone
-will then fail with `couldn't find remote ref master`.
-
-With a clean cutover working tree:
-
-```sh
-cd /path/to/tmux-openbsd-cutover
-git fetch --no-tags origin
-git switch master
-git merge --ff-only origin/master
-```
-
-`git switch master` creates a tracking branch from `origin/master` if there is
-no local `master` yet. If the fast-forward fails, reconcile the local cutover
-changes before continuing; do not reset them away.
-
-Then, in portable, point the remote at that clone and fetch its local `master`:
-
-```sh
-cd /path/to/tmux-portable
-git remote set-url tmux-openbsd /path/to/tmux-openbsd-cutover
-git fetch --no-tags tmux-openbsd master:refs/remotes/tmux-openbsd/master
-```
-
 # Automated syncing
 
 The normal sync is performed by the GitHub Actions workflow in the
@@ -126,9 +99,7 @@ OpenBSD changes.
 If the workflow fails while merging into portable, do the merge locally and
 push the result.
 
-Start with a clean working tree and an up-to-date portable master. If a merge
-is already in progress, skip to resolving conflicts, or abort it before
-starting again:
+Start from an up-to-date portable master:
 
 ```sh
 cd /path/to/tmux-portable
@@ -137,15 +108,10 @@ git checkout master
 git pull --ff-only origin master
 ```
 
-Fetch the published cutover branch. Update an existing remote as well, since
-it may point at a local clone without a `master` branch or with a stale one:
+Fetch the cutover branch:
 
 ```sh
-if git remote get-url tmux-openbsd >/dev/null 2>&1; then
-    git remote set-url tmux-openbsd https://github.com/tmux/tmux-openbsd-cutover.git
-else
-    git remote add tmux-openbsd https://github.com/tmux/tmux-openbsd-cutover.git
-fi
+git remote add tmux-openbsd /path/to/tmux-openbsd-cutover 2>/dev/null || true
 git config remote.tmux-openbsd.tagOpt --no-tags
 git fetch --no-tags tmux-openbsd master:refs/remotes/tmux-openbsd/master
 ```
@@ -156,22 +122,7 @@ Merge it:
 git merge --no-ff --log refs/remotes/tmux-openbsd/master
 ```
 
-If merging a local cutover branch instead, use the local-clone preparation
-and fetch commands above in place of this fetch block.
-
-When the merge reports conflicts, it leaves the merge in progress. List the
-unresolved files, edit the conflict markers to combine the required portable
-and OpenBSD changes, then stage each resolved file:
-
-```sh
-git diff --name-only --diff-filter=U
-git diff -- path/to/file
-git add path/to/file
-```
-
-For files that should come entirely from one side, decide whether portable or
-OpenBSD owns the file before using the commands below. They replace the whole
-file, including changes outside the conflicting hunks.
+Resolve conflicts by deciding whether portable or OpenBSD owns the file.
 
 Useful commands:
 
@@ -189,25 +140,11 @@ git add path/to/file
 
 This takes the OpenBSD/cutover version of a conflicted file.
 
-For a modify/delete conflict, the side that deleted the file has no version
-to check out. For example, portable generates `Makefile` using autotools and
-does not track OpenBSD's `Makefile`. If Git reports that `Makefile` was deleted
-in HEAD and modified in cutover, keep the portable deletion with:
-
-```sh
-git rm -- Makefile
-```
-
-This removes the OpenBSD file left by the merge; regenerate the portable
-`Makefile` with your usual configure command before building. Use this only
-for the unmerged OpenBSD file, not an existing generated build file.
-
 Before committing, inspect the result:
 
 ```sh
 git status
 git diff --check
-git diff --cached --check
 git diff --cached --stat
 ```
 

cmd-attach-session.c

@@ -91,10 +91,8 @@ cmd_attach_session(struct cmdq_item *item, const char *tflag, int dflag,
 	wp = target.wp;
 
 	if (wl != NULL) {
-		if (wp != NULL) {
-			window_redraw_active_switch(wp->window, wp);
+		if (wp != NULL)
 			window_set_active_pane(wp->window, wp, 1);
-		}
 		session_set_current(s, wl);
 		if (wp != NULL)
 			cmd_find_from_winlink_pane(current, wl, wp, 0);

cmd-display-menu.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: cmd-display-menu.c,v 1.55 2026/09/21 12:14:32 nicm Exp $ */
+/* $OpenBSD: cmd-display-menu.c,v 1.53 2026/08/31 07:46:55 nicm Exp $ */
 
 /*
  * Copyright (c) 2019 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -54,8 +54,8 @@ const struct cmd_entry cmd_display_popup_entry = {
 	.name = "display-popup",
 	.alias = "popup",
 
-	.args = { "Bb:Cc:d:e:Eh:ks:S:t:T:w:x:y:", 0, -1, NULL },
-	.usage = "[-BCEk] [-b border-lines] [-c target-client] "
+	.args = { "Bb:Cc:d:e:Eh:kNs:S:t:T:w:x:y:", 0, -1, NULL },
+	.usage = "[-BCEkN] [-b border-lines] [-c target-client] "
 		 "[-d start-directory] [-e environment] [-h height] "
 		 "[-s style] [-S border-style] " CMD_TARGET_PANE_USAGE
 		 " [-T title] [-w width] [-x position] [-y position] "
@@ -91,6 +91,203 @@ cmd_display_menu_args_parse(struct args *args, u_int idx, __unused char **cause)
 	return (type);
 }
 
+static int
+cmd_display_menu_get_popup_pos(struct client *tc, struct cmdq_item *item,
+    struct args *args, u_int *px, u_int *py, u_int w, u_int h)
+{
+	struct tty		*tty = &tc->tty;
+	struct cmd_find_state	*target = cmdq_get_target(item);
+	struct key_event	*event = cmdq_get_event(item);
+	struct session		*s = tc->session;
+	struct winlink		*wl = target->wl;
+	struct window_pane	*wp = target->wp;
+	struct style_ranges	*ranges = NULL;
+	struct style_range	*sr = NULL;
+	const char		*xp, *yp;
+	char			*p;
+	int			 top;
+	u_int			 line, ox, oy, sx, sy, lines, position;
+	long			 n;
+	struct format_tree	*ft;
+
+	/*
+	 * Work out the position from the -x and -y arguments. This is the
+	 * bottom-left position.
+	 */
+
+	/* If the popup is too big, stop now. */
+	if (w > tty->sx || h > tty->sy)
+		return (0);
+
+	/* Create format with mouse position if any. */
+	ft = format_create_from_target(item);
+	if (event->m.valid) {
+		format_add(ft, "popup_mouse_x", "%u", event->m.x);
+		format_add(ft, "popup_mouse_y", "%u", event->m.y);
+	}
+
+	/* Position of the previous menu, for -x/-y L. */
+	format_add(ft, "popup_last_x", "%u", target->w->menu_last_px);
+	format_add(ft, "popup_last_y", "%u", target->w->menu_last_py + h);
+
+	/*
+	 * If there are any status lines, add this window position and the
+	 * status line position.
+	 */
+	top = status_at_line(tc);
+	if (top != -1) {
+		lines = status_line_size(tc);
+		if (top == 0)
+			top = lines;
+		else
+			top = 0;
+		position = options_get_number(s->options, "status-position");
+
+		for (line = 0; line < lines; line++) {
+			ranges = &tc->status.entries[line].ranges;
+			TAILQ_FOREACH(sr, ranges, entry) {
+				if (sr->type != STYLE_RANGE_WINDOW)
+					continue;
+				if (sr->argument == (u_int)wl->idx)
+					break;
+			}
+			if (sr != NULL)
+				break;
+		}
+
+		if (sr != NULL) {
+			format_add(ft, "popup_window_status_line_x", "%u",
+			    sr->start);
+			if (position == 0) {
+				format_add(ft, "popup_window_status_line_y",
+				    "%u", line + 1 + h);
+			} else {
+				format_add(ft, "popup_window_status_line_y",
+				    "%u", tty->sy - lines + line);
+			}
+		}
+
+		if (position == 0)
+			format_add(ft, "popup_status_line_y", "%u", lines + h);
+		else {
+			format_add(ft, "popup_status_line_y", "%u",
+			    tty->sy - lines);
+		}
+	} else
+		top = 0;
+
+	/* Popup width and height. */
+	format_add(ft, "popup_width", "%u", w);
+	format_add(ft, "popup_height", "%u", h);
+
+	/* Position so popup is in the centre. */
+	n = (long)(tty->sx - 1) / 2 - w / 2;
+	if (n < 0)
+		format_add(ft, "popup_centre_x", "%u", 0);
+	else
+		format_add(ft, "popup_centre_x", "%ld", n);
+	n = (tty->sy - 1) / 2 + h / 2;
+	if (n >= tty->sy)
+		format_add(ft, "popup_centre_y", "%u", tty->sy - h);
+	else
+		format_add(ft, "popup_centre_y", "%ld", n);
+
+	/* Position of popup relative to mouse. */
+	if (event->m.valid) {
+		n = (long)event->m.x - w / 2;
+		if (n < 0)
+			format_add(ft, "popup_mouse_centre_x", "%u", 0);
+		else
+			format_add(ft, "popup_mouse_centre_x", "%ld", n);
+		n = event->m.y - h / 2;
+		if (n + h >= tty->sy) {
+			format_add(ft, "popup_mouse_centre_y", "%u",
+			    tty->sy - h);
+		} else
+			format_add(ft, "popup_mouse_centre_y", "%ld", n);
+		n = (long)event->m.y + h;
+		if (n >= tty->sy)
+			format_add(ft, "popup_mouse_top", "%u", tty->sy - 1);
+		else
+			format_add(ft, "popup_mouse_top", "%ld", n);
+		n = event->m.y - h;
+		if (n < 0)
+			format_add(ft, "popup_mouse_bottom", "%u", 0);
+		else
+			format_add(ft, "popup_mouse_bottom", "%ld", n);
+	}
+
+	/* Position in pane. */
+	tty_window_offset(&tc->tty, &ox, &oy, &sx, &sy);
+	n = top + wp->yoff - oy + h;
+	if (n >= tty->sy)
+		format_add(ft, "popup_pane_top", "%u", tty->sy - h);
+	else
+		format_add(ft, "popup_pane_top", "%ld", n);
+	format_add(ft, "popup_pane_bottom", "%u", top + wp->yoff + wp->sy - oy);
+	format_add(ft, "popup_pane_left", "%u", wp->xoff - ox);
+	n = (long)wp->xoff + wp->sx - ox - w;
+	if (n < 0)
+		format_add(ft, "popup_pane_right", "%u", 0);
+	else
+		format_add(ft, "popup_pane_right", "%ld", n);
+
+	/* Expand horizontal position. */
+	xp = args_get(args, 'x');
+	if (xp == NULL || strcmp(xp, "C") == 0)
+		xp = "#{popup_centre_x}";
+	else if (strcmp(xp, "R") == 0)
+		xp = "#{popup_pane_right}";
+	else if (strcmp(xp, "P") == 0)
+		xp = "#{popup_pane_left}";
+	else if (strcmp(xp, "M") == 0)
+		xp = "#{popup_mouse_centre_x}";
+	else if (strcmp(xp, "L") == 0)
+		xp = "#{popup_last_x}";
+	else if (strcmp(xp, "W") == 0)
+		xp = "#{popup_window_status_line_x}";
+	p = format_expand(ft, xp);
+	n = strtol(p, NULL, 10);
+	if (n + w >= tty->sx)
+		n = tty->sx - w;
+	else if (n < 0)
+		n = 0;
+	*px = n;
+	log_debug("%s: -x: %s = %s = %u (-w %u)", __func__, xp, p, *px, w);
+	free(p);
+
+	/* Expand vertical position  */
+	yp = args_get(args, 'y');
+	if (yp == NULL || strcmp(yp, "C") == 0)
+		yp = "#{popup_centre_y}";
+	else if (strcmp(yp, "P") == 0)
+		yp = "#{popup_pane_bottom}";
+	else if (strcmp(yp, "M") == 0)
+		yp = "#{popup_mouse_top}";
+	else if (strcmp(yp, "L") == 0)
+		yp = "#{popup_last_y}";
+	else if (strcmp(yp, "S") == 0)
+		yp = "#{popup_status_line_y}";
+	else if (strcmp(yp, "W") == 0)
+		yp = "#{popup_window_status_line_y}";
+	p = format_expand(ft, yp);
+	n = strtol(p, NULL, 10);
+	if (n < h)
+		n = 0;
+	else
+		n -= h;
+	if (n + h >= tty->sy)
+		n = tty->sy - h;
+	else if (n < 0)
+		n = 0;
+	*py = n;
+	log_debug("%s: -y: %s = %s = %u (-h %u)", __func__, yp, p, *py, h);
+	free(p);
+
+	format_free(ft);
+	return (1);
+}
+
 static int
 cmd_display_menu_get_menu_pos(struct client *tc, struct cmdq_item *item,
     struct args *args, u_int *px, u_int *py, u_int w, u_int h)
@@ -285,8 +482,8 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
 	enum box_lines		 lines = BOX_LINES_DEFAULT;
 	char			*title, *cause = NULL;
 	int			 flags = 0, starting_choice = 0;
-	u_int			 px, py, sx, sy, i, count = args_count(args);
-	struct options		*o = target->w->options;
+	u_int			 px, py, i, count = args_count(args);
+	struct options		*o = target->s->curw->window->options;
 	struct options_entry	*oe;
 
 	if (args_has(args, 'C')) {
@@ -334,6 +531,9 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
 	}
 	if (menu->count == 0)
 		goto out;
+	if (!cmd_display_menu_get_menu_pos(tc, item, args, &px, &py,
+	    menu->width + 4, menu->count + 2))
+		goto out;
 
 	value = args_get(args, 'b');
 	if (value != NULL) {
@@ -344,11 +544,7 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
 			cmdq_error(item, "menu-border-lines %s", cause);
 			goto fail;
 		}
-	} else
-		lines = options_get_number(o, "menu-border-lines");
-	menu_get_size(menu, lines, &sx, &sy);
-	if (!cmd_display_menu_get_menu_pos(tc, item, args, &px, &py, sx, sy))
-		goto out;
+	}
 
 	if (args_has(args, 'O'))
 		flags |= MENU_STAYOPEN;
@@ -369,22 +565,6 @@ fail:
 	return (CMD_RETURN_ERROR);
 }
 
-static enum pane_lines
-cmd_display_popup_get_lines(const char *value, char **cause)
-{
-	const struct options_table_entry	*oe;
-
-	if (value == NULL)
-		value = "single";
-	else if (strcmp(value, "rounded") == 0)
-		value = "single";
-	else if (strcmp(value, "padded") == 0)
-		value = "spaces";
-
-	oe = options_search("pane-border-lines");
-	return (options_find_choice(oe, value, cause));
-}
-
 static enum cmd_retval
 cmd_display_popup_exec(struct cmd *self, struct cmdq_item *item)
 {
@@ -392,199 +572,148 @@ cmd_display_popup_exec(struct cmd *self, struct cmdq_item *item)
 	struct cmd_find_state	*target = cmdq_get_target(item);
 	struct session		*s = target->s;
 	struct client		*tc = cmdq_get_target_client(item);
-	struct winlink		*wl = target->wl;
-	struct window		*w = wl->window;
-	struct window_pane	*wp = target->wp, *new_wp = NULL;
-	struct spawn_context	 sc = { 0 };
-	struct layout_cell	*lc = NULL;
-	struct layout_geometry	 lg;
-	struct event_payload	*ep;
-	struct cmd_find_state	 fs;
-	const char		*value, *style = args_get(args, 's');
+	struct tty		*tty = &tc->tty;
+	const char		*value, *shell, *shellcmd = NULL;
+	const char		*style = args_get(args, 's');
 	const char		*border_style = args_get(args, 'S');
-	char			*cause = NULL, *title = NULL;
-	enum pane_lines		 lines = PANE_LINES_SINGLE;
-	u_int			 px, py, sx, sy, count = args_count(args);
+	char			*cwd = NULL, *cause = NULL, **argv = NULL;
+	char			*title = NULL;
+	int			 modify = popup_present(tc);
+	int			 flags = -1, argc = 0;
+	enum box_lines		 lines = BOX_LINES_DEFAULT;
+	u_int			 px, py, w, h, count = args_count(args);
 	struct args_value	*av;
-	long long		 ll;
+	struct environ		*env = NULL;
+	struct options		*o = s->curw->window->options;
+	struct options_entry	*oe;
 
 	if (args_has(args, 'C')) {
-		if (w->modal != NULL)
-			server_kill_pane(w->modal);
+		server_client_clear_overlay(tc);
 		return (CMD_RETURN_NORMAL);
 	}
 	if (tc->flags & CLIENT_CONTROL)
 		return (CMD_RETURN_NORMAL);
-	if (w->modal != NULL)
+	if (!modify && tc->overlay_draw != NULL)
 		return (CMD_RETURN_NORMAL);
 
+	if (!modify) {
+		h = tty->sy / 2;
+		if (args_has(args, 'h')) {
+			h = args_percentage(args, 'h', 1, tty->sy, tty->sy,
+			    &cause);
+			if (cause != NULL) {
+				cmdq_error(item, "height %s", cause);
+				goto fail;
+			}
+		}
+
+		w = tty->sx / 2;
+		if (args_has(args, 'w')) {
+			w = args_percentage(args, 'w', 1, tty->sx, tty->sx,
+			    &cause);
+			if (cause != NULL) {
+				cmdq_error(item, "width %s", cause);
+				goto fail;
+			}
+		}
+
+		if (w > tty->sx)
+			w = tty->sx;
+		if (h > tty->sy)
+			h = tty->sy;
+		if (!cmd_display_menu_get_popup_pos(tc, item, args, &px, &py,
+		    w, h))
+			goto out;
+
+		value = args_get(args, 'd');
+		if (value != NULL)
+			cwd = format_single_from_target(item, value);
+		else
+			cwd = xstrdup(server_client_get_cwd(tc, s));
+		if (count == 0) {
+			shellcmd = options_get_string(s->options,
+			    "default-command");
+		} else if (count == 1)
+			shellcmd = args_string(args, 0);
+		if (count <= 1 && (shellcmd == NULL || *shellcmd == '\0')) {
+			shellcmd = NULL;
+			shell = options_get_string(s->options, "default-shell");
+			if (!checkshell(shell))
+				shell = _PATH_BSHELL;
+			cmd_append_argv(&argc, &argv, shell);
+		} else
+			args_to_vector(args, &argc, &argv);
+
+		if (args_has(args, 'e') >= 1) {
+			env = environ_create();
+			av = args_first_value(args, 'e');
+			while (av != NULL) {
+				environ_put(env, av->string, 0);
+				av = args_next_value(av);
+			}
+		}
+	}
+
 	value = args_get(args, 'b');
 	if (args_has(args, 'B'))
-		lines = PANE_LINES_NONE;
+		lines = BOX_LINES_NONE;
 	else if (value != NULL) {
-		lines = cmd_display_popup_get_lines(value, &cause);
+		oe = options_get(o, "popup-border-lines");
+		lines = options_find_choice(options_table_entry(oe), value,
+		    &cause);
 		if (cause != NULL) {
-			cmdq_error(item, "pane-border-lines %s", cause);
+			cmdq_error(item, "popup-border-lines %s", cause);
 			goto fail;
 		}
 	}
 
-	sy = w->sy / 2;
-	if (args_has(args, 'h')) {
-		ll = args_percentage(args, 'h', 1, w->sy, w->sy, &cause);
-		if (cause != NULL) {
-			cmdq_error(item, "height %s", cause);
-			goto fail;
-		}
-		sy = ll;
-	}
-
-	sx = w->sx / 2;
-	if (args_has(args, 'w')) {
-		ll = args_percentage(args, 'w', 1, w->sx, w->sx, &cause);
-		if (cause != NULL) {
-			cmdq_error(item, "width %s", cause);
-			goto fail;
-		}
-		sx = ll;
-	}
-
-	if (sx > w->sx)
-		sx = w->sx;
-	if (sy > w->sy)
-		sy = w->sy;
-	if ((lines == PANE_LINES_NONE && (sx < 1 || sy < 1)) ||
-	    (lines != PANE_LINES_NONE && (sx < 3 || sy < 3)))
-		goto out;
-	if (!cmd_display_menu_get_menu_pos(tc, item, args, &px, &py, sx, sy))
-		goto out;
-
-	lg.sx = sx;
-	lg.sy = sy;
-	lg.xoff = px;
-	lg.yoff = py;
-	if (lines != PANE_LINES_NONE) {
-		lg.sx -= 2;
-		lg.sy -= 2;
-		lg.xoff++;
-		lg.yoff++;
-	}
-
-	window_push_zoom(w, 0, 1);
-	lc = layout_floating_pane(w, wp, &lg);
-	if (lc == NULL) {
-		window_pop_zoom(w);
-		goto out;
-	}
-
-	sc.item = item;
-	sc.s = s;
-	sc.wl = wl;
-	sc.tc = tc;
-	sc.wp0 = wp;
-	sc.lc = lc;
-	sc.idx = -1;
-	sc.cwd = args_get(args, 'd');
-	sc.flags = (SPAWN_FLOATING|SPAWN_MODAL|SPAWN_FLOATOVERZOOM);
-
-	if (count != 1 || *args_string(args, 0) != '\0')
-		args_to_vector(args, &sc.argc, &sc.argv);
-	sc.environ = environ_create();
-	av = args_first_value(args, 'e');
-	while (av != NULL) {
-		environ_put(sc.environ, av->string, 0);
-		av = args_next_value(av);
-	}
-
-	new_wp = spawn_pane(&sc, &cause);
-	if (new_wp == NULL) {
-		cmdq_error(item, "create pane failed: %s", cause);
-		free(cause);
-		cause = NULL;
-		window_pop_zoom(w);
-		goto fail;
-	}
-	window_pop_zoom(w);
-	new_wp->flags |= PANE_CAPTUREALLKEYS;
-	if (!args_has(args, 'E'))
-		new_wp->flags |= PANE_CLOSEONCANCEL;
-
-	options_set_number(new_wp->options, "pane-border-lines", lines);
-	if (args_has(args, 'E') > 1) {
-		if (args_has(args, 'k'))
-			options_set_number(new_wp->options, "remain-on-exit", 4);
-		else
-			options_set_number(new_wp->options, "remain-on-exit", 2);
-	} else if (args_has(args, 'E'))
-		options_set_number(new_wp->options, "remain-on-exit", 0);
-	else if (args_has(args, 'k'))
-		options_set_number(new_wp->options, "remain-on-exit", 3);
-	else
-		options_set_number(new_wp->options, "remain-on-exit", 1);
-	options_set_string(new_wp->options, "remain-on-exit-format", 0, "%s", "");
-
-	if (style != NULL) {
-		if (options_set_string(new_wp->options, "window-style", 0,
-		    "%s", style) == NULL) {
-			cmdq_error(item, "bad style: %s", style);
-			goto fail;
-		}
-		options_set_string(new_wp->options, "window-active-style", 0,
-		    "%s", style);
-		new_wp->flags |= (PANE_REDRAW|PANE_STYLECHANGED|
-		    PANE_THEMECHANGED);
-	}
-	if (border_style != NULL) {
-		if (options_set_string(new_wp->options, "pane-border-style", 0,
-		    "%s", border_style) == NULL) {
-			cmdq_error(item, "bad border style: %s", border_style);
-			goto fail;
-		}
-		options_set_string(new_wp->options, "pane-active-border-style",
-		    0, "%s", border_style);
-	}
 	if (args_has(args, 'T'))
 		title = format_single_from_target(item, args_get(args, 'T'));
-	if (title != NULL) {
-		options_set_number(new_wp->options, "pane-border-status",
-		    PANE_STATUS_TOP);
-		options_set_string(new_wp->options, "pane-border-format", 0,
-		    "%s", "#{pane_title}");
-		screen_set_title(&new_wp->base, title, 0);
-		ep = event_payload_create();
-		cmd_find_from_pane(&fs, new_wp, 0);
-		event_payload_set_target(ep, &fs);
-		event_payload_set_pane(ep, "pane", new_wp);
-		event_payload_set_window(ep, "window", new_wp->window);
-		event_payload_set_string(ep, "new_title", "%s", title);
-		events_fire("pane-title-changed", ep);
+	else
+		title = xstrdup("");
+
+	if (args_has(args, 'N') || !modify)
+		flags = 0;
+	if (args_has(args, 'E') > 1) {
+		if (flags == -1)
+			flags = 0;
+		flags |= POPUP_CLOSEEXITZERO;
+	} else if (args_has(args, 'E')) {
+		if (flags == -1)
+			flags = 0;
+		flags |= POPUP_CLOSEEXIT;
+	}
+	if (args_has(args, 'k')) {
+		if (flags == -1)
+			flags = 0;
+		flags |= POPUP_CLOSEANYKEY;
 	}
 
-	new_wp->wait_item = item;
-	server_redraw_session(s);
-	if (sc.argv != NULL)
-		cmd_free_argv(sc.argc, sc.argv);
-	environ_free(sc.environ);
+	if (modify) {
+		popup_modify(tc, title, style, border_style, lines, flags);
+		goto out;
+	}
+	if (popup_display(flags, lines, item, px, py, w, h, env, shellcmd, argc,
+	    argv, cwd, title, tc, s, style, border_style, NULL, NULL) != 0)
+		goto out;
+	environ_free(env);
+	free(cwd);
 	free(title);
+	cmd_free_argv(argc, argv);
 	return (CMD_RETURN_WAIT);
 
 out:
-	if (sc.argv != NULL)
-		cmd_free_argv(sc.argc, sc.argv);
-	environ_free(sc.environ);
+	cmd_free_argv(argc, argv);
+	environ_free(env);
+	free(cwd);
 	free(title);
 	return (CMD_RETURN_NORMAL);
 
 fail:
 	free(cause);
-	if (new_wp != NULL) {
-		server_client_remove_pane(new_wp);
-		layout_close_pane(new_wp);
-		window_remove_pane(new_wp->window, new_wp);
-	}
-	if (sc.argv != NULL)
-		cmd_free_argv(sc.argc, sc.argv);
-	environ_free(sc.environ);
+	cmd_free_argv(argc, argv);
+	environ_free(env);
+	free(cwd);
 	free(title);
 	return (CMD_RETURN_ERROR);
 }

cmd-join-pane.c

@@ -307,7 +307,7 @@ cmd_join_pane_mouse_move(struct client *c, struct mouse_event *m)
 	struct window		*w;
 	struct window_pane	*wp;
 	struct layout_cell	*lc;
-	int			 y, ly, x, lx, oxoff, oyoff, osx, osy;
+	int			 y, ly, x, lx;
 
 	wp = cmd_mouse_pane(m, NULL, &wl);
 	if (wp == NULL) {
@@ -329,16 +329,10 @@ cmd_join_pane_mouse_move(struct client *c, struct mouse_event *m)
 		ly = m->statusat - 1;
 
 	if (x != lx || y != ly) {
-		oxoff = wp->xoff;
-		oyoff = wp->yoff;
-		osx = wp->sx;
-		osy = wp->sy;
-
 		lc->g.xoff += x - lx;
 		lc->g.yoff += y - ly;
 		layout_fix_panes(w, NULL);
-
-		window_redraw_floating_pane(wp, oxoff, oyoff, osx, osy);
+		server_redraw_window(w);
 		server_redraw_window_borders(w);
 	}
 }

cmd-resize-pane.c

@@ -237,8 +237,8 @@ cmd_resize_pane_mouse_resize_move_floating(struct client *c,
 	struct window_pane	*wp;
 	struct layout_cell	*lc;
 	int			 y, ly, x, lx, sx, sy, new_sx, new_sy;
-	int			 left, right, resizes = 0;
-	int			 new_xoff, new_yoff, old_xoff, old_yoff;
+	int			 left, right;
+	int			 new_xoff, new_yoff, resizes = 0;
 
 	wp = cmd_mouse_pane(m, NULL, &wl);
 	if (wp == NULL) {
@@ -249,8 +249,6 @@ cmd_resize_pane_mouse_resize_move_floating(struct client *c,
 	lc = wp->layout_cell;
 	sx = wp->sx;
 	sy = wp->sy;
-	old_xoff = wp->xoff;
-	old_yoff = wp->yoff;
 	left = wp->xoff - 1;
 	right = wp->xoff + sx;
 	if (window_pane_scrollbar_reserve(wp) &&
@@ -350,7 +348,7 @@ cmd_resize_pane_mouse_resize_move_floating(struct client *c,
 	}
 	if (resizes != 0) {
 		layout_fix_panes(w, NULL);
-		window_redraw_floating_pane(wp, old_xoff, old_yoff, sx, sy);
+		server_redraw_window(w);
 		server_redraw_window_borders(w);
 	}
 }

cmd-split-window.c

@@ -362,7 +362,6 @@ cmd_split_window_mouse_resize(struct client *c, struct mouse_event *m)
 	enum pane_lines		 lines;
 	u_int			 sx, sy;
 	int			 x, y, xoff, yoff, border;
-	int			 oxoff, oyoff, osx, osy;
 
 	if (c->tty.mouse_last_pane == -1)
 		return;
@@ -418,14 +417,8 @@ cmd_split_window_mouse_resize(struct client *c, struct mouse_event *m)
 	if (sy < PANE_MINIMUM)
 		sy = PANE_MINIMUM;
 
-	oxoff = wp->xoff;
-	oyoff = wp->yoff;
-	osx = wp->sx;
-	osy = wp->sy;
-
 	layout_set_size(lc, sx, sy, xoff, yoff);
 	layout_fix_panes(w, NULL);
-
-	window_redraw_floating_pane(wp, oxoff, oyoff, osx, osy);
+	server_redraw_window(w);
 	server_redraw_window_borders(w);
 }

configure.ac

@@ -1,6 +1,6 @@
 # configure.ac
 
-AC_INIT([tmux], next-3.9)
+AC_INIT([tmux], 3.8-rc2)
 AC_PREREQ([2.60])
 
 AC_CONFIG_AUX_DIR(etc)

fuzz/input-fuzzer.c

@@ -44,7 +44,7 @@ LLVMFuzzerTestOneInput(const u_char *data, size_t size)
 	w = window_create(PANE_WIDTH, PANE_HEIGHT, 0, 0);
 	wp = window_add_pane(w, NULL, 0, 0);
 	bufferevent_pair_new(libevent, BEV_OPT_CLOSE_ON_FREE, vpty);
-	wp->ictx = input_init(wp, vpty[0], NULL);
+	wp->ictx = input_init(wp, vpty[0], NULL, NULL);
 	window_add_ref(w, __func__);
 
 	wp->fd = open("/dev/null", O_WRONLY);

fuzz/layout-fuzzer.c

@@ -1,111 +0,0 @@
-/*
- * Copyright (c) 2026 Arthur Chan <arthur.chan@adalogics.com>
- *
- * Permission to use, copy, modify, and distribute this software for any
- * purpose with or without fee is hereby granted, provided that the above
- * copyright notice and this permission notice appear in all copies.
- *
- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- * WHATSOEVER RESULTING FROM LOSS OF MIND, USE, DATA OR PROFITS, WHETHER
- * IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
- * OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-
-/*
- * Fuzz the custom layout parser.
- *
- * A layout string such as "bb62,80x24,0,0{40x24,0,0,1,39x24,41,0,2}" is
- * accepted by select-layout and is what tmux stores and restores for a
- * window, so it is parsed from configuration and from commands. It drives
- * layout-custom.c (the string parser and the checksum), then layout.c, which
- * resizes and assigns the cells.
- *
- * layout_parse() refuses a window with no panes, and refuses a layout whose
- * cell count is smaller than the pane count, so the window is given a fixed
- * number of panes. The count is fixed rather than derived from the input, so
- * a mutation always means a different layout string.
- */
-
-#include <sys/types.h>
-
-#include <stddef.h>
-#include <stdlib.h>
-#include <string.h>
-
-#include "tmux.h"
-
-#define FUZZER_MAXLEN 1024
-#define FUZZER_PANES 4
-
-struct event_base	*libevent;
-
-int
-LLVMFuzzerTestOneInput(const u_char *data, size_t size)
-{
-	struct window		*w;
-	struct window_pane	*wp;
-	char			*buf, *cause = NULL, *dump;
-	u_int			 i;
-
-	if (size == 0 || size > FUZZER_MAXLEN)
-		return 0;
-
-	/* layout_parse() takes a C string. */
-	buf = malloc(size + 1);
-	if (buf == NULL)
-		return 0;
-	memcpy(buf, data, size);
-	buf[size] = '\0';
-
-	w = window_create(80, 24, 0, 0);
-	if (w == NULL) {
-		free(buf);
-		return 0;
-	}
-	window_add_ref(w, __func__);
-
-	for (i = 0; i < FUZZER_PANES; i++) {
-		wp = window_add_pane(w, NULL, 0, 0);
-		if (w->active == NULL)
-			w->active = wp;
-	}
-
-	if (layout_parse(w, buf, &cause) == 0) {
-		dump = layout_dump(w, w->layout_root, 1);
-		free(dump);
-	}
-	free(cause);
-
-	window_remove_ref(w, __func__);
-
-	free(buf);
-	return 0;
-}
-
-int
-LLVMFuzzerInitialize(__unused int *argc, __unused char ***argv)
-{
-	const struct options_table_entry	*oe;
-
-	global_environ = environ_create();
-	global_options = options_create(NULL);
-	global_s_options = options_create(NULL);
-	global_w_options = options_create(NULL);
-	for (oe = options_table; oe->name != NULL; oe++) {
-		if (oe->scope & OPTIONS_TABLE_SERVER)
-			options_default(global_options, oe);
-		if (oe->scope & OPTIONS_TABLE_SESSION)
-			options_default(global_s_options, oe);
-		if (oe->scope & OPTIONS_TABLE_WINDOW)
-			options_default(global_w_options, oe);
-	}
-
-	libevent = osdep_event_init();
-
-	socket_path = xstrdup("dummy");
-
-	return 0;
-}

fuzz/layout-fuzzer.dict

@@ -1,17 +0,0 @@
-# tmux custom layout strings: "<checksum>,<sx>x<sy>,<x>,<y>{...}" / "[...]"
-","
-"x"
-"{"
-"}"
-"["
-"]"
-"0"
-"1"
-"80x24,0,0"
-"40x24,0,0"
-"bb62,"
-"cafe,"
-",0,0,0"
-",0,0{"
-",0,0["
-"@"

fuzz/layout-fuzzer.options

@@ -1,2 +0,0 @@
-[libfuzzer]
-max_len = 1024

input.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: input.c,v 1.272 2026/09/21 10:22:31 nicm Exp $ */
+/* $OpenBSD: input.c,v 1.271 2026/08/31 19:34:09 nicm Exp $ */
 
 /*
  * Copyright (c) 2007 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -101,6 +101,7 @@ struct input_ctx {
 	struct bufferevent	       *event;
 	struct screen_write_ctx		ctx;
 	struct colour_palette	       *palette;
+	struct client		       *c;
 
 	struct input_cell		cell;
 	struct input_cell		old_cell;
@@ -873,7 +874,7 @@ input_restore_state(struct input_ctx *ictx)
 /* Initialise input parser. */
 struct input_ctx *
 input_init(struct window_pane *wp, struct bufferevent *bev,
-    struct colour_palette *palette)
+    struct colour_palette *palette, struct client *c)
 {
 	struct input_ctx	*ictx;
 
@@ -881,6 +882,7 @@ input_init(struct window_pane *wp, struct bufferevent *bev,
 	ictx->wp = wp;
 	ictx->event = bev;
 	ictx->palette = palette;
+	ictx->c = c;
 
 	ictx->input_space = INPUT_BUF_START;
 	ictx->input_buf = xmalloc(INPUT_BUF_START);
@@ -3423,9 +3425,15 @@ input_osc_52(struct input_ctx *ictx, const char *p)
 		return;
 
 	if (wp == NULL) {
-		free(out);
-		return;
+		/* Popup window. */
+		if (ictx->c == NULL) {
+			free(out);
+			return;
+		}
+		tty_set_selection(&ictx->c->tty, clip, out, outlen);
+		paste_add(NULL, out, outlen);
 	} else {
+		/* Normal window. */
 		screen_write_start_pane(&ctx, wp, NULL);
 		screen_write_setselection(&ctx, clip, out, outlen);
 		screen_write_stop(&ctx);

layout.c

@@ -469,6 +469,7 @@ layout_fix_panes(struct window *w, struct window_pane *skip)
 					sx = PANE_MINIMUM;
 				else
 					sx = sx - sb_w - sb_pad;
+			wp->flags |= PANE_REDRAWSCROLLBAR;
 		}
 
 		window_pane_resize(wp, sx, sy);
@@ -476,11 +477,8 @@ layout_fix_panes(struct window *w, struct window_pane *skip)
 		if (wp->xoff != old_xoff ||
 		    wp->yoff != old_yoff ||
 		    wp->sx != old_sx ||
-		    wp->sy != old_sy) {
-			if (window_pane_scrollbar_reserve(wp))
-				wp->flags |= PANE_REDRAWSCROLLBAR;
+		    wp->sy != old_sy)
 			changed = 1;
-		}
 	}
 	if (changed)
 		redraw_invalidate_scene(w);

menu.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: menu.c,v 1.71 2026/09/21 12:14:32 nicm Exp $ */
+/* $OpenBSD: menu.c,v 1.70 2026/08/17 07:33:55 nicm Exp $ */
 
 /*
  * Copyright (c) 2019 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -51,18 +51,6 @@ struct menu_data {
 	void			*data;
 };
 
-void
-menu_get_size(struct menu *menu, enum box_lines lines, u_int *sx, u_int *sy)
-{
-	if (lines == BOX_LINES_NONE) {
-		*sx = menu->item_width + 2;
-		*sy = menu->count;
-	} else {
-		*sx = menu->width + 4;
-		*sy = menu->count + 2;
-	}
-}
-
 void
 menu_add_items(struct menu *menu, const struct menu_item *items,
     struct cmdq_item *qitem, struct client *c, struct cmd_find_state *fs)
@@ -154,8 +142,6 @@ menu_add_item(struct menu *menu, const struct menu_item *item,
 	width = format_width(new_item->name);
 	if (*new_item->name == '-')
 		width--;
-	if (width > menu->item_width)
-		menu->item_width = width;
 	if (width > menu->width)
 		menu->width = width;
 }
@@ -252,7 +238,7 @@ menu_update(struct menu_data *md)
 	screen_write_clearscreen(&ctx, 8);
 
 	if (md->border_lines != BOX_LINES_NONE) {
-		screen_write_box(&ctx, menu_width(md), menu_height(md),
+		screen_write_box(&ctx, menu->width + 4, menu->count + 2,
 		    md->border_lines, &md->border_style_gc, menu->title);
 	}
 
@@ -300,13 +286,11 @@ menu_destroy(struct window *w)
 void
 menu_get_cursor(struct menu_data *md, u_int *cx, u_int *cy)
 {
-	u_int	border = (md->border_lines != BOX_LINES_NONE);
-
-	*cx = md->px + 1 + border;
+	*cx = md->px + 2;
 	if (md->choice == -1)
 		*cy = md->py;
 	else
-		*cy = md->py + border + md->choice;
+		*cy = md->py + 1 + md->choice;
 }
 
 struct screen *
@@ -318,19 +302,13 @@ menu_screen(struct menu_data *md)
 u_int
 menu_width(struct menu_data *md)
 {
-	u_int	sx, sy;
-
-	menu_get_size(md->menu, md->border_lines, &sx, &sy);
-	return (sx);
+	return (md->menu->width + 4);
 }
 
 u_int
 menu_height(struct menu_data *md)
 {
-	u_int	sx, sy;
-
-	menu_get_size(md->menu, md->border_lines, &sx, &sy);
-	return (sy);
+	return (md->menu->count + 2);
 }
 
 u_int
@@ -360,7 +338,6 @@ menu_key(struct client *c, struct menu_data *md, struct key_event *event)
 	enum cmd_parse_status		 status;
 	char				*error;
 	key_code			 key;
-	u_int				 border;
 
 	if (KEYC_IS_MOUSE(event->key)) {
 		/*
@@ -376,10 +353,10 @@ menu_key(struct client *c, struct menu_data *md, struct key_event *event)
 				return (1);
 			return (0);
 		}
-		border = (md->border_lines != BOX_LINES_NONE);
-		if (m->x < md->px || m->x >= md->px + menu_width(md) ||
-		    m->y < md->py + border ||
-		    m->y >= md->py + border + n) {
+		if (m->x < md->px ||
+		    m->x > md->px + 4 + menu->width ||
+		    m->y < md->py + 1 ||
+		    m->y > md->py + 1 + n - 1) {
 			if (~md->flags & MENU_STAYOPEN) {
 				if (!move && MOUSE_RELEASE(m->b))
 					return (1);
@@ -402,7 +379,7 @@ menu_key(struct client *c, struct menu_data *md, struct key_event *event)
 			if (!MOUSE_WHEEL(m->b) && !MOUSE_DRAG(m->b))
 				goto chosen;
 		}
-		md->choice = m->y - (md->py + border);
+		md->choice = m->y - (md->py + 1);
 		if (md->choice != old)
 			server_redraw_window_menu(md->w);
 		return (0);
@@ -569,16 +546,20 @@ menu_resize(struct menu_data *md, struct window *w)
 
 	if (md == NULL)
 		return;
+
 	nx = md->px;
 	ny = md->py;
 
-	menu_get_size(md->menu, md->border_lines, &sx, &sy);
+	sx = md->menu->width + 4;
+	sy = md->menu->count + 2;
+
 	if (nx + sx > w->sx) {
 		if (w->sx <= sx)
 			nx = 0;
 		else
 			nx = w->sx - sx;
 	}
+
 	if (ny + sy > w->sy) {
 		if (w->sy <= sy)
 			ny = 0;
@@ -610,9 +591,8 @@ menu_display(struct menu *menu, int flags, int starting_choice,
 		w = fs->w;
 	o = w->options;
 
-	if (lines == BOX_LINES_DEFAULT)
-		lines = options_get_number(o, "menu-border-lines");
-	menu_get_size(menu, lines, &sx, &sy);
+	sx = menu->width + 4;
+	sy = menu->count + 2;
 	if (sx >= w->sx)
 		px = 0;
 	else if (px + sx > w->sx)
@@ -624,6 +604,9 @@ menu_display(struct menu *menu, int flags, int starting_choice,
 	w->menu_last_px = px;
 	w->menu_last_py = py;
 
+	if (lines == BOX_LINES_DEFAULT)
+		lines = options_get_number(o, "menu-border-lines");
+
 	md = xcalloc(1, sizeof *md);
 	md->w = w;
 	md->flags = flags;

mode-tree.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: mode-tree.c,v 1.102 2026/09/21 12:14:32 nicm Exp $ */
+/* $OpenBSD: mode-tree.c,v 1.101 2026/08/05 07:50:21 nicm Exp $ */
 
 /*
  * Copyright (c) 2017 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -1375,14 +1375,12 @@ static void
 mode_tree_display_menu(struct mode_tree_data *mtd, struct client *c, u_int x,
     u_int y, int outside)
 {
-	struct window		*w = mtd->wp->window;
 	struct mode_tree_item	*mti;
 	struct menu		*menu;
 	const struct menu_item	*items;
 	struct mode_tree_menu	*mtm;
 	char			*title;
-	enum box_lines		 lines;
-	u_int			 line, sx, sy;
+	u_int			 line;
 
 	if (mtd->offset + y > mtd->line_size - 1)
 		line = mtd->current;
@@ -1407,17 +1405,14 @@ mode_tree_display_menu(struct mode_tree_data *mtd, struct client *c, u_int x,
 	mtm->line = line;
 	mtd->references++;
 
-	lines = options_get_number(w->options, "menu-border-lines");
-	menu_get_size(menu, lines, &sx, &sy);
-	if (x >= sx / 2)
-		x -= sx / 2;
+	if (x >= (menu->width + 4) / 2)
+		x -= (menu->width + 4) / 2;
 	else
 		x = 0;
 	x += mtd->wp->xoff;
 	y += mtd->wp->yoff;
-
-	if (menu_display(menu, 0, 0, NULL, x, y, c, lines, NULL, NULL, NULL,
-	    NULL, mode_tree_menu_callback, mtm) != 0) {
+	if (menu_display(menu, 0, 0, NULL, x, y, c, BOX_LINES_DEFAULT, NULL,
+	    NULL, NULL, NULL, mode_tree_menu_callback, mtm) != 0) {
 		mode_tree_remove_ref(mtd);
 		free(mtm);
 		menu_free(menu);

options-table.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: options-table.c,v 1.247 2026/09/21 10:22:31 nicm Exp $ */
+/* $OpenBSD: options-table.c,v 1.245 2026/09/10 11:02:18 nicm Exp $ */
 
 /*
  * Copyright (c) 2011 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -76,10 +76,9 @@ static const char *options_table_pane_border_indicators_list[] = {
 	"off", "colour", "arrows", "both", NULL
 };
 static const char *options_table_pane_border_lines_list[] = {
-	"single", "double", "heavy", "simple", "number", "spaces", "none",
-	"rounded", NULL
+	"single", "double", "heavy", "simple", "number", "spaces", "none", NULL
 };
-static const char *options_table_menu_border_lines_list[] = {
+static const char *options_table_popup_border_lines_list[] = {
 	"single", "double", "heavy", "simple", "rounded", "padded", "none", NULL
 };
 static const char *options_table_set_clipboard_list[] = {
@@ -493,7 +492,7 @@ const struct options_table_entry options_table[] = {
 	{ .name = "menu-border-lines",
 	  .type = OPTIONS_TABLE_CHOICE,
 	  .scope = OPTIONS_TABLE_WINDOW,
-	  .choices = options_table_menu_border_lines_list,
+	  .choices = options_table_popup_border_lines_list,
 	  .default_num = BOX_LINES_SINGLE,
 	  .text = "Type of characters used to draw menu border lines. Some of "
 		  "these are only supported on terminals with UTF-8 support."
@@ -1666,6 +1665,33 @@ const struct options_table_entry options_table[] = {
 	  .text = "Pane scrollbar position."
 	},
 
+	{ .name = "popup-style",
+	  .type = OPTIONS_TABLE_STRING,
+	  .scope = OPTIONS_TABLE_WINDOW,
+	  .default_str = "bg=themedarkgrey,fg=themewhite",
+	  .flags = OPTIONS_TABLE_IS_STYLE,
+	  .separator = ",",
+	  .text = "Default style of popups."
+	},
+
+	{ .name = "popup-border-style",
+	  .type = OPTIONS_TABLE_STRING,
+	  .scope = OPTIONS_TABLE_WINDOW,
+	  .default_str = "bg=themedarkgrey,fg=themelightgrey",
+	  .flags = OPTIONS_TABLE_IS_STYLE,
+	  .separator = ",",
+	  .text = "Default style of popup borders."
+	},
+
+	{ .name = "popup-border-lines",
+	  .type = OPTIONS_TABLE_CHOICE,
+	  .scope = OPTIONS_TABLE_WINDOW,
+	  .choices = options_table_popup_border_lines_list,
+	  .default_num = BOX_LINES_SINGLE,
+	  .text = "Type of characters used to draw popup border lines. Some of "
+		  "these are only supported on terminals with UTF-8 support."
+	},
+
 	{ .name = "remain-on-exit",
 	  .type = OPTIONS_TABLE_CHOICE,
 	  .scope = OPTIONS_TABLE_WINDOW|OPTIONS_TABLE_PANE,

popup.c

@@ -0,0 +1,661 @@
+/* $OpenBSD: popup.c,v 1.77 2026/08/28 08:02:16 nicm Exp $ */
+
+/*
+ * Copyright (c) 2020 Nicholas Marriott <nicholas.marriott@gmail.com>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF MIND, USE, DATA OR PROFITS, WHETHER
+ * IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
+ * OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include <sys/types.h>
+#include <sys/wait.h>
+
+#include <signal.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "tmux.h"
+
+struct popup_data {
+	struct client		 *c;
+	struct cmdq_item	 *item;
+	int			  flags;
+	char			 *title;
+
+	char			 *style;
+	char			 *border_style;
+	struct grid_cell	  border_cell;
+	enum box_lines		  border_lines;
+
+	struct screen		  s;
+	struct grid_cell	  defaults;
+	struct colour_palette	  palette;
+
+	struct visible_ranges	  r;
+
+	struct job		 *job;
+	struct input_ctx	 *ictx;
+	int			  status;
+	popup_close_cb		  cb;
+	void			 *arg;
+
+	int			  close;
+
+	/* Current position and size. */
+	u_int			  px;
+	u_int			  py;
+	u_int			  sx;
+	u_int			  sy;
+
+	/* Preferred position and size. */
+	u_int			  ppx;
+	u_int			  ppy;
+	u_int			  psx;
+	u_int			  psy;
+
+	enum { OFF, MOVE, SIZE }  dragging;
+	u_int			  dx;
+	u_int			  dy;
+
+	u_int			  lx;
+	u_int			  ly;
+	u_int			  lb;
+};
+
+static void
+popup_free(struct popup_data *pd)
+{
+	server_client_unref(pd->c);
+
+	if (pd->job != NULL)
+		job_free(pd->job);
+	if (pd->ictx != NULL)
+		input_free(pd->ictx);
+
+	free(pd->r.ranges);
+	screen_free(&pd->s);
+	colour_palette_free(&pd->palette);
+
+	free(pd->title);
+	free(pd->style);
+	free(pd->border_style);
+	free(pd);
+}
+
+static void
+popup_reapply_styles(struct popup_data *pd)
+{
+	struct client		*c = pd->c;
+	struct session		*s = c->session;
+	struct options		*o;
+	struct format_tree	*ft;
+	struct style		 sytmp;
+
+	if (s == NULL)
+		return;
+	o = s->curw->window->options;
+
+	ft = format_create_defaults(NULL, c, s, s->curw, NULL);
+
+	/* Reapply popup style from options. */
+	memcpy(&pd->defaults, &grid_default_cell, sizeof pd->defaults);
+	style_apply(&pd->defaults, o, "popup-style", ft);
+	if (pd->style != NULL) {
+		style_set(&sytmp, &grid_default_cell);
+		if (style_parse(&sytmp, &pd->defaults, pd->style) == 0) {
+			pd->defaults.fg = sytmp.gc.fg;
+			pd->defaults.bg = sytmp.gc.bg;
+		}
+	}
+	pd->defaults.attr = 0;
+
+	/* Reapply border style from options. */
+	memcpy(&pd->border_cell, &grid_default_cell, sizeof pd->border_cell);
+	style_apply(&pd->border_cell, o, "popup-border-style", ft);
+	if (pd->border_style != NULL) {
+		style_set(&sytmp, &grid_default_cell);
+		if (style_parse(&sytmp, &pd->border_cell,
+		    pd->border_style) == 0) {
+			pd->border_cell.fg = sytmp.gc.fg;
+			pd->border_cell.bg = sytmp.gc.bg;
+		}
+	}
+	pd->border_cell.attr = 0;
+
+	format_free(ft);
+}
+
+static void
+popup_redraw_cb(const struct tty_ctx *ttyctx)
+{
+	struct popup_data	*pd = ttyctx->arg;
+
+	pd->c->flags |= CLIENT_REDRAWOVERLAY;
+}
+
+static int
+popup_set_client_cb(struct tty_ctx *ttyctx, struct client *c)
+{
+	struct popup_data	*pd = ttyctx->arg;
+
+	if (c != pd->c)
+		return (0);
+	if (pd->c->flags & CLIENT_REDRAWOVERLAY)
+		return (0);
+
+	ttyctx->wox = 0;
+	ttyctx->woy = 0;
+	ttyctx->wsx = c->tty.sx;
+	ttyctx->wsy = c->tty.sy;
+
+	if (pd->border_lines == BOX_LINES_NONE) {
+		ttyctx->xoff = ttyctx->rxoff = pd->px;
+		ttyctx->yoff = ttyctx->ryoff = pd->py;
+	} else {
+		ttyctx->xoff = ttyctx->rxoff = pd->px + 1;
+		ttyctx->yoff = ttyctx->ryoff = pd->py + 1;
+	}
+
+	return (1);
+}
+
+static void
+popup_init_ctx_cb(struct screen_write_ctx *ctx, struct tty_ctx *ttyctx)
+{
+	struct popup_data	*pd = ctx->arg;
+
+	memcpy(&ttyctx->defaults, &pd->defaults, sizeof ttyctx->defaults);
+	ttyctx->flags &= ~TTY_CTX_WINDOW_BIGGER;
+	ttyctx->style_ctx.defaults = &ttyctx->defaults;
+	ttyctx->style_ctx.palette = &pd->palette;
+	ttyctx->redraw_cb = popup_redraw_cb;
+	ttyctx->set_client_cb = popup_set_client_cb;
+	ttyctx->arg = pd;
+}
+
+static struct screen *
+popup_mode_cb(__unused struct client *c, void *data, u_int *cx, u_int *cy)
+{
+	struct popup_data	*pd = data;
+
+	if (pd->border_lines == BOX_LINES_NONE) {
+		*cx = pd->px + pd->s.cx;
+		*cy = pd->py + pd->s.cy;
+	} else {
+		*cx = pd->px + 1 + pd->s.cx;
+		*cy = pd->py + 1 + pd->s.cy;
+	}
+	return (&pd->s);
+}
+
+/* Return parts of the input range which are not obstructed by the popup. */
+static struct visible_ranges *
+popup_check_cb(__unused struct client* c, void *data, u_int px, u_int py,
+    u_int nx)
+{
+	struct popup_data	*pd = data;
+	struct visible_ranges	*r = &pd->r;
+
+	server_client_overlay_range(pd->px, pd->py, pd->sx, pd->sy, px, py, nx,
+	    r);
+	return (r);
+}
+
+static void
+popup_draw_cb(struct client *c, void *data)
+{
+	struct popup_data	*pd = data;
+	struct tty		*tty = &c->tty;
+	struct screen		 s;
+	struct screen_write_ctx	 ctx;
+	u_int			 i, px = pd->px, py = pd->py;
+	struct grid_cell	 defaults;
+	struct tty_style_ctx	 style_ctx;
+
+	popup_reapply_styles(pd);
+
+	screen_init(&s, pd->sx, pd->sy, 0);
+	if (pd->s.hyperlinks != NULL) {
+		hyperlinks_free(s.hyperlinks);
+		s.hyperlinks = hyperlinks_copy(pd->s.hyperlinks);
+	}
+	screen_write_start(&ctx, &s);
+	screen_write_clearscreen(&ctx, 8);
+
+	if (pd->border_lines == BOX_LINES_NONE) {
+		screen_write_cursormove(&ctx, 0, 0, 0);
+		screen_write_fast_copy(&ctx, &pd->s, 0, 0, pd->sx, pd->sy);
+	} else if (pd->sx > 2 && pd->sy > 2) {
+		screen_write_box(&ctx, pd->sx, pd->sy, pd->border_lines,
+		    &pd->border_cell, pd->title);
+		screen_write_cursormove(&ctx, 1, 1, 0);
+		screen_write_fast_copy(&ctx, &pd->s, 0, 0, pd->sx - 2,
+		    pd->sy - 2);
+	}
+	screen_write_stop(&ctx);
+
+	memcpy(&defaults, &pd->defaults, sizeof defaults);
+	if (defaults.fg == 8)
+		defaults.fg = pd->palette.fg;
+	if (defaults.bg == 8)
+		defaults.bg = pd->palette.bg;
+	style_ctx.defaults = &defaults;
+	style_ctx.palette = &pd->palette;
+	style_ctx.dim = 0;
+	style_ctx.hyperlinks = s.hyperlinks;
+
+	c->overlay_check = NULL;
+	c->overlay_data = NULL;
+	for (i = 0; i < pd->sy; i++)
+		tty_draw_line(tty, &s, 0, i, pd->sx, px, py + i, &style_ctx);
+	screen_free(&s);
+	c->overlay_check = popup_check_cb;
+	c->overlay_data = pd;
+}
+
+static void
+popup_free_cb(__unused struct client *c, void *data)
+{
+	struct popup_data	*pd = data;
+	struct cmdq_item	*item = pd->item;
+
+	if (pd->cb != NULL)
+		pd->cb(pd->status, pd->arg);
+
+	if (item != NULL) {
+		if (cmdq_get_client(item) != NULL &&
+		    cmdq_get_client(item)->session == NULL)
+			cmdq_get_client(item)->retval = pd->status;
+		cmdq_continue(item);
+	}
+
+	popup_free(pd);
+}
+
+static void
+popup_resize_cb(__unused struct client *c, void *data)
+{
+	struct popup_data	*pd = data;
+	struct tty		*tty = &c->tty;
+
+	if (pd == NULL)
+		return;
+
+	/* Adjust position and size. */
+	if (pd->psy > tty->sy)
+		pd->sy = tty->sy;
+	else
+		pd->sy = pd->psy;
+	if (pd->psx > tty->sx)
+		pd->sx = tty->sx;
+	else
+		pd->sx = pd->psx;
+	if (pd->ppy + pd->sy > tty->sy)
+		pd->py = tty->sy - pd->sy;
+	else
+		pd->py = pd->ppy;
+	if (pd->ppx + pd->sx > tty->sx)
+		pd->px = tty->sx - pd->sx;
+	else
+		pd->px = pd->ppx;
+
+	/* Avoid zero size screens. */
+	if (pd->border_lines == BOX_LINES_NONE) {
+		screen_resize(&pd->s, pd->sx, pd->sy, 0);
+		if (pd->job != NULL)
+			job_resize(pd->job, pd->sx, pd->sy );
+	} else if (pd->sx > 2 && pd->sy > 2) {
+		screen_resize(&pd->s, pd->sx - 2, pd->sy - 2, 0);
+		if (pd->job != NULL)
+			job_resize(pd->job, pd->sx - 2, pd->sy - 2);
+	}
+}
+
+static void
+popup_handle_drag(struct client *c, struct popup_data *pd,
+    struct mouse_event *m)
+{
+	u_int	px, py;
+
+	if (!MOUSE_DRAG(m->b))
+		pd->dragging = OFF;
+	else if (pd->dragging == MOVE) {
+		if (m->x < pd->dx)
+			px = 0;
+		else if (m->x - pd->dx + pd->sx > c->tty.sx)
+			px = c->tty.sx - pd->sx;
+		else
+			px = m->x - pd->dx;
+		if (m->y < pd->dy)
+			py = 0;
+		else if (m->y - pd->dy + pd->sy > c->tty.sy)
+			py = c->tty.sy - pd->sy;
+		else
+			py = m->y - pd->dy;
+		pd->px = px;
+		pd->py = py;
+		pd->dx = m->x - pd->px;
+		pd->dy = m->y - pd->py;
+		pd->ppx = px;
+		pd->ppy = py;
+		server_redraw_client(c);
+	} else if (pd->dragging == SIZE) {
+		if (pd->border_lines == BOX_LINES_NONE) {
+			if (m->x < pd->px + 1)
+				return;
+			if (m->y < pd->py + 1)
+				return;
+		} else {
+			if (m->x < pd->px + 3)
+				return;
+			if (m->y < pd->py + 3)
+				return;
+		}
+		pd->sx = m->x - pd->px;
+		pd->sy = m->y - pd->py;
+		pd->psx = pd->sx;
+		pd->psy = pd->sy;
+
+		if (pd->border_lines == BOX_LINES_NONE) {
+			screen_resize(&pd->s, pd->sx, pd->sy, 0);
+			if (pd->job != NULL)
+				job_resize(pd->job, pd->sx, pd->sy);
+		} else {
+			screen_resize(&pd->s, pd->sx - 2, pd->sy - 2, 0);
+			if (pd->job != NULL)
+				job_resize(pd->job, pd->sx - 2, pd->sy - 2);
+		}
+		server_redraw_client(c);
+	}
+}
+
+static int
+popup_key_cb(struct client *c, void *data, struct key_event *event)
+{
+	struct popup_data	*pd = data;
+	struct mouse_event	*m = &event->m;
+	const char		*buf;
+	size_t			 len;
+	u_int			 px, py;
+	enum { NONE, LEFT, RIGHT, TOP, BOTTOM } border = NONE;
+
+	if (KEYC_IS_MOUSE(event->key)) {
+		if (pd->dragging != OFF) {
+			popup_handle_drag(c, pd, m);
+			goto out;
+		}
+		if (m->x < pd->px ||
+		    m->x > pd->px + pd->sx - 1 ||
+		    m->y < pd->py ||
+		    m->y > pd->py + pd->sy - 1) {
+			return (0);
+		}
+		if (pd->border_lines != BOX_LINES_NONE) {
+			if (m->x == pd->px)
+				border = LEFT;
+			else if (m->x == pd->px + pd->sx - 1)
+				border = RIGHT;
+			else if (m->y == pd->py)
+				border = TOP;
+			else if (m->y == pd->py + pd->sy - 1)
+				border = BOTTOM;
+		}
+		if ((m->b & MOUSE_MASK_MODIFIERS) == 0 &&
+		    MOUSE_BUTTONS(m->b) == MOUSE_BUTTON_3 &&
+		    (border == LEFT || border == TOP))
+			goto out;
+		if (((m->b & MOUSE_MASK_MODIFIERS) == MOUSE_MASK_META) ||
+		    (border != NONE && !MOUSE_DRAG(m->lb))) {
+			if (!MOUSE_DRAG(m->b))
+				goto out;
+			if (MOUSE_BUTTONS(m->lb) == MOUSE_BUTTON_1)
+				pd->dragging = MOVE;
+			else if (MOUSE_BUTTONS(m->lb) == MOUSE_BUTTON_3)
+				pd->dragging = SIZE;
+			pd->dx = m->lx - pd->px;
+			pd->dy = m->ly - pd->py;
+			goto out;
+		}
+	}
+	if ((((pd->flags & (POPUP_CLOSEEXIT|POPUP_CLOSEEXITZERO)) == 0) ||
+	    pd->job == NULL) &&
+	    (event->key == '\033' || event->key == ('c'|KEYC_CTRL)))
+		return (1);
+	if (pd->job == NULL && (pd->flags & POPUP_CLOSEANYKEY) &&
+	    !KEYC_IS_MOUSE(event->key) && !KEYC_IS_PASTE(event->key))
+		return (1);
+	if (pd->job != NULL) {
+		if (KEYC_IS_MOUSE(event->key)) {
+			/* Must be inside, checked already. */
+			if (pd->border_lines == BOX_LINES_NONE) {
+				px = m->x - pd->px;
+				py = m->y - pd->py;
+			} else {
+				px = m->x - pd->px - 1;
+				py = m->y - pd->py - 1;
+			}
+			if (!input_key_get_mouse(&pd->s, m, px, py, &buf, &len))
+				return (0);
+			bufferevent_write(job_get_event(pd->job), buf, len);
+			return (0);
+		}
+		input_key(&pd->s, job_get_event(pd->job), event->key);
+	}
+	return (0);
+
+out:
+	pd->lx = m->x;
+	pd->ly = m->y;
+	pd->lb = m->b;
+	return (0);
+}
+
+static void
+popup_job_update_cb(struct job *job)
+{
+	struct popup_data	*pd = job_get_data(job);
+	struct evbuffer		*evb = job_get_event(job)->input;
+	struct client		*c = pd->c;
+	struct screen		*s = &pd->s;
+	void			*data = EVBUFFER_DATA(evb);
+	size_t			 size = EVBUFFER_LENGTH(evb);
+
+	if (size == 0)
+		return;
+
+	c->overlay_check = NULL;
+	c->overlay_data = NULL;
+	input_parse_screen(pd->ictx, s, popup_init_ctx_cb, pd, data, size);
+	c->overlay_check = popup_check_cb;
+	c->overlay_data = pd;
+
+	evbuffer_drain(evb, size);
+}
+
+static void
+popup_job_complete_cb(struct job *job)
+{
+	struct popup_data	*pd = job_get_data(job);
+	int			 status;
+
+	status = job_get_status(pd->job);
+	if (WIFEXITED(status))
+		pd->status = WEXITSTATUS(status);
+	else if (WIFSIGNALED(status))
+		pd->status = WTERMSIG(status);
+	else
+		pd->status = 0;
+	pd->job = NULL;
+
+	if ((pd->flags & POPUP_CLOSEEXIT) ||
+	    ((pd->flags & POPUP_CLOSEEXITZERO) && pd->status == 0))
+		server_client_clear_overlay(pd->c);
+}
+
+int
+popup_present(struct client *c)
+{
+	return (c->overlay_draw == popup_draw_cb);
+}
+
+int
+popup_modify(struct client *c, const char *title, const char *style,
+	const char *border_style, enum box_lines lines, int flags)
+{
+	struct popup_data		*pd = c->overlay_data;
+	struct style		sytmp;
+
+	if (title != NULL) {
+		if (pd->title != NULL)
+			free(pd->title);
+		pd->title = xstrdup(title);
+	}
+	if (border_style != NULL) {
+		free(pd->border_style);
+		pd->border_style = xstrdup(border_style);
+		style_set(&sytmp, &pd->border_cell);
+		if (style_parse(&sytmp, &pd->border_cell, border_style) == 0) {
+			pd->border_cell.fg = sytmp.gc.fg;
+			pd->border_cell.bg = sytmp.gc.bg;
+		}
+	}
+	if (style != NULL) {
+		free(pd->style);
+		pd->style = xstrdup(style);
+		style_set(&sytmp, &pd->defaults);
+		if (style_parse(&sytmp, &pd->defaults, style) == 0) {
+			pd->defaults.fg = sytmp.gc.fg;
+			pd->defaults.bg = sytmp.gc.bg;
+		}
+	}
+	if (lines != BOX_LINES_DEFAULT) {
+		if (lines == BOX_LINES_NONE && pd->border_lines != lines) {
+			screen_resize(&pd->s, pd->sx, pd->sy, 1);
+			job_resize(pd->job, pd->sx, pd->sy);
+		} else if (pd->border_lines == BOX_LINES_NONE &&
+		    pd->border_lines != lines) {
+			screen_resize(&pd->s, pd->sx - 2, pd->sy - 2, 1);
+			job_resize(pd->job, pd->sx - 2, pd->sy - 2);
+		}
+		pd->border_lines = lines;
+		tty_resize(&c->tty);
+	}
+	if (flags != -1)
+		pd->flags = flags;
+
+	server_redraw_client(c);
+	return (0);
+}
+
+int
+popup_display(int flags, enum box_lines lines, struct cmdq_item *item, u_int px,
+    u_int py, u_int sx, u_int sy, struct environ *env, const char *shellcmd,
+    int argc, char **argv, const char *cwd, const char *title, struct client *c,
+    struct session *s, const char *style, const char *border_style,
+    popup_close_cb cb, void *arg)
+{
+	struct popup_data	*pd;
+	u_int			 jx, jy;
+	struct options		*o;
+	struct style		 sytmp;
+
+	if (s != NULL)
+		o = s->curw->window->options;
+	else
+		o = c->session->curw->window->options;
+
+	if (lines == BOX_LINES_DEFAULT)
+		lines = options_get_number(o, "popup-border-lines");
+	if (lines == BOX_LINES_NONE) {
+		if (sx < 1 || sy < 1)
+			return (-1);
+		jx = sx;
+		jy = sy;
+	} else {
+		if (sx < 3 || sy < 3)
+			return (-1);
+		jx = sx - 2;
+		jy = sy - 2;
+	}
+	if (c->tty.sx < sx || c->tty.sy < sy)
+		return (-1);
+
+	pd = xcalloc(1, sizeof *pd);
+	pd->item = item;
+	pd->flags = flags;
+
+	if (title != NULL)
+		pd->title = xstrdup(title);
+	if (style != NULL)
+		pd->style = xstrdup(style);
+	if (border_style != NULL)
+		pd->border_style = xstrdup(border_style);
+
+	pd->c = c;
+	pd->c->references++;
+
+	pd->cb = cb;
+	pd->arg = arg;
+	pd->status = 128 + SIGHUP;
+
+	pd->border_lines = lines;
+	memcpy(&pd->border_cell, &grid_default_cell, sizeof pd->border_cell);
+	style_apply(&pd->border_cell, o, "popup-border-style", NULL);
+	if (border_style != NULL) {
+		style_set(&sytmp, &grid_default_cell);
+		if (style_parse(&sytmp, &pd->border_cell, border_style) == 0) {
+			pd->border_cell.fg = sytmp.gc.fg;
+			pd->border_cell.bg = sytmp.gc.bg;
+		}
+	}
+	pd->border_cell.attr = 0;
+
+	screen_init(&pd->s, jx, jy, 0);
+	screen_set_default_cursor(&pd->s, global_w_options);
+	colour_palette_init(&pd->palette);
+	colour_palette_from_option(&pd->palette, global_w_options);
+
+	memcpy(&pd->defaults, &grid_default_cell, sizeof pd->defaults);
+	style_apply(&pd->defaults, o, "popup-style", NULL);
+	if (style != NULL) {
+		style_set(&sytmp, &grid_default_cell);
+		if (style_parse(&sytmp, &pd->defaults, style) == 0) {
+			pd->defaults.fg = sytmp.gc.fg;
+			pd->defaults.bg = sytmp.gc.bg;
+		}
+	}
+	pd->defaults.attr = 0;
+
+	pd->px = px;
+	pd->py = py;
+	pd->sx = sx;
+	pd->sy = sy;
+
+	pd->ppx = px;
+	pd->ppy = py;
+	pd->psx = sx;
+	pd->psy = sy;
+
+	pd->job = job_run(shellcmd, argc, argv, env, s, cwd,
+	    popup_job_update_cb, popup_job_complete_cb, NULL, pd,
+	    JOB_NOWAIT|JOB_PTY|JOB_KEEPWRITE|JOB_DEFAULTSHELL, jx, jy);
+	if (pd->job == NULL) {
+		popup_free(pd);
+		return (-1);
+	}
+	pd->ictx = input_init(NULL, job_get_event(pd->job), &pd->palette, c);
+
+	server_client_set_overlay(c, 0, popup_check_cb, popup_mode_cb,
+	    popup_draw_cb, popup_key_cb, popup_free_cb, popup_resize_cb, pd);
+	return (0);
+}

regress/attach-session-redraw.sh

@@ -1,79 +0,0 @@
-#!/bin/sh
-
-# Selecting a pane with attach-session from an already attached client must
-# redraw pane contents when window-style and window-active-style differ.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lattach-redraw-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lattach-redraw-outer-$$ -f/dev/null"
-BEFORE=$DIR/before
-AFTER=$DIR/after
-
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-LEFT=$($INNER new-session -dPF '#{pane_id}' -s inner -x 40 -y 8 \
-    "printf 'LEFT'; exec sleep 100") || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g default-terminal screen || exit 1
-$INNER split-window -h -t "$LEFT" "printf 'RIGHT'; exec sleep 100" || exit 1
-$INNER set-option -w -t "$LEFT" window-style bg=red || exit 1
-$INNER set-option -w -t "$LEFT" window-active-style bg=blue || exit 1
-$INNER bind-key -n x attach-session -t "$LEFT" || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 8 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lattach-redraw-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_client
-sleep 1
-$OUTER send-keys -t outer:0.0 x || exit 1
-sleep 1
-[ "$($INNER display-message -p -t inner '#{pane_id}')" = "$LEFT" ] ||
-    fail "attach-session did not select the target pane"
-$OUTER capture-pane -pe -t outer:0.0 >"$BEFORE" || exit 1
-
-# A forced redraw produces the correct scene. It must be identical to the
-# scene drawn immediately by attach-session.
-$INNER refresh-client -t "$CLIENT" || exit 1
-sleep 1
-$OUTER capture-pane -pe -t outer:0.0 >"$AFTER" || exit 1
-cmp -s "$BEFORE" "$AFTER" ||
-    fail "attach-session left stale active/inactive pane styles"
-
-exit 0

regress/check-names.sh

@@ -5,15 +5,6 @@
 PATH=/bin:/usr/bin
 TERM=screen
 
-# The pane's shell must not be the user's own interactive shell: a custom
-# PS1/PROMPT_COMMAND that sets the terminal title (as many do, for tmux/xterm
-# TERM types) would redraw over the titles this test sets and checks on
-# every prompt, regardless of how long it waits first.
-shell=
-if command -v bash >/dev/null 2>&1; then
-	shell='bash --noprofile --norc +o history'
-fi
-
 [ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
 TMUX="$TEST_TMUX -LtestA$$ -f/dev/null"
 $TMUX kill-server 2>/dev/null
@@ -39,7 +30,7 @@ must_equal()
 	[ "$got" = "$want" ] || fail "got '$got', expected '$want'"
 }
 
-$TMUX new-session -d -x 80 -y 24 -- $shell || exit 1
+$TMUX new-session -d -x 80 -y 24 || exit 1
 $TMUX set-option -qg allow-set-title on || exit 1
 $TMUX set-option -qg allow-rename on || exit 1
 $TMUX set-option -qg automatic-rename off || exit 1

regress/control-client-popup.sh

@@ -1,7 +1,6 @@
 #!/bin/sh
 
-# Popups require an attached terminal and cannot be displayed by a control
-# client.
+# Popups require a tty overlay and cannot be displayed by a control client.
 # A popup command from control mode must be ignored cleanly, leaving the
 # client command queue and server usable.
 

regress/copy-mode-source-blank.sh

@@ -1,63 +0,0 @@
-#!/bin/sh
-
-# Trimming a blank source must leave a visible line for cursor reflow.
-
-PATH=/bin:/usr/bin
-TERM=screen
-export PATH TERM
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-TMUX="$TEST_TMUX -LtestA$$ -f/dev/null"
-
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$TMUX kill-server 2>/dev/null
-}
-trap cleanup 0
-trap 'exit 1' 1 2 3 15
-
-$TMUX new-session -d -x80 -y24 -s test 'sleep 100' || exit 1
-$TMUX set-option -g window-size manual || exit 1
-$TMUX new-window -t test:1 'sleep 100' || exit 1
-$TMUX resize-window -t test:0 -x20 -y24 || exit 1
-
-# Exercise widening, narrowing, and equal widths with no source history.
-for pair in '0 1' '1 0' '1 2'; do
-	set -- $pair
-	if [ "$2" = 2 ]; then
-		$TMUX new-window -t test:2 'sleep 100' || exit 1
-		$TMUX resize-window -t test:2 -x80 -y24 || exit 1
-	fi
-	source=test:$1.0
-	target=test:$2.0
-	[ "$($TMUX display-message -p -t "$source" '#{history_size}')" = 0 ] ||
-		fail "source has unexpected history"
-	$TMUX copy-mode -s "$source" -t "$target" || exit 1
-	$TMUX has-session -t test || fail "server died copying blank source"
-	[ "$($TMUX display-message -p -t "$target" \
-	    '#{pane_in_mode} #{copy_cursor_x} #{copy_cursor_y}')" = '1 0 0' ] ||
-		fail "blank source did not enter copy mode at the first cell"
-	$TMUX send-keys -t "$target" -X cancel || exit 1
-done
-
-# Real content still trims trailing empty lines, clamping the cursor to beta.
-$TMUX respawn-pane -k -t test:0.0 \
-	"printf 'alpha\r\nbeta\r\n\r\n\r\n'; exec sleep 100" || exit 1
-i=0
-while [ "$($TMUX display-message -p -t test:0.0 '#{cursor_y}')" != 4 ]; do
-	i=$((i + 1))
-	[ "$i" -lt 10 ] || fail "source output did not arrive"
-	sleep 1
-done
-$TMUX copy-mode -s test:0.0 -t test:1.0 || exit 1
-[ "$($TMUX display-message -p -t test:1.0 \
-    '#{pane_in_mode} #{copy_cursor_y} #{copy_cursor_line}')" = '1 1 beta' ] ||
-	fail "nonblank source content or trailing-line trimming changed"
-
-exit 0

regress/floating-pane-border-style-cross-client.sh

@@ -1,135 +0,0 @@
-#!/bin/sh
-
-# Damage-only redraws must evaluate both active and inactive border styles
-# for each client, even though the cached border cells belong to the pane.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lborder-style-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lborder-style-outer-$$ -f/dev/null"
-CAPTURE=$DIR/capture
-
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_clients()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		count=$($INNER list-clients 2>/dev/null | wc -l)
-		[ "$count" -eq 2 ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "two inner clients did not attach"
-}
-
-wait_for_marker()
-{
-	target=$1
-	marker=$2
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t "$target" >"$CAPTURE" || exit 1
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "client in $target did not receive $marker"
-}
-
-cat >"$DIR/emitter.pl" <<'PERL'
-use strict;
-use warnings;
-
-$| = 1;
-for my $phase (1 .. 2) {
-	while (!-e "$ENV{TRIGGER}-$phase") {
-		select undef, undef, undef, 0.01;
-	}
-	# Change an unused palette entry and acknowledge it in the pane body.
-	print "\e]4;200;rgb:11/22/0$phase\a\e[1;1HDAMAGE$phase";
-}
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 60 -y 20 \
-    "TRIGGER='$DIR/trigger' perl '$DIR/emitter.pl'" || exit 1
-$INNER set -g status off || exit 1
-$INNER set -g window-size manual || exit 1
-$INNER set -g automatic-rename off || exit 1
-$INNER set -g status-interval 0 || exit 1
-$INNER set -g pane-border-lines simple || exit 1
-$INNER set -g pane-border-status top || exit 1
-$INNER set -g pane-border-format 'CLIENT=#{client_name}' || exit 1
-FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 35 -y 6 -X 5 -Y 5 \
-    'sleep 100') || exit 1
-
-$OUTER new-session -d -s outer -x 121 -y 20 'sleep 100' || exit 1
-$OUTER set -g status off || exit 1
-$OUTER set -g window-size manual || exit 1
-$OUTER set -g default-terminal screen || exit 1
-LEFT=$($OUTER display-message -p -t outer:0.0 '#{pane_id}') || exit 1
-RIGHT=$($OUTER split-window -h -PF '#{pane_id}' 'sleep 100') || exit 1
-for target in "$LEFT" "$RIGHT"; do
-	$OUTER respawn-pane -k -t "$target" "$INNER attach-session -t inner" ||
-	    exit 1
-done
-wait_for_clients
-
-NAME1=$($OUTER display-message -p -t "$LEFT" '#{pane_tty}') || exit 1
-NAME2=$($OUTER display-message -p -t "$RIGHT" '#{pane_tty}') || exit 1
-STYLE="fg=#{?#{==:#{client_name},$NAME1},red,blue}"
-$INNER set -g pane-border-style "$STYLE" || exit 1
-$INNER set -g pane-active-border-style "$STYLE" || exit 1
-
-# Capture just the floating pane's rows, excluding the acknowledgement in
-# the tiled pane. Exercise each cache by changing the floating pane's focus.
-phase=1
-while [ "$phase" -le 2 ]; do
-	if [ "$phase" -eq 2 ]; then
-		$INNER select-pane -t "$FLOAT" || exit 1
-	fi
-	$INNER refresh-client -t "$NAME1" || exit 1
-	$INNER refresh-client -t "$NAME2" || exit 1
-	sleep 0.5
-	for target in "$LEFT" "$RIGHT"; do
-		$OUTER capture-pane -pe -S 5 -E 10 -t "$target" \
-		    >"$DIR/before-$target" || exit 1
-	done
-	RED=$(printf '\033[31m')
-	BLUE=$(printf '\033[34m')
-	grep -Fq "$RED" "$DIR/before-$LEFT" || fail "missing red border"
-	grep -Fq "$BLUE" "$DIR/before-$RIGHT" || fail "missing blue border"
-
-	: >"$DIR/trigger-$phase"
-	wait_for_marker "$LEFT" "DAMAGE$phase"
-	wait_for_marker "$RIGHT" "DAMAGE$phase"
-	sleep 0.2
-	for target in "$LEFT" "$RIGHT"; do
-		$OUTER capture-pane -pe -S 5 -E 10 -t "$target" \
-		    >"$CAPTURE" || exit 1
-		diff -u "$DIR/before-$target" "$CAPTURE" ||
-		    fail "phase $phase changed $target's border style"
-	done
-	phase=$((phase + 1))
-done
-
-exit 0

regress/floating-pane-drag-ghost.sh

@@ -1,108 +0,0 @@
-#!/bin/sh
-
-# Regression test for a floating-pane drag bug: cmd_resize_pane_redraw_floating()
-# (cmd-resize-pane.c) reported damage for just a dragged floating pane's
-# content rectangle, not the one-cell border frame drawn around it (see the
-# "floating" case in screen-redraw.c, which draws that frame at
-# xoff-1/yoff-1 through xoff+sx/yoff+sy - one cell outside the pane's own
-# content area). Damage scoped to only the content area left the frame's
-# previous position undrawn as the pane moved, so dragging it left a trail
-# of un-erased border frames behind - visible as several "corners" stacked
-# up rather than just the pane's current one.
-#
-# This bug has nothing to do with images - it reproduces with a plain
-# floating pane and no image support required.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-TMUX="$TEST_TMUX -LtestA$$ -f/dev/null"
-TMUX2="$TEST_TMUX -LtestB$$ -f/dev/null"
-
-cleanup()
-{
-	$TMUX kill-server >/dev/null 2>&1
-	$TMUX2 kill-server >/dev/null 2>&1
-}
-fail()
-{
-	echo "$*" >&2
-	cleanup
-	exit 1
-}
-
-# drag STARTCOL STARTROW ENDCOL ENDROW
-#
-# Write a plain (unmodified) SGR button-1 press, drag update and release at
-# 1-based positions to the outer pane holding the inner client - this
-# matches the default MouseDown1Border/MouseDrag1Border bindings used to
-# move or resize a floating pane by its border.
-drag()
-{
-	scol="$1"
-	srow="$2"
-	ecol="$3"
-	erow="$4"
-
-	seq=$(printf '\033[<0;%s;%sM' "$scol" "$srow")
-	$TMUX2 send-keys -t "$OUTER" -l "$seq" 2>/dev/null
-	sleep 0.2
-	seq=$(printf '\033[<32;%s;%sM' "$ecol" "$erow")
-	$TMUX2 send-keys -t "$OUTER" -l "$seq" 2>/dev/null
-	sleep 0.2
-	seq=$(printf '\033[<0;%s;%sm' "$ecol" "$erow")
-	$TMUX2 send-keys -t "$OUTER" -l "$seq" 2>/dev/null
-	sleep 1
-}
-
-cleanup
-
-TMP=$(mktemp)
-trap "cleanup; rm -f $TMP" 0 1 15
-
-$TMUX new-session -d -s inner -x 60 -y 20 'sh -c "sleep 100"' || exit 1
-$TMUX set -g mouse on
-$TMUX set -g default-command 'sh -c "sleep 100"'
-
-FLOAT=$($TMUX new-pane -d -PF '#{pane_id}' -x 16 -y 5 -X 5 -Y 5) ||
-	fail "new-pane -X -Y failed"
-FTOP=$($TMUX display-message -p -t "$FLOAT" '#{pane_top}')
-FLEFT=$($TMUX display-message -p -t "$FLOAT" '#{pane_left}')
-FWIDTH=$($TMUX display-message -p -t "$FLOAT" '#{pane_width}')
-
-$TMUX2 new-session -d -x 60 -y 20 "$TMUX attach -t inner" || exit 1
-sleep 1
-OUTER=$($TMUX2 list-panes -F '#{pane_id}' | head -1)
-[ -n "$OUTER" ] || fail "No outer pane."
-
-# Sanity check: exactly one floating pane, so exactly one top-left corner,
-# before dragging anything.
-$TMUX2 capturep -p -t "$OUTER" >$TMP || fail "capture failed"
-n=$(grep -o '┌' $TMP | wc -l)
-[ "$n" -eq 1 ] || fail "sanity: expected 1 corner before drag, found $n"
-
-# Drag the floating pane by its top border (row FTOP-1, some column within
-# its width) down several rows in a few separate steps, then release. A
-# single drag() call already does press/motion/release, so call it several
-# times in a row to simulate a multi-step real drag.
-GRABCOL=$((FLEFT + FWIDTH / 2))
-STARTROW=$FTOP
-i=0
-while [ $i -lt 6 ]; do
-	newrow=$((STARTROW + i + 1))
-	drag $((GRABCOL + 1)) $((STARTROW + i)) $((GRABCOL + 1)) $newrow
-	i=$((i + 1))
-done
-
-$TMUX2 capturep -p -t "$OUTER" >$TMP || fail "capture failed"
-
-# Exactly one top-left corner should remain - the pane's current position.
-# This is expected to fail before the fix: multiple corners (a trail of
-# un-erased frames) would remain from the intermediate drag positions.
-n=$(grep -o '┌' $TMP | wc -l)
-[ "$n" -eq 1 ] || fail "expected exactly 1 corner after drag, found $n (ghost frames left behind)"
-
-exit 0

regress/floating-pane-drag-no-double-composite.sh

@@ -1,88 +0,0 @@
-#!/bin/sh
-
-# Each drag motion must draw the floating pane content once.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-cd "$DIR" || exit 1
-INNER="$TEST_TMUX -Ldoublecomp-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Ldoublecomp-outer-$$ -f/dev/null"
-
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	cd /
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t outer:0.0 -l "$sequence" || exit 1
-	sleep 0.15
-}
-
-$INNER new-session -d -s inner -x 40 -y 15 "printf '\\033[15;1HOUTSIDE'; exec sleep 100" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-$INNER set-option -g status-interval 0 || exit 1
-$INNER set-option -g automatic-rename off || exit 1
-FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 15 -y 5 -X 5 -Y 2 \
-    "printf 'DRAGMARK'; exec sleep 100") || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 15 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Ldoublecomp-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-sleep 0.5
-
-XOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-YOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_top}')
-GRABCOL=$((XOFF + 3))
-BORDERROW=$YOFF
-
-# Begin capture after focus changes from the initial mouse press have settled.
-mouse 0 "$GRABCOL" "$BORDERROW" M
-$OUTER pipe-pane -O -t outer:0.0 "cat >'$DIR/output'" || exit 1
-$INNER refresh-client || exit 1
-sleep 0.5
-grep -aq DRAGMARK "$DIR/output" || fail "capture missed floating pane content"
-grep -aq OUTSIDE "$DIR/output" || fail "capture missed untouched row"
-offset=$(wc -c <"$DIR/output")
-
-i=0
-steps=6
-while [ "$i" -lt "$steps" ]; do
-	GRABCOL=$((GRABCOL + 1))
-	mouse 32 "$GRABCOL" "$BORDERROW" M
-	i=$((i + 1))
-done
-mouse 0 "$GRABCOL" "$BORDERROW" m
-sleep 0.3
-
-NEWXOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-[ "$NEWXOFF" -eq "$((XOFF + steps))" ] || fail "floating pane did not move six columns"
-tail -c +"$((offset + 1))" "$DIR/output" >"$DIR/drag-output"
-n=$(perl -0777 -ne '$n = () = /DRAGMARK/g; print "$n\n"' "$DIR/drag-output")
-[ "$n" -eq "$steps" ] ||
-	fail "$steps drag motions wrote the floating pane content $n times"
-
-exit 0

regress/floating-pane-drag-scrollbar-strip.sh

@@ -1,159 +0,0 @@
-#!/bin/sh
-
-# Regression test: dragging a floating pane across another pane's ordinary
-# content must not redraw that other pane's scrollbar, unless the drag
-# actually crosses the scrollbar's own strip.
-#
-# cmd_resize_pane_redraw_floating() (cmd-resize-pane.c) used to flag
-# PANE_REDRAWSCROLLBAR on any pane whose whole *body* intersected the
-# floating pane's old or new rectangle, rather than just its narrow
-# scrollbar strip - so dragging a floating pane back and forth over an
-# ordinary tiled pane's content (never touching its scrollbar) still
-# needlessly redrew that pane's scrollbar on every motion step. See
-# tmux-image-redraw-known-bugs.md for the full write-up.
-#
-# This is checked by giving the non-dragged pane a distinctive scrollbar
-# colour and counting how many times its SGR code appears in the client's
-# raw output while the floating pane is dragged vertically over that pane's
-# body, well clear of its scrollbar column: with the fix, it should never
-# reappear after the initial draw.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-TMUX="$TEST_TMUX -LtestA$$ -f/dev/null"
-TMUX2="$TEST_TMUX -LtestB$$ -f/dev/null"
-
-cleanup()
-{
-	$TMUX kill-server >/dev/null 2>&1
-	$TMUX2 kill-server >/dev/null 2>&1
-}
-fail()
-{
-	echo "$*" >&2
-	cleanup
-	exit 1
-}
-
-# drag STARTCOL STARTROW ENDCOL ENDROW
-drag()
-{
-	scol="$1"
-	srow="$2"
-	ecol="$3"
-	erow="$4"
-
-	seq=$(printf '\033[<0;%s;%sM' "$scol" "$srow")
-	$TMUX2 send-keys -t "$OUTER" -l "$seq" 2>/dev/null
-	sleep 0.2
-	seq=$(printf '\033[<32;%s;%sM' "$ecol" "$erow")
-	$TMUX2 send-keys -t "$OUTER" -l "$seq" 2>/dev/null
-	sleep 0.2
-	seq=$(printf '\033[<0;%s;%sm' "$ecol" "$erow")
-	$TMUX2 send-keys -t "$OUTER" -l "$seq" 2>/dev/null
-	sleep 0.5
-}
-
-cleanup
-
-TMP=$(mktemp)
-trap "cleanup; rm -f $TMP" 0 1 15
-
-$TMUX new-session -d -s inner -x 60 -y 20 'sh -c "sleep 100"' || exit 1
-$TMUX set -g mouse on || fail "set mouse failed"
-$TMUX set -g default-command 'sh -c "sleep 100"' || fail "set default-command failed"
-$TMUX set -g pane-scrollbars on || fail "set pane-scrollbars failed"
-
-$TMUX split-window -h -t inner 'sh -c "sleep 100"' || fail "split-window failed"
-
-PANES=$($TMUX list-panes -t inner -F '#{pane_id} #{pane_left}')
-LEFT=$(echo "$PANES" | sort -k2 -n | head -1 | cut -d' ' -f1)
-[ -n "$LEFT" ] || fail "could not identify left pane"
-
-# A distinctive scrollbar colour for the non-dragged (left) pane only.
-$TMUX set -p -t "$LEFT" pane-scrollbars-style 'fg=colour201,bg=colour17' ||
-	fail "set pane-scrollbars-style failed"
-
-ALEFT=$($TMUX display-message -p -t "$LEFT" '#{pane_left}')
-ATOP=$($TMUX display-message -p -t "$LEFT" '#{pane_top}')
-AWIDTH=$($TMUX display-message -p -t "$LEFT" '#{pane_width}')
-AHEIGHT=$($TMUX display-message -p -t "$LEFT" '#{pane_height}')
-[ "$AWIDTH" -gt 15 ] || fail "left pane too narrow for this test ($AWIDTH)"
-
-# A small floating pane placed well inside the left pane's content area,
-# clear of its (right-hand) scrollbar column by several columns.
-FLOAT=$($TMUX new-pane -d -PF '#{pane_id}' -x 8 -y 5 \
-    -X $((ALEFT + 2)) -Y $((ATOP + 2))) || fail "new-pane -X -Y failed"
-FTOP=$($TMUX display-message -p -t "$FLOAT" '#{pane_top}')
-FLEFT=$($TMUX display-message -p -t "$FLOAT" '#{pane_left}')
-FWIDTH=$($TMUX display-message -p -t "$FLOAT" '#{pane_width}')
-[ $((FLEFT + FWIDTH + 3)) -lt $((ALEFT + AWIDTH)) ] ||
-	fail "sanity: floating pane too close to the scrollbar column"
-
-# Start the outer session with a plain shell, then start capturing before
-# triggering the attach - starting the attach as the outer pane's initial
-# command would mean pipe-pane only starts after the attach-driven initial
-# redraw (which draws the scrollbars) has already happened, missing it.
-$TMUX2 new-session -d -x 60 -y 20 || exit 1
-OUTER=$($TMUX2 list-panes -F '#{pane_id}' | head -1)
-[ -n "$OUTER" ] || fail "No outer pane."
-$TMUX2 pipe-pane -t "$OUTER" -O "cat >$TMP" || fail "pipe-pane failed"
-$TMUX2 send-keys -t "$OUTER" -l "$TMUX attach -t inner" || fail "send attach failed"
-$TMUX2 send-keys -t "$OUTER" Enter || fail "send enter failed"
-sleep 1
-
-# Sanity check: the distinctive scrollbar colour reaches the client at all.
-grep -qa '48;5;201' $TMP || fail "sanity: scrollbar colour never reached the client"
-: >$TMP
-
-# Drag the floating pane straight up and down by its top border, staying at
-# a fixed column the whole time - this never crosses the left pane's
-# scrollbar strip, only its ordinary content.
-GRABCOL=$((FLEFT + FWIDTH / 2))
-row=$FTOP
-i=0
-while [ $i -lt 6 ]; do
-	newrow=$((row + 1))
-	drag $GRABCOL $row $GRABCOL $newrow
-	row=$newrow
-	i=$((i + 1))
-done
-i=0
-while [ $i -lt 6 ]; do
-	newrow=$((row - 1))
-	drag $GRABCOL $row $GRABCOL $newrow
-	row=$newrow
-	i=$((i + 1))
-done
-
-# The scrollbar colour should never reappear - its geometry never changed,
-# and the drag never crossed its column. This is expected to fail before
-# the fix - see the header comment.
-n=$(grep -ac '48;5;201' $TMP)
-[ "$n" -eq 0 ] ||
-	fail "left pane's scrollbar was redrawn $n times while dragging over its body only"
-
-# Cross the scrollbar and return, comparing each damaged redraw with a full
-# refresh to check that covering and uncovering its cells leaves no artifacts.
-offset=$((ALEFT + AWIDTH - FLEFT - FWIDTH / 2))
-for delta in "$offset" "$((-offset))"; do
-	oldleft=$($TMUX display-message -p -t "$FLOAT" '#{pane_left}')
-	newcol=$((GRABCOL + delta))
-	drag "$GRABCOL" "$row" "$newcol" "$row"
-	GRABCOL=$newcol
-	newleft=$($TMUX display-message -p -t "$FLOAT" '#{pane_left}')
-	[ "$newleft" -eq "$((oldleft + delta))" ] ||
-		fail "floating pane did not move across the scrollbar as expected"
-	before=$($TMUX2 capture-pane -pe -t "$OUTER" -S 0 -E "$((AHEIGHT - 1))")
-	$TMUX refresh-client || fail "refresh-client failed"
-	sleep 0.5
-	after=$($TMUX2 capture-pane -pe -t "$OUTER" -S 0 -E "$((AHEIGHT - 1))")
-	[ "$before" = "$after" ] ||
-		fail "scrollbar crossing differs from a full redraw"
-done
-
-exit 0

regress/floating-pane-drag-sync-no-self-defer.sh

@@ -1,93 +0,0 @@
-#!/bin/sh
-
-# Synchronized drag output must not cause a full redraw of untouched rows.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-cd "$DIR" || exit 1
-INNER="$TEST_TMUX -Lsyncdefer-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lsyncdefer-outer-$$ -f/dev/null"
-
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	cd /
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t outer:0.0 -l "$sequence" || exit 1
-	sleep 0.15
-}
-
-$INNER new-session -d -s inner -x 40 -y 15 "printf '\\033[15;1HOUTSIDE'; exec sleep 100" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-$INNER set-option -g status-interval 0 || exit 1
-$INNER set-option -g automatic-rename off || exit 1
-FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 15 -y 5 -X 5 -Y 2 \
-    "printf 'DRAGMARK'; exec sleep 100") || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 15 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$INNER set-option -as terminal-features ',screen-256color:sync' || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lsyncdefer-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-sleep 0.5
-
-XOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-YOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_top}')
-GRABCOL=$((XOFF + 3))
-BORDERROW=$YOFF
-
-# Begin capture after focus changes from the initial mouse press have settled.
-mouse 0 "$GRABCOL" "$BORDERROW" M
-$OUTER pipe-pane -O -t outer:0.0 "cat >'$DIR/output'" || exit 1
-$INNER refresh-client || exit 1
-sleep 0.5
-grep -aq DRAGMARK "$DIR/output" || fail "capture missed floating pane content"
-grep -aq OUTSIDE "$DIR/output" || fail "capture missed untouched row"
-offset=$(wc -c <"$DIR/output")
-
-i=0
-steps=6
-while [ "$i" -lt "$steps" ]; do
-	GRABCOL=$((GRABCOL + 1))
-	mouse 32 "$GRABCOL" "$BORDERROW" M
-	i=$((i + 1))
-done
-mouse 0 "$GRABCOL" "$BORDERROW" m
-sleep 0.3
-
-NEWXOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-[ "$NEWXOFF" -eq "$((XOFF + steps))" ] || fail "floating pane did not move six columns"
-tail -c +"$((offset + 1))" "$DIR/output" >"$DIR/drag-output"
-n=$(perl -0777 -ne '$n = () = /DRAGMARK/g; print "$n\n"' "$DIR/drag-output")
-[ "$n" -ge "$steps" ] || fail "drag output did not reach the client"
-perl -0777 -ne 'exit(/\e\[\?2026h/ ? 0 : 1)' "$DIR/drag-output" ||
-    fail "drag did not use synchronized output"
-if grep -aq OUTSIDE "$DIR/drag-output"; then
-	fail "synchronized drag redrew an untouched row"
-fi
-
-exit 0

regress/floating-pane-drag-wide-character-right.sh

@@ -1,206 +0,0 @@
-#!/bin/sh
-
-# Mirror of floating-pane-drag-wide-character.sh for the *right* edge of a
-# damage rectangle. redraw_damage_grow_span_clip() (screen-redraw.c) widens
-# a damage rectangle's right edge by one cell whenever it isn't already at
-# the span's own edge, to pull in a wide character's base half when the
-# edge lands on its padding half - but it did this unconditionally, with no
-# check of which half it was actually touching. When the edge instead
-# already lands cleanly on a fresh character's base cell (a character fully
-# outside the range), growing right pulls in just that base cell -
-# tty_draw_line() sees it can't fit that character's full width in the
-# remaining range (tty_draw_line_get_empty()'s gc->data.width > nx check)
-# and clears it, exactly as the left-edge bug cleared a neighbouring
-# character's padding half.
-#
-# As with the left-edge test, the exact column parity needs to be
-# deterministic to actually catch it. This constructs it by creating the
-# floating pane, checking its real position, and recreating it one column
-# over if necessary until the vacated rectangle's right edge lands on a
-# base cell.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lwidecharr-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lwidecharr-outer-$$ -f/dev/null"
-EMITTER=$DIR/emitter.pl
-BASE=$DIR/base
-CAPTURE=$DIR/capture
-FLOAT=
-PANEWIDTH=12
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-slice_columns()
-{
-	# Extract terminal columns [COL1, COL2) from lines [ROW1, ROW2] of
-	# $1, decoding UTF-8 - the pane's own new position (well clear of
-	# this range) must not affect the comparison, so this only looks at
-	# the narrow strip actually vacated, not the whole line. capture-pane
-	# text has one decoded character per double-width cell pair (every
-	# character here is width 2), so terminal columns are converted to
-	# character indices by halving before slicing.
-	perl -CSD -e '
-		my ($row1, $row2, $col1, $col2, $file) = @ARGV;
-		open my $fh, "<:encoding(UTF-8)", $file or die $!;
-		my @lines = <$fh>;
-		my $c1 = int($col1 / 2);
-		my $c2 = int(($col2 + 1) / 2);
-		for my $n ($row1 .. $row2) {
-			my $line = $lines[$n - 1];
-			$line =~ s/\R\z//;
-			print substr($line, $c1, $c2 - $c1), "\n";
-		}
-	' "$ROW1" "$ROW2" "$COL1" "$COL2" "$1"
-}
-
-wait_old_rows_restored()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		slice_columns "$BASE" >"$DIR/want"
-		slice_columns "$CAPTURE" >"$DIR/got"
-		cmp -s "$DIR/want" "$DIR/got" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "wide characters under the floating pane's vacated right edge were not restored"
-}
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t outer:0.0 -l "$sequence" || exit 1
-	sleep 0.1
-}
-
-cat >"$EMITTER" <<'PERL'
-use strict;
-use warnings;
-
-binmode STDOUT, ':encoding(UTF-8)';
-$| = 1;
-for my $row (1 .. 10) {
-	print "\e[$row;1H", chr(0x754c) x 20;
-}
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 40 -y 10 "perl '$EMITTER'" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-$INNER set-option -g pane-scrollbars off || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 10 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lwidecharr-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_client
-wait_outer_has '界界界'
-$OUTER capture-pane -p -t outer:0.0 >"$BASE" || exit 1
-
-# Create the floating pane, then check its actual resulting position. Try
-# adjacent starting columns until the vacated rectangle's right edge
-# (xoff + PANEWIDTH + 1, the border-grown exclusive end - see
-# window_pane_damage_floating(), window.c) lands on an even (base-cell)
-# column.
-startx=5
-tries=0
-while [ "$tries" -lt 2 ]; do
-	[ -n "$FLOAT" ] && $INNER kill-pane -t "$FLOAT" 2>/dev/null
-	FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x "$PANEWIDTH" -y 3 \
-	    -X "$startx" -Y 5 \
-	    'sh -c "printf FLOATMARK; exec sleep 100"') || exit 1
-	sleep 0.2
-	XOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-	YOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_top}')
-	oldright=$((XOFF + PANEWIDTH + 1))
-	if [ $((oldright % 2)) -eq 0 ]; then
-		break
-	fi
-	startx=$((startx + 1))
-	tries=$((tries + 1))
-done
-[ $(((XOFF + PANEWIDTH + 1) % 2)) -eq 0 ] ||
-	fail "could not find bad-parity starting column"
-
-wait_outer_has FLOATMARK
-
-ROW1=$((YOFF + 1))
-ROW2=$((YOFF + 3))
-COL1=$((XOFF + PANEWIDTH - 2))
-COL2=$((XOFF + PANEWIDTH + 2))
-
-# Grab the pane's top border a couple of columns in (avoiding the corner
-# cells) and drag it well clear of its old rectangle - far enough right
-# that its new position starts past the checked columns above (which sit
-# just past the pane's *original* right edge).
-GRABCOL=$((XOFF + 3))
-BORDERROW=$((YOFF))
-
-seq=$(printf '\033[<0;%s;%sM' "$GRABCOL" "$BORDERROW")
-$OUTER send-keys -t outer:0.0 -l "$seq" || exit 1
-sleep 0.1
-seq=$(printf '\033[<32;%s;%sM' "$((GRABCOL + 20))" "$BORDERROW")
-$OUTER send-keys -t outer:0.0 -l "$seq" || exit 1
-sleep 0.1
-seq=$(printf '\033[<0;%s;%sm' "$((GRABCOL + 20))" "$BORDERROW")
-$OUTER send-keys -t outer:0.0 -l "$seq" || exit 1
-sleep 0.1
-
-NEWXOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-[ "$NEWXOFF" != "$XOFF" ] || fail "sanity: floating pane did not move (still at $XOFF)"
-
-wait_old_rows_restored
-
-exit 0

regress/floating-pane-drag-wide-character.sh

@@ -1,200 +0,0 @@
-#!/bin/sh
-
-# Damage at a floating pane's vacated edge must always redraw a complete
-# grid character. redraw_damage_grow_span_clip() (screen-redraw.c) widens a
-# damage rectangle's left edge by one cell whenever it isn't already at the
-# span's own edge, to pull in a wide character's base half when the edge
-# lands on its padding half - but it did this unconditionally, with no
-# check of which half it was actually touching. When the edge instead
-# already lands cleanly on a fresh character's base cell, growing left
-# walks into the *previous*, unrelated character's padding cell and blanks
-# it (tty_draw_line() treats any leading padding cell as proof its own
-# range starts mid-character).
-#
-# This is a general damage-composition bug, not specific to any one kind of
-# pane, but the exact column parity needs to be deterministic to actually
-# catch it (a lucky parity draws fine). This constructs it by creating the
-# floating pane, checking its real position (the border-framing offset
-# added to -X is not something to hand-compute), and recreating it one
-# column over if necessary until the vacated rectangle's left edge lands on
-# a base cell.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lwidechar-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lwidechar-outer-$$ -f/dev/null"
-EMITTER=$DIR/emitter.pl
-BASE=$DIR/base
-CAPTURE=$DIR/capture
-FLOAT=
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-slice_columns()
-{
-	# Extract terminal columns [COL1, COL2) from lines [ROW1, ROW2] of
-	# $1, decoding UTF-8 - the pane's own new position (well clear of
-	# this range) must not affect the comparison, so this only looks at
-	# the narrow strip actually vacated, not the whole line. capture-pane
-	# text has one decoded character per double-width cell pair (every
-	# character here is width 2), so terminal columns are converted to
-	# character indices by halving before slicing.
-	perl -CSD -e '
-		my ($row1, $row2, $col1, $col2, $file) = @ARGV;
-		open my $fh, "<:encoding(UTF-8)", $file or die $!;
-		my @lines = <$fh>;
-		my $c1 = int($col1 / 2);
-		my $c2 = int(($col2 + 1) / 2);
-		for my $n ($row1 .. $row2) {
-			my $line = $lines[$n - 1];
-			$line =~ s/\R\z//;
-			print substr($line, $c1, $c2 - $c1), "\n";
-		}
-	' "$ROW1" "$ROW2" "$COL1" "$COL2" "$1"
-}
-
-wait_old_rows_restored()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		slice_columns "$BASE" >"$DIR/want"
-		slice_columns "$CAPTURE" >"$DIR/got"
-		cmp -s "$DIR/want" "$DIR/got" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "wide characters under the floating pane's vacated edge were not restored"
-}
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t outer:0.0 -l "$sequence" || exit 1
-	sleep 0.1
-}
-
-cat >"$EMITTER" <<'PERL'
-use strict;
-use warnings;
-
-binmode STDOUT, ':encoding(UTF-8)';
-$| = 1;
-for my $row (1 .. 10) {
-	print "\e[$row;1H", chr(0x754c) x 20;
-}
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 40 -y 10 "perl '$EMITTER'" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-$INNER set-option -g pane-scrollbars off || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 10 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lwidechar-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_client
-wait_outer_has '界界界'
-$OUTER capture-pane -p -t outer:0.0 >"$BASE" || exit 1
-
-# Create the floating pane, then check its actual resulting position. Try
-# adjacent starting columns until the vacated rectangle's left edge
-# (xoff - 1) lands on an even (base-cell) column - the odd case is the one
-# every earlier manual test happened to land on by chance.
-startx=5
-tries=0
-while [ "$tries" -lt 2 ]; do
-	[ -n "$FLOAT" ] && $INNER kill-pane -t "$FLOAT" 2>/dev/null
-	FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 12 -y 3 -X "$startx" \
-	    -Y 5 'sh -c "printf FLOATMARK; exec sleep 100"') || exit 1
-	sleep 0.2
-	XOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-	YOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_top}')
-	oldleft=$((XOFF - 1))
-	if [ $((oldleft % 2)) -eq 0 ]; then
-		break
-	fi
-	startx=$((startx + 1))
-	tries=$((tries + 1))
-done
-[ $(((XOFF - 1) % 2)) -eq 0 ] || fail "could not find bad-parity starting column"
-
-wait_outer_has FLOATMARK
-
-ROW1=$((YOFF + 1))
-ROW2=$((YOFF + 3))
-COL1=$((XOFF - 4))
-COL2=$((XOFF + 4))
-
-# Grab the pane's top border a couple of columns in (avoiding the corner
-# cells) and drag it well clear of its old rectangle.
-GRABCOL=$((XOFF + 3))
-BORDERROW=$((YOFF))
-
-seq=$(printf '\033[<0;%s;%sM' "$GRABCOL" "$BORDERROW")
-$OUTER send-keys -t outer:0.0 -l "$seq" || exit 1
-sleep 0.1
-seq=$(printf '\033[<32;%s;%sM' "$((GRABCOL + 15))" "$BORDERROW")
-$OUTER send-keys -t outer:0.0 -l "$seq" || exit 1
-sleep 0.1
-seq=$(printf '\033[<0;%s;%sm' "$((GRABCOL + 15))" "$BORDERROW")
-$OUTER send-keys -t outer:0.0 -l "$seq" || exit 1
-sleep 0.1
-
-NEWXOFF=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-[ "$NEWXOFF" != "$XOFF" ] || fail "sanity: floating pane did not move (still at $XOFF)"
-
-wait_old_rows_restored
-
-exit 0

regress/floating-pane-offscreen-alternate-redraw.sh

@@ -1,102 +0,0 @@
-#!/bin/sh
-
-# Returning from the alternate screen must redraw the visible part of a
-# floating pane clipped at the left edge, the top edge, or both.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Loffscreen-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Loffscreen-outer-$$ -f/dev/null"
-EMITTER=$DIR/emitter.pl
-CAPTURE=$DIR/capture
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-cat >"$EMITTER" <<'PERL'
-use strict;
-use warnings;
-
-$| = 1;
-for my $row (1 .. 5) {
-	print "\e[$row;1H", 'A' x 15;
-}
-while (!-e "$ENV{TRIGGER}-alternate") {
-	select undef, undef, undef, 0.01;
-}
-print "\e[?1049h";
-for my $row (1 .. 5) {
-	print "\e[$row;1H", 'B' x 15;
-}
-while (!-e "$ENV{TRIGGER}-restore") {
-	select undef, undef, undef, 0.01;
-}
-print "\e[?1049l";
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 40 -y 10 'sleep 100' || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 10 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Loffscreen-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-for position in left top both; do
-	case "$position" in
-	left) x=-5; y=2 ;;
-	top) x=5; y=-2 ;;
-	both) x=-5; y=-2 ;;
-	esac
-	FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 15 -y 5 -X "$x" -Y "$y" \
-	    "TRIGGER='$DIR/$position' perl '$EMITTER'") || exit 1
-	[ "$($INNER display-message -p -t "$FLOAT" '#{pane_left},#{pane_top}')" = "$((x + 1)),$((y + 1))" ] ||
-	    fail "$position: floating pane has unexpected position"
-	wait_outer_has AAAAA
-	cp "$CAPTURE" "$DIR/primary"
-	: >"$DIR/$position-alternate"
-	wait_outer_has BBBBB
-	: >"$DIR/$position-restore"
-	wait_outer_has AAAAA
-	cmp -s "$DIR/primary" "$CAPTURE" ||
-	    fail "$position: primary screen was not completely restored"
-	$INNER kill-pane -t "$FLOAT" || exit 1
-done
-
-exit 0

regress/floating-pane-prompt-wide-character.sh

@@ -1,179 +0,0 @@
-#!/bin/sh
-
-# A damage rectangle's clip range is grown to avoid splitting a wide
-# character, but redraw_damage_grow_span_clip() (screen-redraw.c) only ever
-# checks the span's own pane *content* grid (wp->screen) for that. For a
-# REDRAW_SPAN_PANE span, that same range is then also handed to
-# redraw_damage_draw_pane_prompt() to recompose the pane's separately
-# rendered prompt (wp->prompt, e.g. from "command-prompt -P") over the
-# damaged sub-range - but the prompt is drawn into its own, freshly
-# allocated one-line screen, unrelated to the pane's content grid, so a
-# range grown (or left ungrown) against the content is not necessarily
-# grown correctly for the prompt's own wide characters.
-#
-# This is invisible when the pane's own content is plain ASCII (as here):
-# redraw_damage_grow_span_clip() never finds anything to grow against, so
-# the raw, ungrown geometric range is passed straight through to the
-# prompt - and if that range's edge lands mid-character in the *prompt's*
-# grid, tty_draw_line() clears the character it cuts through
-# (tty_draw_line_get_empty()'s gc->data.width > nx check, for a trailing
-# base cell with no room left for its padding half).
-#
-# The trigger is a palette change (OSC 4) in a tiled pane that is one half
-# of a vertical split running the full height of the window - occluded
-# under the floating pane, but still geometrically triggering a redraw of
-# its own rectangle. Positioned so the split boundary falls inside the
-# floating pane's own CJK prompt, this reproduces exactly Codex's report:
-# "a floating pane containing a CJK prompt across a tiled-pane boundary -
-# a palette update in the tiled pane blanks a prompt character."
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-cd "$DIR" || exit 1
-INNER="$TEST_TMUX -Lpromptwide-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lpromptwide-outer-$$ -f/dev/null"
-EMITTER=$DIR/emitter.pl
-CAPTURE=$DIR/capture
-FLOAT=
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	cd /
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-wait_prompt_row_intact()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		line=$(sed -n "${PROMPTROW}p" "$CAPTURE")
-		case $line in
-		*"$PROMPTTEXT"*) return 0 ;;
-		esac
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "the CJK prompt was not intact after the palette-triggered damage - got: $line"
-}
-
-cat >"$EMITTER" <<'PERL'
-use strict;
-use warnings;
-
-$| = 1;
-my $line = <STDIN>;
-print "\e]4;1;rgb:11/22/33\e\\";
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 60 -y 12 "perl '$EMITTER'" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-LEFT=$($INNER list-panes -t inner -F '#{pane_id}') || exit 1
-
-# Split so the boundary between the two tiled panes falls at column 17 -
-# used below to pick a floating-pane column that lands the boundary
-# mid-character inside the prompt.
-RIGHT=$($INNER split-window -t inner -h -l 43 -PF '#{pane_id}' \
-    'sleep 100') || exit 1
-RX=$($INNER display-message -p -t "$RIGHT" '#{pane_left}') || exit 1
-
-# Create the floating pane, then check its actual resulting position (the
-# border-framing offset added to -X is not something to hand-compute). Try
-# adjacent starting columns until the split boundary lands on an odd
-# (padding-half) column of the prompt's own numbering, and within the
-# prompt's 12-column width.
-startx=10
-tries=0
-while [ "$tries" -lt 4 ]; do
-	[ -n "$FLOAT" ] && $INNER kill-pane -t "$FLOAT" 2>/dev/null
-	FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 24 -y 5 -X "$startx" \
-	    -Y 2 "sh -c 'i=0; while [ \$i -lt 10 ]; do \
-printf AAAAAAAAAAAAAAAAAAAAAA\\\\n; i=\$((i+1)); done; sleep 100'") ||
-	    exit 1
-	sleep 0.2
-	X1=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-	Y1=$($INNER display-message -p -t "$FLOAT" '#{pane_top}')
-	H1=$($INNER display-message -p -t "$FLOAT" '#{pane_height}')
-	local=$((RX - X1 - 1))
-	if [ "$local" -ge 1 ] && [ "$local" -le 11 ] &&
-	    [ $((local % 2)) -eq 1 ]; then
-		break
-	fi
-	startx=$((startx + 1))
-	tries=$((tries + 1))
-done
-local=$((RX - X1 - 1))
-[ "$local" -ge 1 ] && [ "$local" -le 11 ] && [ $((local % 2)) -eq 1 ] ||
-	fail "could not find bad-parity starting column"
-
-$OUTER new-session -d -s outer -x 60 -y 12 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lpromptwide-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_client
-wait_outer_has AAAAAAAAAAAAAAAAAAAAAA
-CLIENT=$($INNER list-clients -F '#{client_name}') || exit 1
-
-$INNER select-pane -t "$FLOAT" || exit 1
-PROMPTTEXT=$(printf '\344\270\255' | perl -CSD -ne 'print $_ x 6')
-$INNER command-prompt -b -P -t "$CLIENT" -p "$PROMPTTEXT" \
-    'display-message -- %1' || exit 1
-wait_outer_has "$PROMPTTEXT"
-
-PROMPTROW=$((Y1 + H1))
-
-# Trigger the damage: unblock the emitter so it fires the palette change in
-# the left tiled pane, which is occluded under (but geometrically overlaps)
-# the floating pane's prompt row.
-$INNER send-keys -t "$LEFT" Enter || exit 1
-
-wait_prompt_row_intact
-
-exit 0

regress/floating-pane-status-cross-client.sh

@@ -1,151 +0,0 @@
-#!/bin/sh
-
-# Damage redraws must show each client's own pane status, even though the
-# cached status screen is shared between clients.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lstatuscc-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lstatuscc-outer-$$ -f/dev/null"
-CAPTURE=$DIR/capture
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_clients()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		count=$($INNER list-clients 2>/dev/null | wc -l)
-		[ "$count" -eq 2 ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "two inner clients did not attach"
-}
-
-wait_for_marker()
-{
-	target=$1
-	marker=$2
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t "$target" >"$CAPTURE" || exit 1
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "client in $target did not receive $marker"
-}
-
-cat >"$DIR/emitter.pl" <<'PERL'
-use strict;
-use warnings;
-
-$| = 1;
-for my $phase (1 .. 4) {
-	while (!-e "$ENV{TRIGGER}-$phase") {
-		select undef, undef, undef, 0.01;
-	}
-	# Change an unused palette entry and acknowledge it in the pane body.
-	print "\e]4;200;rgb:11/22/0$phase\a\e[1;1HDAMAGE$phase";
-}
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 60 -y 20 \
-    "TRIGGER='$DIR/trigger' perl '$DIR/emitter.pl'" || exit 1
-$INNER set -g status off || exit 1
-$INNER set -g window-size manual || exit 1
-$INNER set -g automatic-rename off || exit 1
-$INNER set -g status-interval 0 || exit 1
-$INNER set -g pane-border-lines simple || exit 1
-$INNER set -g pane-border-status top || exit 1
-$INNER set -g pane-border-format 'CLIENT=<#{client_name}>' || exit 1
-FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 35 -y 6 -X 5 -Y 5 \
-    'sleep 100') || exit 1
-
-$OUTER new-session -d -s outer -x 121 -y 20 'sleep 100' || exit 1
-$OUTER set -g status off || exit 1
-$OUTER set -g window-size manual || exit 1
-$OUTER set -g default-terminal screen || exit 1
-LEFT=$($OUTER display-message -p -t outer:0.0 '#{pane_id}') || exit 1
-RIGHT=$($OUTER split-window -h -PF '#{pane_id}' 'sleep 100') || exit 1
-for target in "$LEFT" "$RIGHT"; do
-	$OUTER respawn-pane -k -t "$target" "$INNER attach-session -t inner" ||
-	    exit 1
-done
-wait_for_clients
-
-NAME1=$($OUTER display-message -p -t "$LEFT" '#{pane_tty}') || exit 1
-NAME2=$($OUTER display-message -p -t "$RIGHT" '#{pane_tty}') || exit 1
-
-# Disable periodic status updates above and trigger damage without a command
-# that also requests a status redraw. Each client must keep its own title.
-$INNER refresh-client -t "$NAME1" || exit 1
-$INNER refresh-client -t "$NAME2" || exit 1
-sleep 0.5
-for phase in 0 1 2; do
-	if [ "$phase" -ne 0 ]; then
-		: >"$DIR/trigger-$phase"
-		wait_for_marker "$LEFT" "DAMAGE$phase"
-		wait_for_marker "$RIGHT" "DAMAGE$phase"
-		sleep 0.2
-	fi
-	for target in "$LEFT" "$RIGHT"; do
-		if [ "$target" = "$LEFT" ]; then
-			name=$NAME1
-			other=$NAME2
-		else
-			name=$NAME2
-			other=$NAME1
-		fi
-		$OUTER capture-pane -p -S 5 -E 10 -t "$target" \
-		    >"$CAPTURE" || exit 1
-		grep -Fq "CLIENT=<$name>" "$CAPTURE" ||
-		    fail "phase $phase: missing $name's pane status"
-		if grep -Fq "CLIENT=<$other>" "$CAPTURE"; then
-			fail "phase $phase: $name received $other's pane status"
-		fi
-	done
-done
-
-# Leave just one client so a cache keyed only by client would remain stale.
-$OUTER respawn-pane -k -t "$RIGHT" 'sleep 100' || exit 1
-i=0
-while [ "$($INNER list-clients | wc -l)" -ne 1 ]; do
-	[ "$i" -lt 50 ] || fail "second client did not detach"
-	sleep 0.1
-	i=$((i + 1))
-done
-$INNER set-environment -g TEST_STATUS_VALUE initial || exit 1
-$INNER set -g pane-border-format 'VALUE=#{TEST_STATUS_VALUE}' || exit 1
-$INNER refresh-client -t "$NAME1" || exit 1
-wait_for_marker "$LEFT" VALUE=initial
-for phase in 3 4; do
-	# Changing the environment does not itself request a status redraw.
-	$INNER set-environment -g TEST_STATUS_VALUE "phase$phase" || exit 1
-	: >"$DIR/trigger-$phase"
-	wait_for_marker "$LEFT" "DAMAGE$phase"
-	wait_for_marker "$LEFT" "VALUE=phase$phase"
-done
-
-exit 0

regress/floating-pane-status-format.sh

@@ -1,102 +0,0 @@
-#!/bin/sh
-
-# Resizing a floating pane must refresh session status formats which depend on
-# its geometry, not only the pane scene and borders.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lfloating-status-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lfloating-status-outer-$$ -f/dev/null"
-CAPTURE=$DIR/capture
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-wait_outer_has_status()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		tail -1 "$CAPTURE" | grep -q "$marker" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client status did not show $marker"
-}
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t outer:0.0 -l "$sequence" || exit 1
-	sleep 0.1
-}
-
-$INNER new-session -d -s inner -x 50 -y 12 'sleep 100' || exit 1
-FLOAT=$($INNER new-pane -PF '#{pane_id}' -x 10 -y 5 -X 5 -Y 3 \
-    'sleep 100') || fail "could not create floating pane"
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-$INNER set-option -g status on || exit 1
-$INNER set-option -g status-position bottom || exit 1
-$INNER set-option -g status-left 'WIDTH=#{pane_width}' || exit 1
-$INNER set-option -g status-right '' || exit 1
-$INNER set-option -g status-interval 0 || exit 1
-
-$OUTER new-session -d -s outer -x 50 -y 12 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lfloating-status-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_client
-OLD_WIDTH=$($INNER display-message -p -t "$FLOAT" '#{pane_width}')
-wait_outer_has_status "WIDTH=$OLD_WIDTH"
-
-RIGHT=$($INNER display-message -p -t "$FLOAT" '#{pane_right}')
-TOP=$($INNER display-message -p -t "$FLOAT" '#{pane_top}')
-X=$((RIGHT + 2))
-Y=$((TOP + 2))
-
-# Grab the right frame and enlarge the floating pane.
-mouse 0 "$X" "$Y" M
-mouse 32 "$((X + 1))" "$Y" M
-mouse 32 "$((X + 8))" "$Y" M
-mouse 0 "$((X + 8))" "$Y" m
-
-NEW_WIDTH=$($INNER display-message -p -t "$FLOAT" '#{pane_width}')
-[ "$NEW_WIDTH" -ne "$OLD_WIDTH" ] || fail "floating pane was not resized"
-wait_outer_has_status "WIDTH=$NEW_WIDTH"
-
-exit 0

regress/modal-pane.sh

@@ -400,107 +400,6 @@ $TMUX2 send-keys -t "$OUTER" a
 sleep 1
 must_equal "$(fmt modal:0 '#{window_modal_pane}')" ''
 
-$TMUX bind P display-popup -E -t "$p0" -w 20 -h 5 -T popup-title 'cat'
-$TMUX2 send-keys -t "$OUTER" C-b P
-sleep 1
-modal=$(fmt modal:0 '#{window_modal_pane}')
-[ -n "$modal" ] || fail "display-popup did not create a modal pane"
-must_equal "$(fmt "$modal" '#{pane_title}')" popup-title
-must_equal "$($TMUX show-options -pv -t "$modal" pane-border-status)" top
-must_equal "$($TMUX show-options -pv -t "$modal" pane-border-format)" \
-	'#{pane_title}'
-$TMUX2 send-keys -t "$OUTER" C-b x z Enter
-sleep 1
-must_equal "$($TMUX show -gv @modal-prefix)" no
-must_equal "$($TMUX show -gv @modal-root)" no
-case "$($TMUX capture-pane -pt "$modal")" in
-*xz*) ;;
-*) fail "keys did not reach display-popup pane" ;;
-esac
-$TMUX2 send-keys -t "$OUTER" Escape
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" "$modal"
-$TMUX2 send-keys -t "$OUTER" C-c
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" ''
-
-# Creating a popup pane must not fire the split-window hook.
-check_ok set-hook -t modal after-split-window \
-	"set-option -g @popup-after-split yes"
-check_ok set-option -g @popup-after-split no
-check_ok display-popup -E -t "$p0" true
-must_equal "$($TMUX show-option -gv @popup-after-split)" no
-check_ok set-hook -u -t modal after-split-window
-
-# A borderless popup must not create a zero-sized pane in a tiny window.
-check_ok new-window -d -t modal: -n popup-small 'cat'
-check_ok set-option -w -t modal:popup-small window-size manual
-check_ok resize-window -t modal:popup-small -x 1 -y 1
-small=$(fmt modal:popup-small '#{pane_id}')
-check_ok bind Z display-popup -B -t "$small" 'cat'
-$TMUX2 send-keys -t "$OUTER" C-b Z
-sleep 1
-must_equal "$(fmt modal:popup-small '#{window_panes}')" 1
-must_equal "$(fmt modal:popup-small '#{window_modal_pane}')" ''
-
-$TMUX bind D display-popup -t "$p0" -w 20 -h 5 'printf done'
-$TMUX2 send-keys -t "$OUTER" C-b D
-sleep 2
-modal=$(fmt modal:0 '#{window_modal_pane}')
-[ -n "$modal" ] || fail "retained display-popup was not created"
-must_equal "$(fmt "$modal" '#{pane_dead}')" 1
-case "$($TMUX capture-pane -pt "$modal")" in
-*'Pane is dead'*) fail "display-popup showed remain-on-exit message" ;;
-esac
-$TMUX2 send-keys -t "$OUTER" a
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" "$modal"
-$TMUX2 send-keys -t "$OUTER" Escape
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" ''
-
-$TMUX bind K display-popup -k -t "$p0" -w 20 -h 5 'printf done'
-$TMUX2 send-keys -t "$OUTER" C-b K
-sleep 2
-modal=$(fmt modal:0 '#{window_modal_pane}')
-[ -n "$modal" ] || fail "display-popup -k was not created"
-must_equal "$(fmt "$modal" '#{pane_dead}')" 1
-$TMUX2 send-keys -t "$OUTER" a
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" ''
-
-$TMUX bind F display-popup -EE -t "$p0" -w 20 -h 5 'exit 1'
-$TMUX2 send-keys -t "$OUTER" C-b F
-sleep 2
-modal=$(fmt modal:0 '#{window_modal_pane}')
-[ -n "$modal" ] || fail "failed display-popup -EE did not remain"
-must_equal "$(fmt "$modal" '#{pane_dead}')" 1
-$TMUX2 send-keys -t "$OUTER" a
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" "$modal"
-$TMUX2 send-keys -t "$OUTER" Escape
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" "$modal"
-check_ok kill-pane -t "$modal"
-sleep 1
-
-check_ok display-popup -EE -t "$p0" true
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" ''
-
-$TMUX bind G display-popup -EE -k -t "$p0" -w 20 -h 5 'exit 1'
-$TMUX2 send-keys -t "$OUTER" C-b G
-sleep 2
-modal=$(fmt modal:0 '#{window_modal_pane}')
-[ -n "$modal" ] || fail "failed display-popup -EE -k did not remain"
-must_equal "$(fmt "$modal" '#{pane_dead}')" 1
-must_equal "$($TMUX show-options -pv -t "$modal" remain-on-exit)" failed-key
-$TMUX2 send-keys -t "$OUTER" a
-sleep 1
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" ''
-
-check_ok display-popup -EE -k -t "$p0" true
-must_equal "$(fmt modal:0 '#{window_modal_pane}')" ''
-
 # A nonmodal floating pane may remain above zoom, and switching between it and
 # the zoomed tiled pane must not unzoom the window.
 check_ok new-window -d -t modal: -n float-over-zoom 'cat'

regress/mode-tree-menu-position.sh

@@ -1,71 +0,0 @@
-#!/bin/sh
-
-# Chooser menus are centred on the mouse using their displayed width. A
-# hidden title must not move a borderless menu away from the mouse.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-TMUX="$TEST_TMUX -LtestA$$ -f/dev/null"
-TMUX2="$TEST_TMUX -LtestB$$ -f/dev/null"
-
-cleanup()
-{
-	$TMUX kill-server >/dev/null 2>&1
-	$TMUX2 kill-server >/dev/null 2>&1
-}
-trap cleanup 0 1 15
-
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-
-$TMUX new-session -d -s short -x 100 -y 30 'sleep 100' || exit 1
-$TMUX set -g mouse on || exit 1
-$TMUX set -g status off || exit 1
-$TMUX2 new-session -d -x 100 -y 30 "$TMUX attach" || exit 1
-sleep 1
-
-for name in short aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; do
-	$TMUX rename-session "$name" || exit 1
-	for lines in none single padded; do
-		$TMUX set -g menu-border-lines "$lines" || exit 1
-		$TMUX choose-tree -s || exit 1
-		sleep 1
-
-		# Right-button press at window (60, 0), away from either edge.
-		seq=$(printf '\033[<2;61;1M')
-		$TMUX2 send-keys -l "$seq" || exit 1
-		sleep 1
-
-		row=2
-		column=54
-		if [ "$lines" = none ]; then
-			row=1
-		elif [ "$name" != short ]; then
-			column=31
-		fi
-		text=$($TMUX2 capture-pane -p | awk -v row="$row" \
-		    -v column="$column" 'NR == row {
-			# Keep byte offsets equal to columns with non-Unicode awk.
-			gsub(/│/, "|")
-			print substr($0, column, 7)
-		    }')
-		[ "$text" = 'Select ' ] || \
-		    fail "$lines menu for $name: expected Select at ($column, $row), got '$text'"
-
-		# Close the menu, release the button, then leave the chooser.
-		$TMUX2 send-keys Escape || exit 1
-		seq=$(printf '\033[<2;61;1m')
-		$TMUX2 send-keys -l "$seq" || exit 1
-		$TMUX2 send-keys q || exit 1
-		sleep 1
-	done
-done
-
-exit 0

regress/options-values.sh

@@ -86,11 +86,6 @@ check_value "-gv status-keys" "vi"
 check_fail "unknown value: bogus" set -g status-keys bogus
 check_value "-gv status-keys" "vi"
 
-# pane-border-lines accepts rounded as a pane border style.
-check_ok set -gw pane-border-lines rounded
-check_value "-gwv pane-border-lines" "rounded"
-check_ok set -gw pane-border-lines single
-
 # --- flag options ---------------------------------------------------------
 #
 # focus-events is an on/off flag.  Setting with no value toggles it; explicit

regress/popup-drag-wide-character.sh

@@ -1,126 +0,0 @@
-#!/bin/sh
-
-# Damage at a popup edge must redraw complete grid characters. Drawing only a
-# wide character's base or padding cell leaves a two-cell hole behind.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lpopup-wide-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lpopup-wide-outer-$$ -f/dev/null"
-EMITTER=$DIR/emitter.pl
-BASE=$DIR/base
-CAPTURE=$DIR/capture
-POPUP_PID=
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	[ -n "$POPUP_PID" ] && kill "$POPUP_PID" 2>/dev/null
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-wait_old_rows_restored()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		sed -n '3,5p' "$BASE" >"$DIR/want"
-		sed -n '3,5p' "$CAPTURE" >"$DIR/got"
-		cmp -s "$DIR/want" "$DIR/got" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "wide characters under the old popup edge were not restored"
-}
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t outer:0.0 -l "$sequence" || exit 1
-	sleep 0.1
-}
-
-cat >"$EMITTER" <<'PERL'
-use strict;
-use warnings;
-
-binmode STDOUT, ':encoding(UTF-8)';
-$| = 1;
-for my $row (1 .. 10) {
-	print "\e[$row;1H", chr(0x754c) x 20;
-}
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 40 -y 10 "perl '$EMITTER'" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 10 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lpopup-wide-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_client
-wait_outer_has '界界界'
-$OUTER capture-pane -p -t outer:0.0 >"$BASE" || exit 1
-
-$INNER display-popup -t "$CLIENT" -x 5 -y 5 -w 10 -h 3 -E \
-    "sh -c 'printf POPUP; exec sleep 100'" &
-POPUP_PID=$!
-wait_outer_has POPUP
-
-# The first motion starts the drag; the second moves the popup away from its
-# old rectangle. Its odd x coordinate bisects the underlying double-width
-# cells at both edges.
-mouse 0 10 3 M
-mouse 32 11 3 M
-mouse 32 28 7 M
-mouse 0 28 7 m
-wait_old_rows_restored
-
-exit 0

regress/prompt-words-history.sh

@@ -131,14 +131,6 @@ printf '%s\n' "$captured" | grep -Fq 'show-buffer' ||
 printf '%s\n' "$captured" | grep -Fq 'show-environment' ||
 	fail "ambiguous completion list was incomplete"
 $OUTER send-keys Escape || exit 1
-# Wait until Escape has closed the prompt before sending another Meta key.
-# Otherwise the two can be parsed together as a single escape sequence.
-i=0
-while capture | grep -Fq '(word)'; do
-	[ "$i" -lt 50 ] || fail "completion prompt did not close"
-	sleep 0.1
-	i=$((i + 1))
-done
 
 # Add entries to both history rings through real prompts.
 bind_prompt 'history-command'

regress/redraw-damage-accumulate.sh

@@ -1,113 +0,0 @@
-#!/bin/sh
-
-# Many wrapped rows crossing a panned viewport produce disjoint damage.
-# Every row must survive the rectangle-count limit and subsequent merging.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Laccumulate-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Laccumulate-outer-$$ -f/dev/null"
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-wait_marker()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$DIR/capture" || exit 1
-		grep -q "$1" "$DIR/capture" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "client did not receive $1"
-}
-cat >"$DIR/emitter.pl" <<'PERL'
-use strict;
-use warnings;
-$| = 1;
-for my $row (1 .. 80) {
-	printf "\e[%d;1HROW%02d-%s", $row, $row, 'abcdefghij' x 6;
-}
-print "\e[1;1H";
-while (!-e $ENV{TRIGGER}) {
-	select undef, undef, undef, 0.01;
-}
-my $output = '';
-# Each wrapped second row needs a separate damage rectangle. Keep the
-# batch below the PTY read size so all 18 arrive in the same input pass.
-for my $region (0 .. 17) {
-	my $top = 1 + $region * 4;
-	$output .= "\e[$top;1H" . ('A' x 80) . ('B' x 24) .
-	    sprintf('DAMAGE%02d', $region) . ('B' x 48);
-}
-$output .= "\e[80;21HDONE";
-syswrite STDOUT, $output;
-while (!-e "$ENV{TRIGGER}-merge") {
-	select undef, undef, undef, 0.01;
-}
-# Returning from the alternate screen requests a full-pane rectangle. A
-# later wrapped-row rectangle overlaps it and must not shrink that damage.
-$output = "\e[?1049h\e[40;21HALT-VISIBLE\e[?1049l";
-$output .= "\e[1;1H" . ('C' x 80) . ('D' x 24) . 'MERGE00' . ('D' x 49);
-$output .= "\e[80;21HMERGED";
-syswrite STDOUT, $output;
-sleep 100;
-PERL
-$INNER new-session -d -s inner -x 80 -y 80 \
-    "TRIGGER='$DIR/trigger' perl '$DIR/emitter.pl'" || exit 1
-$INNER set -g status off || exit 1
-$INNER set -g window-size manual || exit 1
-$INNER set -g automatic-rename off || exit 1
-$INNER set -g status-interval 0 || exit 1
-$INNER set -as terminal-features ',screen:sync' || exit 1
-$INNER set -g pane-border-lines simple || exit 1
-$OUTER new-session -d -s outer -x 40 -y 80 'sleep 100' || exit 1
-$OUTER set -g status off || exit 1
-$OUTER set -g window-size manual || exit 1
-$OUTER set -g default-terminal screen || exit 1
-$OUTER respawn-pane -k -t outer:0.0 "$INNER attach -t inner" || exit 1
-wait_marker ROW80
-CLIENT=$($OUTER display -p -t outer:0.0 '#{pane_tty}') || exit 1
-$INNER refresh-client -t "$CLIENT" -R 20 || exit 1
-# Keep the emitter inactive so its writes use a synchronized frame. Otherwise
-# its own queued output can force a full redraw and hide lost rectangles.
-$INNER new-pane -x 6 -y 3 -X 65 -Y 74 'sleep 100' || exit 1
-sleep 0.2
-: >"$DIR/trigger"
-wait_marker DONE
-sleep 0.2
-$OUTER capture-pane -p -t outer:0.0 >"$DIR/before" || exit 1
-region=0
-while [ "$region" -lt 18 ]; do
-	marker=$(printf 'DAMAGE%02d' "$region")
-	sed -n "$((2 + region * 4))p" "$DIR/before" | grep -q "$marker" ||
-	    fail "missing damage for region $region"
-	region=$((region + 1))
-done
-$INNER refresh-client -t "$CLIENT" || exit 1
-sleep 0.2
-$OUTER capture-pane -p -t outer:0.0 >"$DIR/after" || exit 1
-diff -u "$DIR/before" "$DIR/after" || fail "accumulated redraw differs from full redraw"
-: >"$DIR/trigger-merge"
-wait_marker MERGED
-sleep 0.2
-$OUTER capture-pane -p -t outer:0.0 >"$DIR/before" || exit 1
-sed -n '2p' "$DIR/before" | grep -q MERGE00 || fail "merged damage lost the wrapped row"
-$INNER refresh-client -t "$CLIENT" || exit 1
-sleep 0.2
-$OUTER capture-pane -p -t outer:0.0 >"$DIR/after" || exit 1
-diff -u "$DIR/before" "$DIR/after" || fail "merged redraw differs from full redraw"
-exit 0

regress/redraw-damage-blocked-client.sh

@@ -1,140 +0,0 @@
-#!/bin/sh
-
-# One terminal stops reading while another consumes floating-pane damage.
-# The slow client must catch up after the window's shared damage is cleared.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lblocked-inner-$$ -f/dev/null"
-FAST="$TEST_TMUX -Lblocked-fast-$$ -f/dev/null"
-SLOW="$TEST_TMUX -Lblocked-slow-$$ -f/dev/null"
-STOPPED=
-cleanup()
-{
-	[ -n "$STOPPED" ] && kill -CONT "$STOPPED" 2>/dev/null
-	$FAST kill-server 2>/dev/null
-	$SLOW kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-wait_marker()
-{
-	terminal=$1
-	marker=$2
-	i=0
-	while [ "$i" -lt 100 ]; do
-		$terminal capture-pane -p >"$DIR/capture" || exit 1
-		grep -q "$marker" "$DIR/capture" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "client did not receive $marker"
-}
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$FAST send-keys -l "$sequence" || exit 1
-	sleep 0.2
-}
-cat >"$DIR/emitter.pl" <<'PERL'
-use strict;
-use warnings;
-$| = 1;
-print 'READY';
-while (!-e "$ENV{TRIGGER}-flood") {
-	select undef, undef, undef, 0.01;
-}
-my $frame = 0;
-while (!-e "$ENV{TRIGGER}-stop") {
-	my $output = '';
-	for my $row (1 .. 20) {
-		$output .= "\e[$row;1H" . join('', map { chr(33 + ($_ + $frame) % 80) } 0 .. 77);
-	}
-	print $output;
-	$frame++;
-	select undef, undef, undef, 0.01;
-}
-for my $row (1 .. 20) {
-	printf "\e[%d;1HFINAL%02d-%s", $row, $row, '0123456789' x 7;
-}
-print "\e[20;1HDONE";
-sleep 100;
-PERL
-$INNER new-session -d -s inner -x 160 -y 80 \
-    "TRIGGER='$DIR/trigger' perl '$DIR/emitter.pl'" || exit 1
-$INNER set -g status off || exit 1
-$INNER set -g window-size manual || exit 1
-$INNER set -g automatic-rename off || exit 1
-$INNER set -g status-interval 0 || exit 1
-$INNER set -g mouse on || exit 1
-$INNER set -g pane-border-lines simple || exit 1
-FLOAT=$($INNER new-pane -PF '#{pane_id}' -x 16 -y 5 -X 5 -Y 5 \
-    'printf FLOAT; exec sleep 100') || exit 1
-for terminal in "$FAST" "$SLOW"; do
-	$terminal new-session -d -x 160 -y 80 'sleep 100' || exit 1
-	$terminal set -g status off || exit 1
-	$terminal set -g window-size manual || exit 1
-	$terminal set -g default-terminal screen || exit 1
-	$terminal respawn-pane -k "$INNER attach -t inner" || exit 1
-	wait_marker "$terminal" READY
-done
-FASTCLIENT=$($FAST display -p '#{pane_tty}') || exit 1
-SLOWCLIENT=$($SLOW display -p '#{pane_tty}') || exit 1
-SLOWPID=$($SLOW display -p '#{pid}') || exit 1
-before=$($INNER display -p -c "$FASTCLIENT" '#{client_written}') || exit 1
-slowbefore=$($INNER display -p -c "$SLOWCLIENT" '#{client_written}') || exit 1
-# The large terminal keeps this backlog below the discard threshold, so
-# automatic recovery from discarded output cannot mask lost damage.
-# Stop only our outer server, leaving its inner client attached to a PTY
-# whose master is no longer read. This creates real terminal backpressure.
-STOPPED=$SLOWPID
-kill -STOP "$SLOWPID" || exit 1
-: >"$DIR/trigger-flood"
-i=0
-while :; do
-	written=$($INNER display -p -c "$SLOWCLIENT" '#{client_written}') || exit 1
-	fastwritten=$($INNER display -p -c "$FASTCLIENT" '#{client_written}') || exit 1
-	# More than a PTY can buffer has been queued for the stopped terminal,
-	# while the other terminal is still receiving the same output.
-	[ "$written" -gt "$((slowbefore + 65536))" ] &&
-	    [ "$fastwritten" -gt "$((before + 65536))" ] && break
-	[ "$i" -lt 100 ] || fail "slow client did not become blocked"
-	sleep 0.1
-	i=$((i + 1))
-done
-: >"$DIR/trigger-stop"
-wait_marker "$FAST" DONE
-[ "$($INNER display -p -c "$FASTCLIENT" '#{client_discarded}')" -eq 0 ] ||
-    fail "fast client also became blocked"
-mouse 0 12 6 M
-mouse 32 42 6 M
-mouse 0 42 6 m
-[ "$($INNER display -p -t "$FLOAT" '#{pane_left}')" -eq 36 ] || fail "pane did not move"
-$FAST capture-pane -p >"$DIR/fast-before" || exit 1
-# Ensure the fast client already restored the vacated frame.
-sed -n '6p' "$DIR/fast-before" | grep -q '^FINAL06-0123456789' ||
-    fail "fast client did not restore old footprint"
-kill -CONT "$SLOWPID" || exit 1
-STOPPED=
-wait_marker "$SLOW" DONE
-# Allow queued terminal output and deferred redraws to drain.
-sleep 0.5
-[ "$($INNER display -p -c "$SLOWCLIENT" '#{client_discarded}')" -eq 0 ] ||
-    fail "discard recovery could mask lost deferred damage"
-$SLOW capture-pane -p >"$DIR/slow-before" || exit 1
-diff -u "$DIR/fast-before" "$DIR/slow-before" || fail "slow client did not catch up"
-$INNER refresh-client -t "$FASTCLIENT" || exit 1
-sleep 0.2
-$FAST capture-pane -p >"$DIR/after" || exit 1
-diff -u "$DIR/fast-before" "$DIR/after" || fail "damage redraw differed from full redraw"
-exit 0

regress/redraw-damage-only.sh

@@ -1,112 +0,0 @@
-#!/bin/sh
-
-# Check a redraw callback which has no accompanying client redraw flags. A
-# wrapped row crossing a panned viewport cannot use the direct tty path.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Ldamage-only-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Ldamage-only-outer-$$ -f/dev/null"
-EMITTER=$DIR/emitter.pl
-TRIGGER=$DIR/trigger
-CAPTURE=$DIR/capture
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-wait_inner_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$INNER capture-pane -p -t inner:0.0 2>/dev/null |
-		    grep -q "$marker" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner pane did not contain $marker"
-}
-
-cat >"$EMITTER" <<'PERL'
-use strict;
-use warnings;
-
-$| = 1;
-for my $row (1 .. 12) {
-	print "\e[$row;1H", 'o' x 79;
-}
-print "\e[1;1H";
-while (!-e $ENV{TRIGGER}) {
-	select undef, undef, undef, 0.01;
-}
-
-my $second = ('B' x 24) . 'DAMAGE-ONLY' . ('B' x 45);
-print "\e[5;1H", ('A' x 80), $second;
-sleep 100;
-PERL
-
-$INNER new-session -d -s inner -x 80 -y 12 \
-    "TRIGGER='$TRIGGER' perl '$EMITTER'" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 12 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Ldamage-only-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_client
-$INNER refresh-client -t "$CLIENT" -R 20 || exit 1
-wait_outer_has oooooooooo
-
-: >"$TRIGGER"
-wait_inner_has DAMAGE-ONLY
-wait_outer_has DAMAGE-ONLY
-
-exit 0

regress/redraw-damage-viewports.sh

@@ -1,112 +0,0 @@
-#!/bin/sh
-
-# Moving and interactively resizing floating panes must restore both clients,
-# including a smaller client panned horizontally and vertically.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lviewports-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lviewports-outer-$$ -f/dev/null"
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t wide:0.0 -l "$sequence" || exit 1
-	sleep 0.2
-}
-assert_scene()
-{
-	# Compare what each terminal actually received with a fresh full redraw.
-	# Capture both first: refreshing one client must not repair the other.
-	for target in wide small; do
-		$OUTER capture-pane -p -t "$target:0.0" >"$DIR/$target-before" || exit 1
-	done
-	$INNER refresh-client -t "$WIDE" || exit 1
-	$INNER refresh-client -t "$SMALL" || exit 1
-	sleep 0.2
-	for target in wide small; do
-		$OUTER capture-pane -p -t "$target:0.0" >"$DIR/$target-after" || exit 1
-		diff -u "$DIR/$target-before" "$DIR/$target-after" ||
-		    fail "$1: $target client differed from a full redraw"
-	done
-}
-
-cat >"$DIR/background.pl" <<'PERL'
-$| = 1;
-for my $row (1 .. 24) {
-	printf "\e[%d;1HROW%02d-", $row, $row;
-	print '0123456789' x 7;
-}
-sleep 100;
-PERL
-$INNER new-session -d -s inner -x 80 -y 24 "perl '$DIR/background.pl'" || exit 1
-$INNER set -g status off || exit 1
-$INNER set -g window-size manual || exit 1
-$INNER set -g automatic-rename off || exit 1
-$INNER set -g status-interval 0 || exit 1
-$INNER set -g mouse on || exit 1
-$INNER set -g default-command 'sleep 100' || exit 1
-$INNER set -g pane-border-lines simple || exit 1
-$OUTER new-session -d -s wide -x 80 -y 24 'sleep 100' || exit 1
-$OUTER set -g status off || exit 1
-$OUTER set -g window-size manual || exit 1
-$OUTER set -g default-terminal screen || exit 1
-$OUTER new-session -d -s small -x 40 -y 12 'sleep 100' || exit 1
-for target in wide small; do
-	$OUTER respawn-pane -k -t "$target:0.0" "$INNER attach -t inner" || exit 1
-done
-i=0
-while [ "$($INNER list-clients | wc -l)" -ne 2 ]; do
-	[ "$i" -lt 50 ] || fail "two clients did not attach"
-	sleep 0.1
-	i=$((i + 1))
-done
-WIDE=$($OUTER display -p -t wide:0.0 '#{pane_tty}') || exit 1
-SMALL=$($OUTER display -p -t small:0.0 '#{pane_tty}') || exit 1
-$INNER refresh-client -t "$SMALL" -R 20 || exit 1
-$INNER refresh-client -t "$SMALL" -D 6 || exit 1
-FLOAT=$($INNER new-pane -d -PF '#{pane_id}' -x 16 -y 6 -X 25 -Y 9) || exit 1
-sleep 0.3
-assert_scene initial
-# Confirm that the two clients really have different viewports.
-[ "$(head -1 "$DIR/wide-before" | cut -c1-6)" = ROW01- ] || fail "wrong wide viewport"
-[ "$(head -1 "$DIR/small-before" | cut -c1-6)" != ROW01- ] || fail "small client was not panned"
-
-# Meta-drag the body using move-pane -M, including a partially clipped position.
-mouse 8 30 12 M
-mouse 40 48 15 M
-[ "$($INNER display -p -t "$FLOAT" '#{pane_left}')" -eq 44 ] || fail "Meta-drag did not move pane"
-assert_scene move-right
-mouse 40 28 10 M
-assert_scene move-back
-mouse 8 28 10 m
-
-# Ctrl-drag creates a new floating pane, then changes its size while held.
-mouse 16 52 14 M
-mouse 48 75 23 M
-NEW=$($INNER display -p '#{pane_id}') || exit 1
-[ "$NEW" != "$FLOAT" ] || fail "Ctrl-drag did not create a pane"
-[ "$($INNER display -p -t "$NEW" '#{pane_floating_flag}')" -eq 1 ] || fail "new pane is not floating"
-assert_scene create
-mouse 48 64 19 M
-[ "$($INNER display -p -t "$NEW" '#{pane_width}')" -eq 11 ] || fail "Ctrl-drag did not shrink pane"
-assert_scene shrink
-mouse 16 64 19 m
-assert_scene release
-exit 0

regress/redraw-multiclient.sh

@@ -1,186 +0,0 @@
-#!/bin/sh
-
-# Redraw a moved floating pane on both attached clients viewing the same
-# window. Window redraw work must not be consumed by only one client.
-#
-# Uses ASCII pane borders (rather than the default UTF-8 box-drawing) because
-# this test nests a real tmux client inside another tmux's pane to get a
-# genuine terminal to capture from; that nested-tmux relay has been observed
-# to mis-render a cell that previously held a multi-byte UTF-8 border
-# character being overwritten later by plain content, on the outer instance's
-# own interpretation, independent of anything the inner tmux sends. That is a
-# nested-test-harness artifact, not a real tmux bug - confirmed by replaying
-# the exact same drag sequence against a real terminal (xterm), where it
-# never reproduces. ASCII borders avoid the artifact entirely.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lredraw-multi-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lredraw-multi-outer-$$ -f/dev/null"
-CAPTURE=$DIR/capture
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_clients()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		count=$($INNER list-clients 2>/dev/null | wc -l)
-		[ "$count" -eq 2 ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "two inner clients did not attach"
-}
-
-wait_outer_has()
-{
-	target=$1
-	marker=$2
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t "$target" >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer pane $target did not show $marker"
-}
-
-wait_float_left()
-{
-	comparison=$1
-	limit=$2
-	i=0
-	while [ "$i" -lt 50 ]; do
-		left=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-		if [ "$comparison" = gt ] && [ "$left" -gt "$limit" ]; then
-			return 0
-		fi
-		if [ "$comparison" = lt ] && [ "$left" -lt "$limit" ]; then
-			return 0
-		fi
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "floating pane did not move"
-}
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$2" "$3" "$4" "$5")
-	$OUTER send-keys -t "$1" -l "$sequence" || exit 1
-	sleep 0.1
-}
-
-drag_float()
-{
-	target=$1
-	startcol=$2
-	startrow=$3
-	endcol=$4
-	mouse "$target" 0 "$startcol" "$startrow" M
-	mouse "$target" 32 "$endcol" "$startrow" M
-	mouse "$target" 0 "$endcol" "$startrow" m
-}
-
-assert_scene()
-{
-	target=$1
-	base=$2
-	firstcol=$3
-	lastcol=$4
-
-	$OUTER capture-pane -p -t "$target" >"$CAPTURE" || exit 1
-
-	# With ASCII (simple) borders every corner and junction is the same
-	# '+', so one rectangular floating pane always draws exactly 4 of
-	# them; more means a stale frame was left behind somewhere.
-	corners=$(grep -o '+' "$CAPTURE" | wc -l)
-	[ "$corners" -eq 4 ] ||
-	    fail "outer pane $target had $corners floating frames"
-
-	sed -n '6,11p' "$base" | cut -c"$firstcol-$lastcol" >"$DIR/want"
-	sed -n '6,11p' "$CAPTURE" | cut -c"$firstcol-$lastcol" >"$DIR/got"
-	cmp -s "$DIR/want" "$DIR/got" ||
-	    fail "outer pane $target did not restore the old floating area"
-}
-
-C="sh -c 'i=0; while [ \$i -lt 20 ]; do printf \"\\033[%d;1HBG-ROW-%02d-abcdefghijklmnopqrstuvwxyz0123456789\" \$((i + 1)) \$i; i=\$((i + 1)); done; exec sleep 100'"
-
-$INNER new-session -d -s inner -x 60 -y 20 "$C" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-$INNER set-option -g default-command 'sleep 100' || exit 1
-$INNER set-option -g pane-border-lines simple || exit 1
-
-$OUTER new-session -d -s outer -x 121 -y 20 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen || exit 1
-$OUTER split-window -h -t outer:0.0 'sleep 100' || exit 1
-
-PANES=$($OUTER list-panes -t outer:0 -F '#{pane_id} #{pane_left}')
-LEFT=$(echo "$PANES" | sort -k2 -n | head -1 | cut -d' ' -f1)
-RIGHT=$(echo "$PANES" | sort -k2 -n | tail -1 | cut -d' ' -f1)
-[ -n "$LEFT" ] && [ -n "$RIGHT" ] || fail "could not find outer panes"
-
-$OUTER respawn-pane -k -t "$LEFT" \
-    "$TEST_TMUX -Lredraw-multi-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-$OUTER respawn-pane -k -t "$RIGHT" \
-    "$TEST_TMUX -Lredraw-multi-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_for_clients
-wait_outer_has "$LEFT" BG-ROW-19
-wait_outer_has "$RIGHT" BG-ROW-19
-$OUTER capture-pane -p -t "$LEFT" >"$DIR/base-left" || exit 1
-$OUTER capture-pane -p -t "$RIGHT" >"$DIR/base-right" || exit 1
-
-FLOAT=$($INNER new-pane -dPF '#{pane_id}' -x 16 -y 5 -X 5 -Y 5) ||
-    fail "could not create floating pane"
-wait_outer_has "$LEFT" '+'
-wait_outer_has "$RIGHT" '+'
-
-FTOP=$($INNER display-message -p -t "$FLOAT" '#{pane_top}')
-FLEFT=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-FWIDTH=$($INNER display-message -p -t "$FLOAT" '#{pane_width}')
-GRABCOL=$((FLEFT + FWIDTH / 2 + 1))
-
-# Move right through one client and require both clients to restore the old
-# left-hand footprint.
-drag_float "$LEFT" "$GRABCOL" "$FTOP" $((GRABCOL + 30))
-wait_float_left gt 30
-assert_scene "$LEFT" "$DIR/base-left" 1 20
-assert_scene "$RIGHT" "$DIR/base-right" 1 20
-
-# Move back through the other client and check the old right-hand footprint.
-FLEFT=$($INNER display-message -p -t "$FLOAT" '#{pane_left}')
-GRABCOL=$((FLEFT + FWIDTH / 2 + 1))
-drag_float "$RIGHT" "$GRABCOL" "$FTOP" $((GRABCOL - 30))
-wait_float_left lt 10
-assert_scene "$LEFT" "$DIR/base-left" 35 60
-assert_scene "$RIGHT" "$DIR/base-right" 35 60
-
-exit 0

regress/redraw-screen-write.sh

@@ -1,208 +0,0 @@
-#!/bin/sh
-
-# Check that full and region screen-write fallbacks update an attached client,
-# not only tmux's internal pane grid.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-EMITTER=$DIR/emitter.pl
-CAPTURE=$DIR/capture
-INNER=
-OUTER=
-N=0
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	[ -n "$OUTER" ] && $OUTER kill-server 2>/dev/null
-	[ -n "$INNER" ] && $INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-wait_outer_lacks()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" || return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client still showed $marker"
-}
-
-wait_inner_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$INNER capture-pane -p -t inner:0.0 2>/dev/null |
-		    grep -q "$marker" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner pane did not contain $marker"
-}
-
-wait_inner_lacks()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$INNER capture-pane -p -t inner:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" || return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner pane still contained $marker"
-}
-
-setup()
-{
-	mode=$1
-	[ -n "$OUTER" ] && $OUTER kill-server 2>/dev/null
-	[ -n "$INNER" ] && $INNER kill-server 2>/dev/null
-	N=$((N + 1))
-	INNER="$TEST_TMUX -Lredraw-write-inner-$$-$N -f/dev/null"
-	OUTER="$TEST_TMUX -Lredraw-write-outer-$$-$N -f/dev/null"
-
-	$INNER new-session -d -s inner -x 40 -y 12 \
-	    "MODE=$mode READY='$DIR/ready-$N' TRIGGER='$DIR/trigger-$N' perl '$EMITTER'" ||
-	    exit 1
-	$INNER set-option -g status off || exit 1
-	$INNER set-option -g window-size manual || exit 1
-
-	$OUTER new-session -d -s outer -x 40 -y 12 'sleep 100' || exit 1
-	$OUTER set-option -g status off || exit 1
-	$OUTER set-option -g window-size manual || exit 1
-	$OUTER set-option -g default-terminal screen || exit 1
-	$OUTER respawn-pane -k -t outer:0.0 \
-	    "$TEST_TMUX -Lredraw-write-inner-$$-$N -f/dev/null attach-session -t inner" ||
-	    exit 1
-}
-
-trigger()
-{
-	: >"$DIR/trigger-$N-${1:-1}"
-}
-
-cat >"$EMITTER" <<'PERL'
-use strict;
-use warnings;
-
-$| = 1;
-my $mode = $ENV{MODE};
-my $ready = $ENV{READY};
-my $trigger = $ENV{TRIGGER};
-
-sub fill_screen {
-	my ($prefix) = @_;
-	print "\e[2J\e[H";
-	for my $row (0 .. 11) {
-		printf "\e[%d;1H%s-ROW-%02d", $row + 1, $prefix, $row;
-	}
-}
-
-if ($mode eq 'ris') {
-	fill_screen('RIS');
-} elsif ($mode eq 'alternate') {
-	fill_screen('BASE');
-} elsif ($mode eq 'scroll') {
-	fill_screen('SCROLL');
-} else {
-	die "unknown mode $mode\n";
-}
-
-open my $fh, '>', $ready or die "$ready: $!\n";
-close $fh;
-while (!-e "$trigger-1") {
-	select undef, undef, undef, 0.01;
-}
-
-if ($mode eq 'ris') {
-	print "\ec";
-} elsif ($mode eq 'alternate') {
-	print "\e[?1049h";
-	fill_screen('ALT');
-	while (!-e "$trigger-2") {
-		select undef, undef, undef, 0.01;
-	}
-	print "\e[?1049l";
-} else {
-	print "\e[12;1H\r\nSCROLL-NEW";
-}
-sleep 100;
-PERL
-
-# RIS clears the complete screen. The source pane and attached client must both
-# lose every old row.
-setup ris
-wait_outer_has RIS-ROW-11
-trigger
-wait_inner_lacks RIS-ROW
-wait_outer_lacks RIS-ROW
-
-# Leaving the alternate screen restores every row of the base screen.
-setup alternate
-wait_outer_has BASE-ROW-11
-trigger
-wait_inner_has ALT-ROW-11
-wait_outer_has ALT-ROW-11
-wait_outer_lacks BASE-ROW
-trigger 2
-wait_inner_has BASE-ROW-11
-wait_outer_has BASE-ROW-11
-wait_outer_lacks ALT-ROW
-
-# Scrolling a pane which is narrower than the terminal redraws its complete
-# region. Check the physical client row by row after the source grid shifts.
-setup scroll
-$INNER split-window -h -t inner:0 'sleep 100' || exit 1
-wait_outer_has SCROLL-ROW-11
-trigger
-wait_inner_has SCROLL-NEW
-wait_outer_has SCROLL-NEW
-row=1
-while [ "$row" -le 11 ]; do
-	expected=$(printf 'SCROLL-ROW-%02d' "$row")
-	actual=$(sed -n "${row}p" "$CAPTURE")
-	case "$actual" in
-	"$expected"*) ;;
-	*) fail "outer row $row was not redrawn as $expected" ;;
-	esac
-	row=$((row + 1))
-done
-actual=$(sed -n '12p' "$CAPTURE")
-case "$actual" in
-SCROLL-NEW*) ;;
-*) fail "outer bottom row was not redrawn as SCROLL-NEW" ;;
-esac
-
-exit 0

regress/screen-redraw-floating.sh

@@ -107,12 +107,6 @@ $TMUX2 new-pane -x28 -y8 -X4 -Y1 -B double \
 	"sh -c 'printf FLOAT; exec sleep 100'" || exit 1
 compare floating-border-double
 
-# Larger floating pane with rounded border lines.
-new_scene 40 12
-$TMUX2 new-pane -x28 -y8 -X4 -Y1 -B rounded \
-	"sh -c 'printf FLOAT; exec sleep 100'" || exit 1
-compare floating-border-rounded
-
 # Floating pane with no border lines: redraw_mark_pane_borders returns early so
 # the float has no border at all, only its (clipped) content over the base pane.
 new_scene 40 12

regress/screen-redraw-menus.sh

@@ -106,28 +106,9 @@ compare menu-over-split
 
 # Menu with no border lines.
 setup 40 14
-$TMUX2 display-menu -T "This title must not reserve width" -C 1 \
-    -b none -x6 -y8 \
-    "Alpha item" a "" \
-    "Beta item" b "" \
-    "" "" "" \
-    "Gamma item" g "" || exit 1
-sleep 1
+menu -b none -x6 -y8
 compare menu-noborder
 
-# Menu border style follows the explicitly targeted window, not the current
-# window when a different pane is selected.
-setup 40 14
-$TMUX2 set menu-border-lines none || exit 1
-$TMUX2 neww || exit 1
-$TMUX2 display-menu -t%0 -T "Menu" -C 1 \
-    "Alpha item" a "" \
-    "Beta item" b "" \
-    "" "" "" \
-    "Gamma item" g "" || exit 1
-$TMUX2 selectw -t%0 || exit 1
-compare menu-target-window-noborder
-
 # Menu with double border lines.
 setup 40 14
 menu -b double -x6 -y8

regress/screen-redraw-popups.sh

@@ -0,0 +1,101 @@
+#!/bin/sh
+
+# Exercise drawing of popups (display-popup) over the window scene. A popup is an
+# overlay drawn on top of the redraw scene (the overlay_draw path in
+# screen-redraw.c), so this guards against regressions in how popups appear.
+#
+# A popup is modal and stays open until its command exits, so each scene fully
+# re-creates the servers and re-attaches; the popup is opened in the background
+# (display-popup blocks the client that runs it) and the outer pane is captured
+# while it is open.
+#
+# Run with GENERATE=1 to (re)create the golden files.
+
+PATH=/bin:/usr/bin
+TERM=screen
+LC_ALL=C.UTF-8
+export TERM LC_ALL
+
+[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
+TMUX=
+TMUX2=
+SETUP=0
+RESULTS=screen-redraw-results
+
+TMP=$(mktemp)
+
+cleanup() {
+	rm -f "$TMP"
+	[ -n "$TMUX" ] && $TMUX kill-server 2>/dev/null
+	[ -n "$TMUX2" ] && $TMUX2 kill-server 2>/dev/null
+}
+trap cleanup 0 1 15
+
+fail() {
+	echo "$*" >&2
+	exit 1
+}
+
+compare() {
+	sleep 1
+	$TMUX capturep -p >$TMP || exit 1
+	if [ -n "$GENERATE" ]; then
+		cp $TMP "$RESULTS/$1.result" || exit 1
+		echo "generated $1"
+	else
+		cmp -s $TMP "$RESULTS/$1.result" || \
+			fail "scene $1 differs from $RESULTS/$1.result"
+	fi
+}
+
+C="sh -c 'i=0; while [ \$i -lt 13 ]; do printf \"POP%02d abcdefghij\n\" \$i; i=\$((i + 1)); done; exec sleep 100'"
+
+# setup: fresh inner window attached inside a fresh outer pane, 40x14.
+setup() {
+	[ -n "$TMUX" ] && $TMUX kill-server 2>/dev/null
+	[ -n "$TMUX2" ] && $TMUX2 kill-server 2>/dev/null
+	SETUP=$((SETUP + 1))
+	TMUX="$TEST_TMUX -LtestA$$-$SETUP -f/dev/null"
+	TMUX2="$TEST_TMUX -LtestB$$-$SETUP -f/dev/null"
+	$TMUX2 new -d -x40 -y14 "$C" || exit 1
+	$TMUX2 set -g status off || exit 1
+	$TMUX2 set -g window-size manual || exit 1
+	$TMUX2 resizew -x40 -y14 || exit 1
+	$TMUX new -d -x40 -y14 || exit 1
+	$TMUX set -g status off || exit 1
+	$TMUX set -g window-size manual || exit 1
+	$TMUX set -g default-terminal "tmux-256color" || exit 1
+	$TMUX send -l "$TMUX2 attach" || exit 1
+	$TMUX send Enter || exit 1
+	sleep 1
+}
+
+# popup <args>: open a popup running a fixed command, in the background (it stays
+# open because the command sleeps; the servers are killed at the next setup).
+popup() {
+	$TMUX2 display-popup "$@" -E "sh -c 'printf POPUP; exec sleep 100'" &
+	sleep 1
+}
+
+# Basic popup over a single pane.
+setup
+popup -w20 -h6 -x6 -y3
+compare popup-basic
+
+# Popup over a split: drawn on top of the pane border.
+setup
+$TMUX2 splitw -h "$C" || exit 1
+popup -w24 -h8 -x8 -y3
+compare popup-over-split
+
+# Popup with no border lines (-B).
+setup
+popup -B -w20 -h6 -x6 -y3
+compare popup-noborder
+
+# Popup with double border lines.
+setup
+popup -b double -w20 -h6 -x6 -y3
+compare popup-double
+
+exit 0

regress/screen-redraw-results/floating-border-rounded.result

@@ -1,12 +0,0 @@
-base
-    ╭──────────────────────────╮
-    │FLOAT                     │
-    │                          │
-    │                          │
-    │                          │
-    │                          │
-    │                          │
-    ╰──────────────────────────╯
-
-
-

regress/screen-redraw-results/menu-noborder.result

@@ -1,11 +1,11 @@
 MENU00 abcdefghij
 MENU01 abcdefghij
-MENU02 abcdefghij
-MENU03 abcdefghij
-MENU04 Alpha item (a) 
-MENU05 Beta item  (b) 
-MENU06                
-MENU07 Gamma item (g) 
+MENU02  Menu            
+MENU03  Alpha item (a)  
+MENU04  Beta item  (b)  
+MENU05                  
+MENU06  Gamma item (g)  
+MENU07                  
 MENU08 abcdefghij
 MENU09 abcdefghij
 MENU10 abcdefghij

regress/screen-redraw-results/menu-target-window-noborder.result

@@ -1,13 +0,0 @@
-MENU00 abcdefghij
-MENU01 abcdefghij
-MENU02 abcdefghij
-MENU03 abcdefghij
-MENU04 abcd Alpha item (a) 
-MENU05 abcd Beta item  (b) 
-MENU06 abcd                
-MENU07 abcd Gamma item (g) 
-MENU08 abcdefghij
-MENU09 abcdefghij
-MENU10 abcdefghij
-MENU11 abcdefghij
-MENU12 abcdefghij

regress/screen-redraw-results/popup-basic.result

@@ -0,0 +1,14 @@
+POP00 ┌──────────────────┐
+POP01 │POPUP             │
+POP02 │                  │
+POP03 │                  │
+POP04 │                  │
+POP05 └──────────────────┘
+POP06 abcdefghij
+POP07 abcdefghij
+POP08 abcdefghij
+POP09 abcdefghij
+POP10 abcdefghij
+POP11 abcdefghij
+POP12 abcdefghij
+

regress/screen-redraw-results/popup-double.result

@@ -0,0 +1,14 @@
+POP00 ╔══════════════════╗
+POP01 ║POPUP             ║
+POP02 ║                  ║
+POP03 ║                  ║
+POP04 ║                  ║
+POP05 ╚══════════════════╝
+POP06 abcdefghij
+POP07 abcdefghij
+POP08 abcdefghij
+POP09 abcdefghij
+POP10 abcdefghij
+POP11 abcdefghij
+POP12 abcdefghij
+

regress/screen-redraw-results/popup-noborder.result

@@ -0,0 +1,14 @@
+POP00 POPUP
+POP01
+POP02
+POP03
+POP04
+POP05
+POP06 abcdefghij
+POP07 abcdefghij
+POP08 abcdefghij
+POP09 abcdefghij
+POP10 abcdefghij
+POP11 abcdefghij
+POP12 abcdefghij
+

regress/screen-redraw-results/popup-over-split.result

@@ -0,0 +1,14 @@
+POP00 ab┌──────────────────────┐fghij
+POP01 ab│POPUP                 │fghij
+POP02 ab│                      │fghij
+POP03 ab│                      │fghij
+POP04 ab│                      │fghij
+POP05 ab│                      │fghij
+POP06 ab│                      │fghij
+POP07 ab└──────────────────────┘fghij
+POP08 abcdefghij    │POP08 abcdefghij
+POP09 abcdefghij    │POP09 abcdefghij
+POP10 abcdefghij    │POP10 abcdefghij
+POP11 abcdefghij    │POP11 abcdefghij
+POP12 abcdefghij    │POP12 abcdefghij
+                    │

regress/switch-client-redraw.sh

@@ -1,81 +0,0 @@
-#!/bin/sh
-
-# Switching windows in the same session must redraw the attached client. The
-# session object is shared, so its current winlink cannot be compared after it
-# has already been changed.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lswitch-redraw-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lswitch-redraw-outer-$$ -f/dev/null"
-CAPTURE=$DIR/capture
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-wait_for_client()
-{
-	i=0
-	while [ "$i" -lt 50 ]; do
-		CLIENT=$($INNER list-clients -F '#{client_name}' 2>/dev/null)
-		[ -n "$CLIENT" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "inner client did not attach"
-}
-
-wait_outer_has()
-{
-	marker=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-		grep -q "$marker" "$CAPTURE" && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "outer client did not show $marker"
-}
-
-$INNER new-session -d -s inner -x 40 -y 8 \
-    "printf '\033[2J\033[HA-WINDOW'; exec sleep 100" || exit 1
-$INNER new-window -d -t inner:1 \
-    "printf '\033[2J\033[HB-WINDOW'; exec sleep 100" || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 8 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lswitch-redraw-inner-$$ -f/dev/null attach-session -t inner:0" ||
-    exit 1
-
-wait_for_client
-wait_outer_has A-WINDOW
-
-$INNER switch-client -c "$CLIENT" -t inner:1.0 || exit 1
-[ "$($INNER display-message -p -t inner '#{window_index}')" -eq 1 ] ||
-    fail "server did not select window 1"
-wait_outer_has B-WINDOW
-
-exit 0

regress/tty-margins-scrollbar.sh

@@ -1,93 +0,0 @@
-#!/bin/sh
-
-# With left/right margins, a pane narrowed by a scrollbar can scroll without
-# retransmitting its existing rows. Both paths must produce the same screen.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lmarginsscrollbar-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lmarginsscrollbar-outer-$$ -f/dev/null"
-
-fail()
-{
-	echo "$*" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-cat >"$DIR/emitter.pl" <<'PERL'
-use strict;
-use warnings;
-$| = 1;
-print join("\r\n", map { "KEEP0$_" } 1 .. 6);
-while (!-e $ENV{TRIGGER}) {
-	select undef, undef, undef, 0.01;
-}
-print "\r\nNEWROW";
-sleep 100;
-PERL
-
-for margins in on off; do
-	$INNER new-session -d -s inner -x 40 -y 6 \
-	    "TRIGGER='$DIR/trigger-$margins' perl '$DIR/emitter.pl'" || exit 1
-	$INNER set -g status off || exit 1
-	$INNER set -g status-interval 0 || exit 1
-	$INNER set -g automatic-rename off || exit 1
-	$INNER set -g window-size manual || exit 1
-	$INNER set -g pane-scrollbars on || exit 1
-	if [ "$margins" = on ]; then
-		$INNER set -as terminal-features ',screen-256color:margins' || exit 1
-	fi
-
-	$OUTER new-session -d -s outer -x 40 -y 6 'sleep 100' || exit 1
-	$OUTER set -g status off || exit 1
-	$OUTER set -g window-size manual || exit 1
-	$OUTER set -g default-terminal screen-256color || exit 1
-	$OUTER respawn-pane -k -t outer:0.0 "$INNER attach -t inner" || exit 1
-	sleep 0.5
-	$OUTER pipe-pane -O -t outer:0.0 "cat >'$DIR/output-$margins'" || exit 1
-	$INNER refresh-client || exit 1
-	sleep 0.5
-	grep -aq KEEP02 "$DIR/output-$margins" || fail "initial rows not captured"
-	offset=$(wc -c <"$DIR/output-$margins")
-	: >"$DIR/trigger-$margins"
-	i=0
-	while [ "$i" -lt 50 ]; do
-		$OUTER capture-pane -p -t outer:0.0 >"$DIR/screen-$margins" || exit 1
-		grep -q NEWROW "$DIR/screen-$margins" && break
-		sleep 0.1
-		i=$((i + 1))
-	done
-	[ "$i" -lt 50 ] || fail "$margins: scroll did not reach the terminal"
-	sleep 0.2
-	tail -c +"$((offset + 1))" "$DIR/output-$margins" >"$DIR/scroll-$margins"
-	grep -aq NEWROW "$DIR/scroll-$margins" || fail "scroll output not captured"
-	if [ "$margins" = on ]; then
-		if grep -aq KEEP02 "$DIR/scroll-$margins"; then
-			fail "scroll with margins retransmitted an existing row"
-		fi
-	else
-		grep -aq KEEP02 "$DIR/scroll-$margins" ||
-		    fail "scroll without margins did not exercise the redraw fallback"
-	fi
-	printf 'KEEP02\nKEEP03\nKEEP04\nKEEP05\nKEEP06\nNEWROW\n' >"$DIR/expected"
-	cmp -s "$DIR/expected" "$DIR/screen-$margins" ||
-	    fail "$margins: terminal did not contain the expected scrolled rows"
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-done
-
-exit 0

regress/window-copy-scrollbar-drag-focus-style.sh

@@ -1,123 +0,0 @@
-#!/bin/sh
-
-# Dragging an inactive pane's scrollbar slider changes which pane is
-# active (window_copy_scroll(), window-copy.c). Every other place in the
-# codebase that changes the active pane pairs it with
-# window_redraw_active_switch() (or falls back to a full window redraw) so
-# the old/new active panes' window-active-style/window-style colours get
-# repainted - window_copy_scroll() was the one caller that did neither, so
-# a scrollbar-slider drag changed focus but left both panes' body colours
-# stale. This used to be masked by window_set_active_pane() itself doing
-# an unconditional full redraw on every active-pane change, until that was
-# narrowed to borders/status-only for the common case.
-#
-# This creates two tiled panes with clearly distinguishable
-# window-active-style/window-style backgrounds, puts the *inactive* one in
-# copy mode, drags its scrollbar slider, and checks - via an attached
-# client's own received bytes, since window-style is applied during
-# redraw composition rather than stored in the grid, so capture-pane
-# alone would not reflect it - that the newly active pane's marker text
-# immediately shows the active-style colour, not the stale one.
-
-PATH=/bin:/usr/bin
-TERM=screen
-LC_ALL=C.UTF-8
-export PATH TERM LC_ALL
-
-[ -z "$TEST_TMUX" ] && TEST_TMUX=$(readlink -f ../tmux)
-
-DIR=$(mktemp -d) || exit 1
-INNER="$TEST_TMUX -Lsbfocus-inner-$$ -f/dev/null"
-OUTER="$TEST_TMUX -Lsbfocus-outer-$$ -f/dev/null"
-CAPTURE=$DIR/capture
-ESC=$(printf '\033')
-
-fail()
-{
-	echo "$*" >&2
-	[ -s "$CAPTURE" ] && cat -A "$CAPTURE" >&2
-	exit 1
-}
-
-cleanup()
-{
-	$OUTER kill-server 2>/dev/null
-	$INNER kill-server 2>/dev/null
-	rm -rf "$DIR"
-}
-trap cleanup 0 1 15
-
-get_mark_color()
-{
-	$OUTER capture-pane -e -p -t outer:0.0 >"$CAPTURE" 2>/dev/null || true
-	LC_ALL=C grep -a "MARK1" "$CAPTURE" |
-	    LC_ALL=C grep -aoE "${ESC}\[4[12]m" | tail -1
-}
-
-wait_mark_color()
-{
-	want=$1
-	i=0
-	while [ "$i" -lt 50 ]; do
-		[ "$(get_mark_color)" = "$want" ] && return 0
-		sleep 0.1
-		i=$((i + 1))
-	done
-	fail "MARK1's pane never showed the expected background (wanted '$want', got '$(get_mark_color)')"
-}
-
-mouse()
-{
-	sequence=$(printf '\033[<%s;%s;%s%s' "$1" "$2" "$3" "$4")
-	$OUTER send-keys -t outer:0.0 -l "$sequence" || exit 1
-	sleep 0.1
-}
-
-$INNER new-session -d -s inner -x 40 -y 10 'sleep 100' || exit 1
-$INNER set-option -g status off || exit 1
-$INNER set-option -g window-size manual || exit 1
-$INNER set-option -g mouse on || exit 1
-$INNER set-option -g pane-scrollbars on || exit 1
-$INNER setw pane-scrollbars-position right || exit 1
-$INNER setw pane-scrollbars-style 'width=1,pad=0' || exit 1
-$INNER set-option -g window-active-style 'bg=red' || exit 1
-$INNER set-option -g window-style 'bg=green' || exit 1
-$INNER split-window -h -t inner -d 'printf MARK1; sleep 100' || exit 1
-
-PANE1=$($INNER list-panes -t inner -F '#{pane_id}' | sed -n 2p)
-[ "$($INNER display-message -p -t "$PANE1" '#{pane_active}')" = 0 ] ||
-	fail "sanity: MARK1's pane is already active before the drag"
-
-# Put the inactive pane in copy mode without switching focus (copy-mode -t
-# targets a pane without making it active).
-$INNER copy-mode -t "$PANE1" || exit 1
-
-$OUTER new-session -d -s outer -x 40 -y 10 'sleep 100' || exit 1
-$OUTER set-option -g status off || exit 1
-$OUTER set-option -g window-size manual || exit 1
-$OUTER set-option -g default-terminal screen-256color || exit 1
-$OUTER respawn-pane -k -t outer:0.0 \
-    "$TEST_TMUX -Lsbfocus-inner-$$ -f/dev/null attach-session -t inner" ||
-    exit 1
-
-wait_mark_color "${ESC}[42m"
-
-XOFF=$($INNER display-message -p -t "$PANE1" '#{pane_left}')
-YOFF=$($INNER display-message -p -t "$PANE1" '#{pane_top}')
-SX=$($INNER display-message -p -t "$PANE1" '#{pane_width}')
-SBCOL=$((XOFF + SX + 1))
-SBROW=$((YOFF + 1))
-
-# With no scrollback beyond the pane's own content, the slider fills the
-# whole scrollbar track, so any point on it (here, its very first row) is
-# on the slider.
-mouse 0 "$SBCOL" "$SBROW" M
-mouse 32 "$SBCOL" "$((SBROW + 1))" M
-mouse 0 "$SBCOL" "$((SBROW + 1))" m
-
-[ "$($INNER display-message -p -t "$PANE1" '#{pane_active}')" = 1 ] ||
-	fail "sanity: dragging the scrollbar slider did not change focus"
-
-wait_mark_color "${ESC}[41m"
-
-exit 0

screen-redraw.c

@@ -33,7 +33,7 @@
  * this is done at various points, such as when a pane is moved or resized. The
  * scene only includes the part of the client used for the window: panes, pane
  * status lines, borders, scrollbars, and any area outside the window. The
- * client status line is not included.
+ * client status line and overlay are not included.
  *
  * A scene is made from spans. A span is a horizontal run of cells on one
  * visible line that can be drawn in the same way. Each span has a type, for
@@ -93,6 +93,7 @@ enum redraw_span_type {
 #define REDRAW_PANE_SCROLLBAR 0x20
 #define REDRAW_STATUS 0x40
 #define REDRAW_MENU 0x80
+#define REDRAW_OVERLAY 0x100
 
 /* Draw everything. */
 #define REDRAW_ALL 0x7fffffff
@@ -204,36 +205,14 @@ struct redraw_scene {
 	u_int			 oy;
 };
 
-/* A damaged rectangle in a window. */
-struct redraw_damage {
-	u_int				 x;
-	u_int				 y;
-	u_int				 sx;
-	u_int				 sy;
-
-	TAILQ_ENTRY(redraw_damage)	entry;
-};
-
-/*
- * If there are more damage rectangles than this, they are collapsed into
- * one.
- */
-#define REDRAW_DAMAGE_MAX 16
-
 /* Cell for building the scene. */
 struct redraw_build_cell {
 	struct redraw_span_data	 data;
 };
+
 static struct redraw_build_cell	*redraw_cells;
 static size_t			 redraw_ncells;
 
-/*
- * We can reuse the same pane status lines during one damage redraw, but when
- * we enter a new one, the client or format variables may have changed, so we
- * need to make them again. The generation is increased so this happens.
- */
-static u_int	redraw_status_generation;
-
 /* Context for building the scene. */
 struct redraw_build_ctx {
 	struct client				*c;
@@ -285,6 +264,8 @@ redraw_flags_to_string(int flags)
 		strlcat(s, "scrollbar ", sizeof s);
 	if (flags & REDRAW_MENU)
 		strlcat(s, "menu ", sizeof s);
+	if (flags & REDRAW_OVERLAY)
+		strlcat(s, "overlay ", sizeof s);
 	if (REDRAW_IS_ALL(flags))
 		strlcat(s, "all ", sizeof s);
 	if (*s != '\0')
@@ -1076,13 +1057,6 @@ redraw_free_scene(struct redraw_scene *scene)
 	free(scene);
 }
 
-/* Does a client's cached scene show this window? */
-int
-redraw_client_has_window(struct client *c, struct window *w)
-{
-	return (c->redraw_scene != NULL && c->redraw_scene->w == w);
-}
-
 /* Mark a window's cached redraw scenes as out of date. */
 void
 redraw_invalidate_scene(struct window *w)
@@ -1090,104 +1064,6 @@ redraw_invalidate_scene(struct window *w)
 	w->redraw_scene_generation++;
 }
 
-/* Free all pending damage for a window. */
-void
-redraw_free_damage(struct window *w)
-{
-	struct redraw_damage	*rd, *rd1;
-
-	TAILQ_FOREACH_SAFE(rd, &w->damage, entry, rd1) {
-		TAILQ_REMOVE(&w->damage, rd, entry);
-		free(rd);
-	}
-	w->damage_count = 0;
-}
-
-/* Collapse all pending damage for a window into one rectangle. */
-static void
-redraw_collapse_damage(struct window *w)
-{
-	struct redraw_damage	*rd, *rd1, *first;
-	u_int			 x0, y0, x1, y1;
-
-	first = TAILQ_FIRST(&w->damage);
-	if (first == NULL)
-		return;
-	x0 = first->x;
-	y0 = first->y;
-	x1 = first->x + first->sx;
-	y1 = first->y + first->sy;
-
-	TAILQ_FOREACH_SAFE(rd, &w->damage, entry, rd1) {
-		if (rd->x < x0)
-			x0 = rd->x;
-		if (rd->y < y0)
-			y0 = rd->y;
-		if (rd->x + rd->sx > x1)
-			x1 = rd->x + rd->sx;
-		if (rd->y + rd->sy > y1)
-			y1 = rd->y + rd->sy;
-		if (rd != first) {
-			TAILQ_REMOVE(&w->damage, rd, entry);
-			free(rd);
-		}
-	}
-
-	first->x = x0;
-	first->y = y0;
-	first->sx = x1 - x0;
-	first->sy = y1 - y0;
-	w->damage_count = 1;
-}
-
-/* Record window damage, merging nearby rectangles and limiting the count. */
-void
-redraw_damage_window(struct window *w, u_int x, u_int y, u_int sx, u_int sy)
-{
-	struct redraw_damage	*rd;
-	u_int			 x0, y0, x1, y1, area, union_area;
-
-	if (x >= w->sx || y >= w->sy)
-		return;
-	if (x + sx > w->sx)
-		sx = w->sx - x;
-	if (y + sy > w->sy)
-		sy = w->sy - y;
-	if (sx == 0 || sy == 0)
-		return;
-
-	TAILQ_FOREACH(rd, &w->damage, entry) {
-		if (x > rd->x + rd->sx || rd->x > x + sx ||
-		    y > rd->y + rd->sy || rd->y > y + sy)
-			continue;
-
-		x0 = (x < rd->x) ? x : rd->x;
-		y0 = (y < rd->y) ? y : rd->y;
-		x1 = (x + sx > rd->x + rd->sx) ? x + sx : rd->x + rd->sx;
-		y1 = (y + sy > rd->y + rd->sy) ? y + sy : rd->y + rd->sy;
-
-		area = sx * sy + rd->sx * rd->sy;
-		union_area = (x1 - x0) * (y1 - y0);
-		if (union_area > 2 * area)
-			continue;
-
-		rd->x = x0;
-		rd->y = y0;
-		rd->sx = x1 - x0;
-		rd->sy = y1 - y0;
-		return;
-	}
-
-	rd = xcalloc(1, sizeof *rd);
-	rd->x = x;
-	rd->y = y;
-	rd->sx = sx;
-	rd->sy = sy;
-	TAILQ_INSERT_TAIL(&w->damage, rd, entry);
-	if (++w->damage_count > REDRAW_DAMAGE_MAX)
-		redraw_collapse_damage(w);
-}
-
 /* Mark all cached redraw scenes as out of date. */
 void
 redraw_invalidate_all_scenes(void)
@@ -1505,30 +1381,45 @@ static void
 redraw_draw_span(struct redraw_draw_ctx *dctx, struct redraw_span *span,
     u_int y)
 {
+	struct redraw_scene	*scene = dctx->scene;
 	struct redraw_span_data	*data = &span->data;
 	enum redraw_span_type	 type = data->type;
+	struct client		*c = scene->c;
+	struct tty		*tty = &c->tty;
+	struct visible_ranges	*r;
+	struct visible_range	*rr;
+	u_int			 i, x, n;
 
 	if (type == REDRAW_SPAN_STATUS && ~data->st.wp->flags & PANE_NEWSTATUS)
 		return;
 
-	switch (span->data.type) {
-	case REDRAW_SPAN_PANE:
-		redraw_draw_pane_span(dctx, span, span->x, y, span->width);
-		break;
-	case REDRAW_SPAN_BORDER:
-	case REDRAW_SPAN_EMPTY:
-	case REDRAW_SPAN_OUTSIDE:
-		redraw_draw_border_span(dctx, span, span->x, y, span->width);
-		break;
-	case REDRAW_SPAN_STATUS:
-		redraw_draw_status_span(dctx, span, span->x, y, span->width);
-		break;
-	case REDRAW_SPAN_SCROLLBAR:
-		redraw_draw_scrollbar_span(dctx, span, span->x, y, span->width);
-		break;
-	case REDRAW_SPAN_MENU:
-		redraw_draw_menu_span(dctx, span, span->x, y, span->width);
-		break;
+	r = tty_check_overlay_range(tty, span->x, y, span->width);
+	for (i = 0; i < r->used; i++) {
+		rr = &r->ranges[i];
+		if (rr->nx == 0)
+			continue;
+		x = rr->px;
+		n = rr->nx;
+
+		switch (span->data.type) {
+		case REDRAW_SPAN_PANE:
+			redraw_draw_pane_span(dctx, span, x, y, n);
+			break;
+		case REDRAW_SPAN_BORDER:
+		case REDRAW_SPAN_EMPTY:
+		case REDRAW_SPAN_OUTSIDE:
+			redraw_draw_border_span(dctx, span, x, y, n);
+			break;
+		case REDRAW_SPAN_STATUS:
+			redraw_draw_status_span(dctx, span, x, y, n);
+			break;
+		case REDRAW_SPAN_SCROLLBAR:
+			redraw_draw_scrollbar_span(dctx, span, x, y, n);
+			break;
+		case REDRAW_SPAN_MENU:
+			redraw_draw_menu_span(dctx, span, x, y, n);
+			break;
+		}
 	}
 }
 
@@ -1730,24 +1621,6 @@ redraw_set_draw_context(struct redraw_draw_ctx *dctx,
 		dctx->flags |= REDRAW_ISOLATES;
 }
 
-/* Build a pane prompt. */
-static void
-redraw_make_pane_prompt(struct window_pane *wp, struct screen *screen)
-{
-	struct screen_write_ctx	 ctx;
-	struct prompt_draw_data	 pdd;
-
-	screen_init(screen, wp->sx, 1, 0);
-	screen_write_start(&ctx, screen);
-	pdd.ctx = &ctx;
-	pdd.cursor_x = &wp->prompt_cx;
-	pdd.area_x = 0;
-	pdd.area_width = wp->sx;
-	pdd.prompt_line = 0;
-	prompt_draw(wp->prompt, &pdd);
-	screen_write_stop(&ctx);
-}
-
 /* Draw a pane's prompt over its content. */
 static void
 redraw_draw_pane_prompt(struct redraw_draw_ctx *dctx, struct window_pane *wp)
@@ -1756,6 +1629,8 @@ redraw_draw_pane_prompt(struct redraw_draw_ctx *dctx, struct window_pane *wp)
 	struct client		*c = scene->c;
 	struct tty		*tty = &c->tty;
 	struct screen		 screen;
+	struct screen_write_ctx	 ctx;
+	struct prompt_draw_data	 pdd;
 	int			 ox = scene->ox, oy = scene->oy;
 	int			 sx = scene->sx, sy = scene->sy;
 	int			 line, cy, px, offset, width, wy;
@@ -1788,7 +1663,16 @@ redraw_draw_pane_prompt(struct redraw_draw_ctx *dctx, struct window_pane *wp)
 	if (px + width > sx)
 		width = sx - px;
 
-	redraw_make_pane_prompt(wp, &screen);
+	screen_init(&screen, wp->sx, 1, 0);
+	screen_write_start(&ctx, &screen);
+	pdd.ctx = &ctx;
+	pdd.cursor_x = &wp->prompt_cx;
+	pdd.area_x = 0;
+	pdd.area_width = wp->sx;
+	pdd.prompt_line = 0;
+	prompt_draw(wp->prompt, &pdd);
+	screen_write_stop(&ctx);
+
 	tty_draw_line(tty, &screen, offset, 0, width, px, cy, NULL);
 	screen_free(&screen);
 }
@@ -1804,8 +1688,10 @@ redraw_draw(struct client *c, struct window_pane *wp, int flags)
 	struct screen		*sl;
 	struct redraw_scene	*scene;
 	struct window_pane	*loop;
-	u_int			 width, i, y, lines;
+	u_int			 width, i, y, lines, j;
 	struct redraw_span	*first;
+	struct visible_ranges	*r;
+	struct visible_range	*rr;
 	int			 redraw;
 
 	if (c->flags & CLIENT_SUSPENDED)
@@ -1818,9 +1704,7 @@ redraw_draw(struct client *c, struct window_pane *wp, int flags)
 			redraw = status_prompt_redraw(c);
 		else
 			redraw = status_redraw(c);
-		if (!redraw &&
-		    (~c->flags & CLIENT_REDRAWSTATUSALWAYS) &&
-		    !REDRAW_IS_ALL(flags)) {
+		if (!redraw && !REDRAW_IS_ALL(flags)) {
 			flags &= ~REDRAW_STATUS;
 			if (flags == 0)
 				return;
@@ -1915,9 +1799,19 @@ redraw_draw(struct client *c, struct window_pane *wp, int flags)
 		else
 			y = c->tty.sy - lines;
 		sl = c->status.active;
-		for (i = 0; i < lines; i++)
-			tty_draw_line(tty, sl, 0, i, tty->sx, 0, y + i, NULL);
+		for (i = 0; i < lines; i++) {
+			r = tty_check_overlay_range(tty, 0, y + i, tty->sx);
+			for (j = 0; j < r->used; j++) {
+				rr = &r->ranges[j];
+				if (rr->nx == 0)
+					continue;
+				tty_draw_line(tty, sl, rr->px, i, rr->nx,
+				    rr->px, y + i, NULL);
+			}
+		}
 	}
+	if (c->overlay_draw != NULL && (flags & REDRAW_OVERLAY))
+		c->overlay_draw(c, c->overlay_data);
 
 	tty_reset(tty);
 
@@ -1973,13 +1867,18 @@ redraw_screen(struct client *c)
 {
 	int	flags = 0;
 
-	if (c->flags & CLIENT_REDRAWWINDOW)
-		redraw_draw(c, NULL, REDRAW_ALL);
-	else {
+	if (c->flags & CLIENT_REDRAWWINDOW) {
+		if (c->flags & CLIENT_REDRAWOVERLAY)
+			redraw_draw(c, NULL, REDRAW_ALL);
+		else
+			redraw_draw(c, NULL, REDRAW_ALL & ~REDRAW_OVERLAY);
+	} else {
 		if (c->flags & CLIENT_REDRAWBORDERS)
 			flags |= (REDRAW_PANE_BORDER|REDRAW_PANE_STATUS);
-		if (c->flags & (CLIENT_REDRAWSTATUS|CLIENT_REDRAWSTATUSALWAYS))
+		if (c->flags & CLIENT_REDRAWSTATUS)
 			flags |= (REDRAW_STATUS|REDRAW_PANE_STATUS);
+		if (c->flags & CLIENT_REDRAWOVERLAY)
+			flags |= REDRAW_OVERLAY;
 		if (c->flags & CLIENT_REDRAWMENU)
 			flags |= REDRAW_MENU;
 		if (c->session->curw->window->menu != NULL)
@@ -2004,138 +1903,3 @@ redraw_pane_scrollbar(struct client *c, struct window_pane *wp)
 {
 	redraw_draw(c, wp, REDRAW_PANE_SCROLLBAR);
 }
-
-/* Rebuild damaged pane status. */
-static void
-redraw_damage_refresh_status(struct redraw_draw_ctx *dctx,
-    struct window_pane *wp)
-{
-	struct redraw_span	*first;
-	u_int			 g = wp->status_generation, width;
-
-	if ((wp->flags & PANE_NEWSTATUS) && g == redraw_status_generation)
-		return;
-	width = redraw_pane_status_width(dctx, wp, &first);
-	if (width != 0) {
-		window_make_pane_status(wp, dctx->scene->c, width, first);
-		wp->flags |= PANE_NEWSTATUS;
-		wp->status_generation = redraw_status_generation;
-	}
-}
-
-/* Draw a pane's prompt over a damaged span. */
-static void
-redraw_damage_draw_pane_prompt(struct redraw_draw_ctx *dctx,
-    struct redraw_span *span, u_int y)
-{
-	struct redraw_scene	*scene = dctx->scene;
-	struct window_pane	*wp = span->data.p.wp;
-	struct tty		*tty = &scene->c->tty;
-	struct screen		 screen;
-	u_int			 px = span->data.p.px, width, prompt_y;
-
-	if (wp->prompt == NULL || wp->sx == 0 || wp->sy == 0)
-		return;
-	if (dctx->flags & REDRAW_STATUS_TOP)
-		prompt_y = 0;
-	else
-		prompt_y = wp->sy - 1;
-	if (span->data.p.py != prompt_y)
-		return;
-	redraw_make_pane_prompt(wp, &screen);
-	if (px < screen_size_x(&screen)) {
-		width = span->width;
-		if (width > screen_size_x(&screen) - px)
-			width = screen_size_x(&screen) - px;
-		tty_draw_line(tty, &screen, px, 0, width, span->x, y, NULL);
-	}
-	screen_free(&screen);
-}
-
-/* Draw the spans intersecting a damaged rectangle. */
-static void
-redraw_draw_damage_rectangle(struct redraw_draw_ctx *dctx, u_int x, u_int y,
-    u_int sx, u_int sy)
-{
-	struct redraw_scene	*scene = dctx->scene;
-	struct redraw_line	*line;
-	struct redraw_spans	*spans;
-	struct redraw_span	*span;
-	u_int			 cy, yy, type;
-
-	if (x >= scene->sx || y >= scene->sy)
-		return;
-	if (x + sx > scene->sx)
-		sx = scene->sx - x;
-	if (y + sy > scene->sy)
-		sy = scene->sy - y;
-	if (sx == 0 || sy == 0)
-		return;
-
-	for (yy = y; yy < y + sy; yy++) {
-		line = &scene->lines[yy];
-		if (dctx->flags & REDRAW_STATUS_TOP)
-			cy = dctx->status_lines + yy;
-		else
-			cy = yy;
-		for (type = 0; type < REDRAW_SPAN_TYPES; type++) {
-			spans = &line->spans[type];
-			TAILQ_FOREACH(span, spans, entry) {
-				if (span->x >= x + sx)
-					continue;
-				if (span->x + span->width <= x)
-					continue;
-				if (type == REDRAW_SPAN_STATUS) {
-					redraw_damage_refresh_status(dctx,
-					    span->data.st.wp);
-				}
-				redraw_draw_span(dctx, span, cy);
-				if (type == REDRAW_SPAN_PANE) {
-					redraw_damage_draw_pane_prompt(dctx,
-					    span, cy);
-				}
-			}
-		}
-	}
-}
-
-/* Draw pending window damage on this client. */
-void
-redraw_client_damage(struct client *c)
-{
-	struct window		*w = c->session->curw->window;
-	struct window_pane	*wp;
-	struct redraw_scene	*scene;
-	struct redraw_draw_ctx	 dctx;
-	struct redraw_damage	*rd;
-	u_int			 ox, oy, sx, sy, x0, y0, x1, y1;
-
-	if (TAILQ_EMPTY(&w->damage))
-		return;
-	redraw_status_generation++;
-
-	scene = redraw_get_scene(c);
-	if (scene == NULL)
-		return;
-	redraw_set_draw_context(&dctx, scene);
-	redraw_get_window_offset(c, &ox, &oy, &sx, &sy);
-
-	TAILQ_FOREACH(wp, &w->panes, entry) {
-		wp->border_gc_set = 0;
-		wp->active_border_gc_set = 0;
-	}
-
-	tty_sync_start(&c->tty);
-	tty_update_mode(&c->tty, c->tty.mode & ~CURSOR_MODES, NULL);
-
-	TAILQ_FOREACH(rd, &w->damage, entry) {
-		x0 = (rd->x > ox) ? rd->x : ox;
-		y0 = (rd->y > oy) ? rd->y : oy;
-		x1 = (rd->x + rd->sx < ox + sx) ? rd->x + rd->sx : ox + sx;
-		y1 = (rd->y + rd->sy < oy + sy) ? rd->y + rd->sy : oy + sy;
-		if (x0 < x1 && y0 < y1) {
-			redraw_draw_damage_rectangle(&dctx, x0 - ox, y0 - oy,
-			    x1 - x0, y1 - y0);
-		}
-	}
-}

screen-write.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: screen-write.c,v 1.292 2026/09/21 12:14:32 nicm Exp $ */
+/* $OpenBSD: screen-write.c,v 1.290 2026/08/24 15:05:26 nicm Exp $ */
 
 /*
  * Copyright (c) 2007 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -120,26 +120,14 @@ screen_write_set_cursor(struct screen_write_ctx *ctx, int cx, int cy)
 		evtimer_add(&w->offset_timer, &tv);
 }
 
-/* Redraw lines. */
+/* Do a full redraw. */
 static void
-screen_write_redraw_cb(const struct tty_ctx *ttyctx, u_int py, u_int ny)
+screen_write_redraw_cb(const struct tty_ctx *ttyctx)
 {
 	struct window_pane	*wp = ttyctx->arg;
-	int			 x0, y0, x1, y1;
 
-	if (wp == NULL)
-		return;
-
-	x0 = wp->xoff;
-	y0 = wp->yoff + (int)py;
-	x1 = x0 + (int)wp->sx;
-	y1 = y0 + (int)ny;
-	if (x0 < 0)
-		x0 = 0;
-	if (y0 < 0)
-		y0 = 0;
-	if (x1 > x0 && y1 > y0)
-		redraw_damage_window(wp->window, x0, y0, x1 - x0, y1 - y0);
+	if (wp != NULL)
+		wp->flags |= PANE_REDRAW;
 }
 
 /* Update context for client. */
@@ -317,16 +305,21 @@ screen_write_initctx(struct screen_write_ctx *ctx, struct tty_ctx *ttyctx,
 
 	if (~ctx->flags & SCREEN_WRITE_SYNC) {
 		/*
-		 * For the active pane showing its base screen, only use
-		 * synchronized updates if requested (commands that move the
-		 * cursor); for other panes or a pane in a mode, always use it,
-		 * since the cursor will have to move.
+		 * For the active pane showing its base screen or for an
+		 * overlay (no pane), only use synchronized updates if
+		 * requested (commands that move the cursor); for other panes
+		 * or a pane in a mode, always use it, since the cursor will
+		 * have to move.
 		 */
 		if (ctx->wp != NULL && (ctx->wp != ctx->wp->window->active ||
 		    ctx->wp->screen != &ctx->wp->base))
 			ttyctx->flags |= TTY_CTX_SYNC;
-		else if (is_sync)
-			ttyctx->flags |= TTY_CTX_SYNC;
+		else {
+			if (ctx->wp == NULL)
+				ttyctx->flags |= TTY_CTX_OVERLAY_SYNC;
+			if (is_sync)
+				ttyctx->flags |= TTY_CTX_SYNC;
+		}
 		tty_write(tty_cmd_syncstart, ttyctx);
 		ctx->flags |= SCREEN_WRITE_SYNC;
 	}
@@ -721,7 +714,7 @@ screen_write_fast_copy(struct screen_write_ctx *ctx, struct screen *src,
 			if (!window_position_is_visible(r, xoff + s->cx))
 				break;
 			ttyctx.cell = &gc;
-			ttyctx.flags &= TTY_CTX_SYNC;
+			ttyctx.flags &= (TTY_CTX_OVERLAY_SYNC|TTY_CTX_SYNC);
 			tty_write(tty_cmd_cell, &ttyctx);
 			ttyctx.ocx++;
 
@@ -845,39 +838,34 @@ screen_write_menu(struct screen_write_ctx *ctx, struct menu *menu, int choice,
 	struct screen		*s = ctx->s;
 	struct grid_cell	 default_gc;
 	const struct grid_cell	*gc = &default_gc;
-	u_int			 border, cx = s->cx, cy = s->cy, i, j, width;
+	u_int			 cx, cy, i, j, width = menu->width;
 	const char		*name;
 
+	cx = s->cx;
+	cy = s->cy;
+
 	memcpy(&default_gc, menu_gc, sizeof default_gc);
 
-	if (lines == BOX_LINES_NONE) {
-		border = 0;
-		width = menu->item_width;
-	} else {
-		border = 1;
-		width = menu->width;
-		screen_write_box(ctx, width + 4, menu->count + 2, lines,
-		    border_gc, menu->title);
-	}
+	screen_write_box(ctx, menu->width + 4, menu->count + 2, lines,
+	    border_gc, menu->title);
 
 	for (i = 0; i < menu->count; i++) {
 		name = menu->items[i].name;
 		if (name == NULL) {
-			screen_write_cursormove(ctx, cx, cy + border + i, 0);
-			screen_write_hline(ctx, width + 2 + (2 * border), 1, 1,
-			    lines, border_gc);
+			screen_write_cursormove(ctx, cx, cy + 1 + i, 0);
+			screen_write_hline(ctx, width + 4, 1, 1, lines,
+			    border_gc);
 			continue;
 		}
 
 		if (choice >= 0 && i == (u_int)choice && *name != '-')
 			gc = choice_gc;
 
-		screen_write_cursormove(ctx, cx + border, cy + border + i, 0);
+		screen_write_cursormove(ctx, cx + 1, cy + 1 + i, 0);
 		for (j = 0; j < width + 2; j++)
 			screen_write_putc(ctx, gc, ' ');
 
-		screen_write_cursormove(ctx, cx + border + 1, cy + border + i,
-		    0);
+		screen_write_cursormove(ctx, cx + 2, cy + 1 + i, 0);
 		if (*name == '-') {
 			default_gc.attr |= GRID_ATTR_DIM;
 			format_draw(ctx, gc, width, name + 1, NULL, 0);
@@ -2167,7 +2155,7 @@ screen_write_fullredraw(struct screen_write_ctx *ctx)
 
 	screen_write_initctx(ctx, &ttyctx, 1, 0);
 	if (ttyctx.redraw_cb != NULL)
-		ttyctx.redraw_cb(&ttyctx, 0, ttyctx.sy);
+		ttyctx.redraw_cb(&ttyctx);
 }
 
 /* Trim collected items. */
@@ -3187,7 +3175,7 @@ screen_write_alternateon(struct screen_write_ctx *ctx, struct grid_cell *gc,
 
 	screen_write_initctx(ctx, &ttyctx, 1, 0);
 	if (ttyctx.redraw_cb != NULL)
-		ttyctx.redraw_cb(&ttyctx, 0, ttyctx.sy);
+		ttyctx.redraw_cb(&ttyctx);
 }
 
 /* Turn alternate screen off. */
@@ -3212,5 +3200,5 @@ screen_write_alternateoff(struct screen_write_ctx *ctx, struct grid_cell *gc,
 
 	screen_write_initctx(ctx, &ttyctx, 1, 0);
 	if (ttyctx.redraw_cb != NULL)
-		ttyctx.redraw_cb(&ttyctx, 0, ttyctx.sy);
+		ttyctx.redraw_cb(&ttyctx);
 }

server-client.c

@@ -67,6 +67,77 @@ server_client_how_many(void)
 	return (n);
 }
 
+/* Overlay timer callback. */
+static void
+server_client_overlay_timer(__unused int fd, __unused short events, void *data)
+{
+	server_client_clear_overlay(data);
+}
+
+/* Set an overlay on client. */
+void
+server_client_set_overlay(struct client *c, u_int delay,
+    overlay_check_cb checkcb, overlay_mode_cb modecb,
+    overlay_draw_cb drawcb, overlay_key_cb keycb, overlay_free_cb freecb,
+    overlay_resize_cb resizecb, void *data)
+{
+	struct timeval	tv;
+
+	if (c->overlay_draw != NULL)
+		server_client_clear_overlay(c);
+
+	tv.tv_sec = delay / 1000;
+	tv.tv_usec = (delay % 1000) * 1000L;
+
+	if (event_initialized(&c->overlay_timer))
+		evtimer_del(&c->overlay_timer);
+	evtimer_set(&c->overlay_timer, server_client_overlay_timer, c);
+	if (delay != 0)
+		evtimer_add(&c->overlay_timer, &tv);
+
+	c->overlay_check = checkcb;
+	c->overlay_mode = modecb;
+	c->overlay_draw = drawcb;
+	c->overlay_key = keycb;
+	c->overlay_free = freecb;
+	c->overlay_resize = resizecb;
+	c->overlay_data = data;
+
+	if (c->overlay_check == NULL)
+		c->tty.flags |= TTY_FREEZE;
+	if (c->overlay_mode == NULL)
+		c->tty.flags |= TTY_NOCURSOR;
+	window_update_focus(c->session->curw->window);
+	server_redraw_client(c);
+}
+
+/* Clear overlay mode on client. */
+void
+server_client_clear_overlay(struct client *c)
+{
+	if (c->overlay_draw == NULL)
+		return;
+
+	if (event_initialized(&c->overlay_timer))
+		evtimer_del(&c->overlay_timer);
+
+	if (c->overlay_free != NULL)
+		c->overlay_free(c, c->overlay_data);
+
+	c->overlay_check = NULL;
+	c->overlay_mode = NULL;
+	c->overlay_draw = NULL;
+	c->overlay_key = NULL;
+	c->overlay_free = NULL;
+	c->overlay_resize = NULL;
+	c->overlay_data = NULL;
+
+	c->tty.flags &= ~(TTY_FREEZE|TTY_NOCURSOR);
+	if (c->session != NULL)
+		window_update_focus(c->session->curw->window);
+	server_redraw_client(c);
+}
+
 /* Are these ranges empty? That is, nothing is visible. */
 int
 server_client_ranges_is_empty(struct visible_ranges *r)
@@ -90,6 +161,52 @@ server_client_ensure_ranges(struct visible_ranges *r, u_int n)
 	r->size = n;
 }
 
+/*
+ * Given overlay position and dimensions, return parts of the input range which
+ * are visible.
+ */
+void
+server_client_overlay_range(u_int x, u_int y, u_int sx, u_int sy, u_int px,
+    u_int py, u_int nx, struct visible_ranges *r)
+{
+	u_int	ox, onx;
+
+	/* Trivial case of no overlap in the y direction. */
+	if (py < y || py > y + sy - 1) {
+		server_client_ensure_ranges(r, 1);
+		r->ranges[0].px = px;
+		r->ranges[0].nx = nx;
+		r->used = 1;
+		return;
+	}
+	server_client_ensure_ranges(r, 2);
+
+	/* Visible bit to the left of the popup. */
+	if (px < x) {
+		r->ranges[0].px = px;
+		r->ranges[0].nx = x - px;
+		if (r->ranges[0].nx > nx)
+			r->ranges[0].nx = nx;
+	} else {
+		r->ranges[0].px = 0;
+		r->ranges[0].nx = 0;
+	}
+
+	/* Visible bit to the right of the popup. */
+	ox = x + sx;
+	if (px > ox)
+		ox = px;
+	onx = px + nx;
+	if (onx > ox) {
+		r->ranges[1].px = ox;
+		r->ranges[1].nx = onx - ox;
+	} else {
+		r->ranges[1].px = 0;
+		r->ranges[1].nx = 0;
+	}
+	r->used = 2;
+}
+
 /* Check if this client is inside this server. */
 int
 server_client_check_nested(struct client *c)
@@ -356,13 +473,7 @@ server_client_set_session(struct client *c, struct session *s)
 		tty_update_client_offset(c);
 		status_timer_start(c);
 		server_client_fire_session_changed(c, old);
-
-		/*
-		 * Redraw if the session or displayed window changed. Use the
-		 * cached scene because the session's current window is already set.
-		 */
-		if (old != s || !redraw_client_has_window(c, s->curw->window))
-			server_redraw_client(c);
+		server_redraw_client(c);
 	}
 
 	server_check_unattached();
@@ -379,6 +490,7 @@ server_client_lost(struct client *c)
 		cfg_client = NULL;
 	c->flags |= CLIENT_DEAD;
 
+	server_client_clear_overlay(c);
 	status_prompt_clear(c);
 	status_message_clear(c);
 
@@ -1355,11 +1467,10 @@ server_client_key_callback(struct cmdq_item *item, void *data)
 		m->key = key;
 
 		/*
-		 * Synchronize direct drag output with the later damage redraw
-		 * before invoking the drag callback.
+		 * Mouse drag is in progress, so fire the callback (now that
+		 * the mouse event is valid).
 		 */
 		if ((key & KEYC_MASK_KEY) == KEYC_DRAGGING) {
-			tty_sync_start(&c->tty);
 			c->tty.mouse_drag_update(c, m);
 			goto out;
 		}
@@ -1638,6 +1749,10 @@ server_client_handle_key0(struct client *c, struct key_event *event,
 	if (s == NULL || (c->flags & CLIENT_UNATTACHEDFLAGS))
 		return (0);
 
+	/*
+	 * Handle theme reporting keys before overlays so they work even when a
+	 * popup is open.
+	 */
 	if (event->key == KEYC_REPORT_LIGHT_THEME) {
 		server_client_report_theme(c, THEME_LIGHT);
 		return (0);
@@ -1648,9 +1763,10 @@ server_client_handle_key0(struct client *c, struct key_event *event,
 	}
 
 	/*
-	 * Dead panes waiting for a key, modal cancel keys, panes capturing all keys
-	 * and the command prompt are special cases. The queue might be blocked so
-	 * they need to be processed immediately rather than queued.
+	 * Key presses in overlay mode, dead panes waiting for a key, modal cancel
+	 * keys, panes capturing all keys and the command prompt are special cases.
+	 * The queue might be blocked so they need to be processed immediately
+	 * rather than queued.
 	 */
 	if (~c->flags & CLIENT_READONLY) {
 		if (c->message_string != NULL) {
@@ -1659,11 +1775,22 @@ server_client_handle_key0(struct client *c, struct key_event *event,
 			status_message_clear(c);
 		}
 
+		if (c->overlay_key != NULL) {
+			switch (c->overlay_key(c, c->overlay_data, event)) {
+			case 0:
+				return (0);
+			case 1:
+				server_client_clear_overlay(c);
+				return (0);
+			}
+		}
+
+		server_client_clear_overlay(c);
+
 		wp = s->curw->window->active;
 		if (server_client_handle_dead_key(wp, event->key))
 			return (0);
-		if (wp != NULL &&
-		    wp == wp->window->modal &&
+		if (wp != NULL && wp == wp->window->modal &&
 		    (wp->flags & PANE_CLOSEONCANCEL) &&
 		    (event->key == '\033' || event->key == ('c'|KEYC_CTRL))) {
 			server_kill_pane(wp);
@@ -1786,8 +1913,8 @@ server_client_loop(void)
 	}
 
 	/*
-	 * Clear window redraw state after processing all clients. Deferred
-	 * redraws are preserved in client flags.
+	 * Any windows will have been redrawn as part of clients, so clear
+	 * their flags now.
 	 */
 	RB_FOREACH(w, windows, &windows) {
 		TAILQ_FOREACH(wp, &w->panes, entry) {
@@ -1798,8 +1925,6 @@ server_client_loop(void)
 			wp->flags &= ~(PANE_REDRAW|PANE_REDRAWSCROLLBAR|
 			    PANE_ACTIVITY);
 		}
-		redraw_free_damage(w);
-
 		check_window_name(w);
 	}
 
@@ -2055,8 +2180,11 @@ server_client_reset_state(struct client *c)
 	flags = (tty->flags & TTY_BLOCK);
 	tty->flags &= ~TTY_BLOCK;
 
-	/* Get mode from the menu if any, else from the screen. */
-	if (w->menu != NULL) {
+	/* Get mode from overlay if any, else from screen. */
+	if (c->overlay_draw != NULL) {
+		if (c->overlay_mode != NULL)
+			s = c->overlay_mode(c, c->overlay_data, &cx, &cy);
+	} else if (w->menu != NULL) {
 		menu_get_cursor(w->menu, &cx, &cy);
 		s = menu_screen(w->menu);
 	} else if (wp != NULL && c->prompt == NULL)
@@ -2078,7 +2206,7 @@ server_client_reset_state(struct client *c)
 	if (c->prompt != NULL) {
 		prompt = 1;
 		status_prompt_cursor(c, &cx, &cy);
-	} else if (wp != NULL) {
+	} else if (wp != NULL && c->overlay_draw == NULL) {
 		if (w->menu != NULL) {
 			tty_window_offset(tty, &ox, &oy, &sx, &sy);
 			if (cx < ox || cx >= ox + sx ||
@@ -2133,7 +2261,7 @@ server_client_reset_state(struct client *c)
 			if (!cursor)
 				mode &= ~MODE_CURSOR;
 		}
-	} else if (s == NULL)
+	} else if (c->overlay_mode == NULL || s == NULL)
 		mode &= ~MODE_CURSOR;
 	if (~pane_mode & MODE_SYNC) {
 		log_debug("%s: cursor to %u,%u", __func__, cx, cy);
@@ -2150,7 +2278,7 @@ server_client_reset_state(struct client *c)
 	 * movement events.
 	 */
 	if (options_get_number(oo, "mouse")) {
-		if (w->menu == NULL) {
+		if (c->overlay_draw == NULL && w->menu == NULL) {
 			mode &= ~ALL_MOUSE_MODES;
 			TAILQ_FOREACH(loop, &w->panes, entry) {
 				if (loop->screen->mode & MODE_MOUSE_ALL)
@@ -2166,7 +2294,7 @@ server_client_reset_state(struct client *c)
 	}
 
 	/* Clear bracketed paste mode if at the prompt. */
-	if (prompt)
+	if (c->overlay_draw == NULL && prompt)
 		mode &= ~MODE_BRACKETPASTE;
 
 	/* Set the terminal mode and reset attributes. */
@@ -2345,8 +2473,6 @@ server_client_any_pane_redraw(struct client *c)
 
 	if (c->flags & CLIENT_REDRAWWINDOW)
 		return (1);
-	if (!TAILQ_EMPTY(&w->damage))
-		return (1);
 	TAILQ_FOREACH(wp, &w->panes, entry) {
 		if (wp->flags & (PANE_REDRAW|PANE_REDRAWSCROLLBAR))
 			return (1);
@@ -2363,7 +2489,6 @@ server_client_check_redraw(struct client *c)
 	struct window		*w = s->curw->window;
 	struct window_pane	*wp;
 	int			 needed, tflags, mode = tty->mode;
-	int			 damaged = !TAILQ_EMPTY(&w->damage);
 	struct timeval		 tv = { .tv_usec = 1000 };
 	static struct event	 ev;
 	size_t			 n;
@@ -2371,10 +2496,11 @@ server_client_check_redraw(struct client *c)
 	if (c->flags & (CLIENT_CONTROL|CLIENT_SUSPENDED))
 		return;
 	if (c->flags & CLIENT_ALLREDRAWFLAGS) {
-		log_debug("%s: redraw%s%s%s%s", c->name,
+		log_debug("%s: redraw%s%s%s%s%s", c->name,
 		    (c->flags & CLIENT_REDRAWWINDOW) ? " window" : "",
 		    (c->flags & CLIENT_REDRAWSTATUS) ? " status" : "",
 		    (c->flags & CLIENT_REDRAWBORDERS) ? " borders" : "",
+		    (c->flags & CLIENT_REDRAWOVERLAY) ? " overlay" : "",
 		    (c->flags & CLIENT_REDRAWMENU) ? " menu" : "");
 	}
 
@@ -2389,12 +2515,12 @@ server_client_check_redraw(struct client *c)
 		return;
 	}
 
-	/* Ignore output queued within the current synchronized frame. */
+	/*
+	 * If there is outstanding data, defer the redraw until it has been
+	 * consumed. We can just add a timer to get out of the event loop and
+	 * end up back here.
+	 */
 	n = EVBUFFER_LENGTH(tty->out);
-	if ((tty->flags & TTY_SYNCING) && n > tty->sync_offset)
-		n = tty->sync_offset;
-
-	/* Defer until output drains, preserving damage in client flags. */
 	if (n != 0 || (tty->flags & TTY_BLOCK)) {
 		if (n != 0)
 			log_debug("%s: redraw deferred (%zu left)", c->name, n);
@@ -2406,10 +2532,6 @@ server_client_check_redraw(struct client *c)
 			log_debug("redraw timer started");
 			evtimer_add(&ev, &tv);
 		}
-		if (damaged) {
-			c->flags |= CLIENT_REDRAWWINDOW;
-			return;
-		}
 		TAILQ_FOREACH(wp, &w->panes, entry) {
 			if (wp->flags & PANE_REDRAW) {
 				c->flags |= CLIENT_REDRAWWINDOW;
@@ -2443,10 +2565,6 @@ server_client_check_redraw(struct client *c)
 				redraw_pane_scrollbar(c, wp);
 			}
 		}
-
-		/* Draw damage here if no client redraw flags will handle it. */
-		if (damaged && (c->flags & CLIENT_ALLREDRAWFLAGS) == 0)
-			redraw_client_damage(c);
 	}
 
 	/*
@@ -2460,7 +2578,6 @@ server_client_check_redraw(struct client *c)
 		}
 		server_client_set_progress_bar(c);
 		redraw_screen(c);
-		redraw_client_damage(c);
 	}
 
 	/* Put the tty back how it was. */
@@ -2591,6 +2708,10 @@ server_client_dispatch(struct imsg *imsg, void *arg)
 		tty_resize(&c->tty);
 		tty_repeat_requests(&c->tty, 0);
 		recalculate_sizes();
+		if (c->overlay_resize == NULL)
+			server_client_clear_overlay(c);
+		else
+			c->overlay_resize(c, c->overlay_data);
 		server_redraw_client(c);
 		if (c->session != NULL)
 			server_client_fire_resized(c, old_sx, old_sy);

status.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: status.c,v 1.274 2026/09/21 10:22:31 nicm Exp $ */
+/* $OpenBSD: status.c,v 1.273 2026/07/06 14:29:10 nicm Exp $ */
 
 /*
  * Copyright (c) 2007 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -577,6 +577,8 @@ status_prompt_set(struct client *c, struct cmd_find_state *fs,
 	struct prompt_create_data	pd;
 	struct status_prompt_data	*spd;
 
+	server_client_clear_overlay(c);
+
 	status_message_clear(c);
 	status_prompt_clear(c);
 	status_push_screen(c);

tmux.1

@@ -1,4 +1,4 @@
-.\" $OpenBSD: tmux.1,v 1.1173 2026/09/23 12:37:50 nicm Exp $
+.\" $OpenBSD: tmux.1,v 1.1172 2026/09/22 06:58:05 nicm Exp $
 .\"
 .\" Copyright (c) 2007 Nicholas Marriott <nicholas.marriott@gmail.com>
 .\"
@@ -14,7 +14,7 @@
 .\" IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
 .\" OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 .\"
-.Dd $Mdocdate: September 23 2026 $
+.Dd $Mdocdate: September 22 2026 $
 .Dt TMUX 1
 .Os
 .Sh NAME
@@ -994,19 +994,13 @@ Will run:
 /bin/sh \-c \[aq]vi \[ti]/.tmux.conf\[aq]
 .Ed
 .Pp
-Unless specified, tmux uses the value of
-.Ic default\-shell
-in place of
-.Pa /bin/sh .
-.Pp
 Additionally, the
 .Ic new\-window ,
 .Ic new\-session ,
 .Ic split\-window ,
-.Ic respawn\-window ,
-.Ic respawn\-pane
+.Ic respawn\-window
 and
-.Ic display\-popup
+.Ic respawn\-pane
 commands allow
 .Ar shell\-command
 to be given as multiple arguments and executed directly (without
@@ -5362,16 +5356,10 @@ section on how to specify
 .Ar style .
 .It Ic menu\-border\-lines Ar type
 Set the type of characters used for drawing menu borders.
-.Ar type
-may be one of
-.Ic single ,
-.Ic rounded ,
-.Ic double ,
-.Ic heavy ,
-.Ic simple ,
-.Ic padded ,
-or
-.Ic none .
+See
+.Ic popup\-border\-lines
+for possible values for
+.Ar border\-lines .
 .It Ic message\-command\-style Ar style
 Set status line message command style.
 This is used for the command prompt with
@@ -5995,8 +5983,6 @@ single lines using ACS or UTF\-8 characters
 double lines using UTF\-8 characters
 .It heavy
 heavy lines using UTF\-8 characters
-.It rounded
-single lines with rounded corners using UTF\-8 characters
 .It simple
 simple ASCII characters
 .It number
@@ -6031,6 +6017,48 @@ see the
 section.
 Attributes are ignored.
 .Pp
+.It Ic popup\-style Ar style
+Set the popup style.
+See the
+.Sx STYLES
+section on how to specify
+.Ar style .
+Attributes are ignored.
+.Pp
+.It Ic popup\-border\-style Ar style
+Set the popup border style.
+See the
+.Sx STYLES
+section on how to specify
+.Ar style .
+Attributes are ignored.
+.Pp
+.It Ic popup\-border\-lines Ar type
+Set the type of characters used for drawing popup borders.
+.Ar type
+may be one of:
+.Bl -tag -width Ds
+.It single
+single lines using ACS or UTF\-8 characters (default)
+.It rounded
+variation of single with rounded corners using UTF\-8 characters
+.It double
+double lines using UTF\-8 characters
+.It heavy
+heavy lines using UTF\-8 characters
+.It simple
+simple ASCII characters
+.It padded
+simple ASCII space character
+.It none
+no border
+.El
+.Pp
+.Ql double
+and
+.Ql heavy
+will fall back to standard ACS line drawing when UTF\-8 is not supported.
+.Pp
 .It Xo Ic pane\-scrollbars
 .Op Ic off | modal | on | auto\-hide
 .Xc
@@ -8177,16 +8205,10 @@ command should be omitted.
 .Pp
 .Fl b
 sets the type of characters used for drawing menu borders.
-.Ar border\-lines
-may be one of
-.Ic single ,
-.Ic rounded ,
-.Ic double ,
-.Ic heavy ,
-.Ic simple ,
-.Ic padded ,
-or
-.Ic none .
+See
+.Ic popup\-border\-lines
+for possible values for
+.Ar border\-lines .
 .Pp
 .Fl H
 sets the style for the selected menu item (see
@@ -8222,18 +8244,15 @@ Both may be a row or column number, or one of the following special values:
 .It Li "S" Ta Fl y Ta "The line above or below the status line"
 .El
 .Pp
-Or a format, which is expanded with the following additional variables.
-The
-.Ql popup_
-prefix is retained for compatibility:
+Or a format, which is expanded including the following additional variables:
 .Bl -column "XXXXXXXXXXXXXXXXXXXXXXXXXX" -offset indent
 .It Sy "Variable name" Ta Sy "Replaced with"
-.It Li "popup_centre_x" Ta "Centered in the window"
-.It Li "popup_centre_y" Ta "Centered in the window"
-.It Li "popup_height" Ta "Height of the menu"
+.It Li "popup_centre_x" Ta "Centered in the client"
+.It Li "popup_centre_y" Ta "Centered in the client"
+.It Li "popup_height" Ta "Height of menu or popup"
 .It Li "popup_last_x" Ta "Left of the last menu"
 .It Li "popup_last_y" Ta "Bottom of the last menu"
-.It Li "popup_mouse_bottom" Ta "Bottom at the mouse"
+.It Li "popup_mouse_bottom" Ta "Bottom of at the mouse"
 .It Li "popup_mouse_centre_x" Ta "Horizontal centre at the mouse"
 .It Li "popup_mouse_centre_y" Ta "Vertical centre at the mouse"
 .It Li "popup_mouse_top" Ta "Top at the mouse"
@@ -8244,7 +8263,7 @@ prefix is retained for compatibility:
 .It Li "popup_pane_right" Ta "Right of the pane"
 .It Li "popup_pane_top" Ta "Top of the pane"
 .It Li "popup_status_line_y" Ta "Above or below the status line"
-.It Li "popup_width" Ta "Width of the menu"
+.It Li "popup_width" Ta "Width of menu or popup"
 .It Li "popup_window_status_line_x" Ta "At the window position in status line"
 .It Li "popup_window_status_line_y" Ta "At the status line showing the window"
 .El
@@ -8330,6 +8349,116 @@ lists the format variables and their values.
 .Fl I
 forwards any input read from stdin to the empty pane given by
 .Ar target\-pane .
+.Tg popup
+.It Xo Ic display\-popup
+.Op Fl BCEkN
+.Op Fl b Ar border\-lines
+.Op Fl c Ar target\-client
+.Op Fl d Ar start\-directory
+.Op Fl e Ar environment
+.Op Fl h Ar height
+.Op Fl s Ar style
+.Op Fl S Ar border\-style
+.Op Fl t Ar target\-pane
+.Op Fl T Ar title
+.Op Fl w Ar width
+.Op Fl x Ar position
+.Op Fl y Ar position
+.Op Ar shell\-command Op Ar argument ...
+.Xc
+.D1 Pq alias: Ic popup
+Display a popup running
+.Ar shell\-command
+(or
+.Ar default\-command
+when omitted) on
+.Ar target\-client .
+A popup is a rectangular box drawn over the top of any panes.
+If the command is run inside an existing popup, that popup is modified.
+Only the
+.Fl b ,
+.Fl B ,
+.Fl C ,
+.Fl E ,
+.Fl EE ,
+.Fl K ,
+.Fl N ,
+.Fl s ,
+and
+.Fl S
+options are accepted in this case;
+all others are ignored.
+.Pp
+.Fl E
+closes the popup automatically when
+.Ar shell\-command
+exits.
+Two
+.Fl E
+closes the popup only if
+.Ar shell\-command
+exited with success.
+.Fl k
+allows any key to dismiss the popup instead of only
+.Ql Escape
+or
+.Ql C\-c .
+.Pp
+.Fl x
+and
+.Fl y
+give the position of the popup, they have the same meaning as for the
+.Ic display\-menu
+command.
+.Fl w
+and
+.Fl h
+give the width and height - both may be a percentage (followed by
+.Ql % ) .
+If omitted, half of the terminal size is used.
+.Pp
+.Fl B
+does not surround the popup by a border.
+.Pp
+.Fl b
+sets the type of characters used for drawing popup borders.
+When
+.Fl B
+is specified, the
+.Fl b
+option is ignored.
+See
+.Ic popup\-border\-lines
+for possible values for
+.Ar border\-lines .
+.Pp
+.Fl s
+sets the style for the popup and
+.Fl S
+sets the style for the popup border (see
+.Sx STYLES ) .
+.Pp
+.Fl e
+takes the form
+.Ql VARIABLE=value
+and sets an environment variable for the popup; it may be specified multiple
+times.
+.Pp
+.Fl T
+is a format for the popup title (see
+.Sx FORMATS ) .
+.Pp
+The
+.Fl C
+flag closes any popup on the client.
+.Pp
+.Fl N
+disables any previously specified
+.Fl E ,
+.Fl EE ,
+or
+.Fl k
+option.
 .Tg showphist
 .It Xo Ic show\-prompt\-history
 .Op Fl T Ar prompt\-type

tmux.h

@@ -69,7 +69,6 @@ struct options_array_item;
 struct options_entry;
 struct prompt;
 struct window_pane_prompt;
-struct redraw_damage;
 struct redraw_scene;
 struct redraw_span;
 struct screen_write_citem;
@@ -1153,8 +1152,7 @@ enum pane_lines {
 	PANE_LINES_SIMPLE,
 	PANE_LINES_NUMBER,
 	PANE_LINES_SPACES,
-	PANE_LINES_NONE,
-	PANE_LINES_ROUNDED
+	PANE_LINES_NONE
 };
 
 /* Pane border indicator option. */
@@ -1185,7 +1183,6 @@ struct menu {
 	struct menu_item	*items;
 	u_int			 count;
 	u_int			 width;
-	u_int			 item_width;
 };
 typedef void (*menu_choice_cb)(struct menu *, u_int, key_code, void *);
 
@@ -1403,7 +1400,6 @@ struct window_pane {
 	struct screen	 base;
 
 	struct screen	 status_screen;
-	u_int		 status_generation;
 
 	TAILQ_HEAD(, window_mode_entry) modes;
 
@@ -1434,7 +1430,6 @@ struct window_pane {
 TAILQ_HEAD(window_panes, window_pane);
 TAILQ_HEAD(window_panes_zindex, window_pane);
 RB_HEAD(window_pane_tree, window_pane);
-TAILQ_HEAD(redraw_damages, redraw_damage);
 
 /* Window structure. */
 struct window {
@@ -1478,9 +1473,6 @@ struct window {
 
 	uint64_t		 redraw_scene_generation;
 
-	struct redraw_damages	 damage;
-	u_int			 damage_count;
-
 	struct menu_data	*menu;
 	u_int			 menu_last_px;
 	u_int			 menu_last_py;
@@ -1806,9 +1798,8 @@ struct tty {
 	struct event	 timer;
 	size_t		 discarded;
 
-	size_t		 sync_offset;
-
 	struct termios	 tio;
+	struct visible_ranges r;
 
 	struct grid_cell cell;
 	struct grid_cell last_cell;
@@ -1855,7 +1846,7 @@ struct tty {
 };
 
 /* Terminal command context. */
-typedef void (*tty_ctx_redraw_cb)(const struct tty_ctx *, u_int, u_int);
+typedef void (*tty_ctx_redraw_cb)(const struct tty_ctx *);
 typedef int (*tty_ctx_set_client_cb)(struct tty_ctx *, struct client *);
 struct tty_ctx {
 	struct screen		*s;
@@ -1870,6 +1861,7 @@ struct tty_ctx {
 #define TTY_CTX_INVISIBLE_PANES 0x2
 #define TTY_CTX_WINDOW_BIGGER 0x4
 #define TTY_CTX_SYNC 0x8
+#define TTY_CTX_OVERLAY_SYNC 0x10
 #define TTY_CTX_CELL_INVALIDATE 0x20
 #define TTY_CTX_PANE_OBSCURED 0x40
 
@@ -2204,6 +2196,16 @@ struct prompt_draw_data {
 	u_int			 prompt_line;
 };
 
+/* Overlay callbacks */
+typedef struct visible_ranges *(*overlay_check_cb)(struct client *, void *,
+    u_int, u_int, u_int);
+typedef struct screen *(*overlay_mode_cb)(struct client *, void *, u_int *,
+    u_int *);
+typedef void (*overlay_draw_cb)(struct client *, void *);
+typedef int (*overlay_key_cb)(struct client *, void *, struct key_event *);
+typedef void (*overlay_free_cb)(struct client *, void *);
+typedef void (*overlay_resize_cb)(struct client *, void *);
+
 /* Client connection. */
 struct client {
 	const char		*name;
@@ -2289,7 +2291,7 @@ struct client {
 #define CLIENT_SIZECHANGED 0x400000
 #define CLIENT_STATUSOFF 0x800000
 #define CLIENT_REDRAWSTATUSALWAYS 0x1000000
-/* 0x2000000 unused */
+#define CLIENT_REDRAWOVERLAY 0x2000000
 #define CLIENT_CONTROL_NOOUTPUT 0x4000000
 #define CLIENT_DEFAULTSOCKET 0x8000000
 #define CLIENT_STARTSERVER 0x10000000
@@ -2310,6 +2312,7 @@ struct client {
 	 CLIENT_REDRAWSTATUS|		\
 	 CLIENT_REDRAWSTATUSALWAYS|	\
 	 CLIENT_REDRAWBORDERS|		\
+	 CLIENT_REDRAWOVERLAY|		\
 	 CLIENT_REDRAWMENU)
 #define CLIENT_UNATTACHEDFLAGS	\
 	(CLIENT_DEAD|		\
@@ -2355,6 +2358,15 @@ struct client {
 	u_int			 pan_ox;
 	u_int			 pan_oy;
 
+	overlay_check_cb	 overlay_check;
+	overlay_mode_cb		 overlay_mode;
+	overlay_draw_cb		 overlay_draw;
+	overlay_key_cb		 overlay_key;
+	overlay_free_cb		 overlay_free;
+	overlay_resize_cb	 overlay_resize;
+	void			*overlay_data;
+	struct event		 overlay_timer;
+
 	struct client_files	 files;
 	u_int			 source_file_depth;
 
@@ -2956,6 +2968,8 @@ void	tty_default_attributes(struct tty *, u_int,
 void	tty_update_mode(struct tty *, int, struct screen *);
 const struct grid_cell *tty_check_codeset(struct tty *,
 	    const struct grid_cell *);
+struct visible_ranges *tty_check_overlay_range(struct tty *, u_int, u_int,
+	    u_int);
 void	tty_sync_start(struct tty *);
 void	tty_sync_end(struct tty *);
 int	tty_open(struct tty *, char **);
@@ -3307,8 +3321,14 @@ int	 server_create_socket(uint64_t, char **);
 
 /* server-client.c */
 u_int	 server_client_how_many(void);
+void	 server_client_set_overlay(struct client *, u_int, overlay_check_cb,
+	     overlay_mode_cb, overlay_draw_cb, overlay_key_cb,
+	     overlay_free_cb, overlay_resize_cb, void *);
+void	 server_client_clear_overlay(struct client *);
 void	 server_client_ensure_ranges(struct visible_ranges *, u_int);
 int	 server_client_ranges_is_empty(struct visible_ranges *);
+void	 server_client_overlay_range(u_int, u_int, u_int, u_int, u_int, u_int,
+	     u_int, struct visible_ranges *);
 void	 server_client_set_key_table(struct client *, const char *);
 const char *server_client_get_key_table(struct client *);
 int	 server_client_check_nested(struct client *);
@@ -3417,7 +3437,7 @@ void	 recalculate_sizes_now(int);
 /* input.c */
 #define INPUT_BUF_DEFAULT_SIZE 1048576
 struct input_ctx *input_init(struct window_pane *, struct bufferevent *,
-	     struct colour_palette *);
+	     struct colour_palette *, struct client *);
 void	 input_free(struct input_ctx *);
 void	 input_reset(struct input_ctx *, int);
 struct evbuffer *input_pending(struct input_ctx *);
@@ -3642,12 +3662,8 @@ void	 redraw_screen(struct client *);
 void	 redraw_pane(struct client *, struct window_pane *);
 void	 redraw_pane_scrollbar(struct client *, struct window_pane *);
 void	 redraw_free_scene(struct redraw_scene *);
-int	 redraw_client_has_window(struct client *, struct window *);
 void	 redraw_invalidate_scene(struct window *);
 void	 redraw_invalidate_all_scenes(void);
-void	 redraw_damage_window(struct window *, u_int, u_int, u_int, u_int);
-void	 redraw_free_damage(struct window *);
-void	 redraw_client_damage(struct client *);
 int	 redraw_get_status_border_cell_type(struct redraw_span **, u_int);
 
 /* screen.c */
@@ -3822,8 +3838,6 @@ struct style_range *window_pane_status_get_range(struct window_pane *, u_int,
 		     u_int);
 int		 window_pane_is_floating(struct window_pane *);
 int		 window_pane_is_floating_with_hidden(struct window_pane *);
-void		 window_redraw_floating_pane(struct window_pane *, int, int,
-		     int, int);
 
 /* window-border.c */
 void		 window_set_fill_cells(struct window *);
@@ -4163,7 +4177,6 @@ void		 menu_add_item(struct menu *, const struct menu_item *,
 		    struct cmdq_item *, struct client *,
 		    struct cmd_find_state *);
 void		 menu_free(struct menu *);
-void		 menu_get_size(struct menu *, enum box_lines, u_int *, u_int *);
 int		 menu_display(struct menu *, int, int, struct cmdq_item *,
 		    u_int, u_int, struct client *, enum box_lines, const char *,
 		    const char *, const char *, struct cmd_find_state *,
@@ -4180,6 +4193,20 @@ void		 menu_get_cursor(struct menu_data *, u_int *, u_int *);
 void		 menu_resize(struct menu_data *, struct window *);
 int		 menu_key(struct client *, struct menu_data *, struct key_event *);
 
+/* popup.c */
+#define POPUP_CLOSEEXIT 0x1
+#define POPUP_CLOSEEXITZERO 0x2
+#define POPUP_CLOSEANYKEY 0x4
+typedef void (*popup_close_cb)(int, void *);
+int		 popup_display(int, enum box_lines, struct cmdq_item *, u_int,
+                    u_int, u_int, u_int, struct environ *, const char *, int,
+                    char **, const char *, const char *, struct client *,
+                    struct session *, const char *, const char *,
+                    popup_close_cb, void *);
+int		 popup_present(struct client *);
+int		 popup_modify(struct client *, const char *, const char *,
+		    const char *, enum box_lines, int);
+
 /* style.c */
 int		 style_parse(struct style *,const struct grid_cell *,
 		     const char *);

tty-draw.c

@@ -52,7 +52,8 @@ tty_draw_line_clear(struct tty *tty, u_int px, u_int py, u_int nx,
 		return;
 
 	/* If genuine BCE is available, can try escape sequences. */
-	if (!wrapped &&
+	if (tty->client->overlay_check == NULL &&
+	    !wrapped &&
 	    nx >= 10 &&
 	    !tty_fake_bce(tty, defaults, bg)) {
 		/* Off the end of the line, use EL if available. */

tty-features.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: tty-features.c,v 1.46 2026/09/24 08:16:13 nicm Exp $ */
+/* $OpenBSD: tty-features.c,v 1.45 2026/09/22 14:10:26 nicm Exp $ */
 
 /*
  * Copyright (c) 2020 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -637,7 +637,6 @@ tty_default_features(struct client *c, const char *name, u_int version)
 			      "extkeys,"
 			      "focus,"
 		  	      "hyperlinks,"
-			      "margins,"
 			      "usstyle"
 		},
 		{ .name = "ghostty",
@@ -646,7 +645,6 @@ tty_default_features(struct client *c, const char *name, u_int version)
 			      "cstyle,"
 			      "extkeys,"
 			      "focus,"
-			      "margins,"
 			      "overline,"
 			      "hyperlinks,"
 			      "osc7,"
@@ -677,7 +675,7 @@ tty_default_features(struct client *c, const char *name, u_int version)
 			      "cstyle,"
 			      "extkeys,"
 			      "focus"
-		},
+		}
 	};
 	u_int	i;
 

tty.c

@@ -66,6 +66,7 @@ static void	tty_redraw_region(struct tty *, const struct tty_ctx *);
 static void	tty_emulate_repeat(struct tty *, enum tty_code_code,
 		    enum tty_code_code, u_int);
 static void	tty_draw_pane(struct tty *, const struct tty_ctx *, u_int);
+static int	tty_check_overlay(struct tty *, u_int, u_int);
 
 #ifdef ENABLE_SIXEL
 static void	tty_write_one(void (*)(struct tty *, const struct tty_ctx *),
@@ -543,6 +544,8 @@ void
 tty_free(struct tty *tty)
 {
 	tty_close(tty);
+
+	free(tty->r.ranges);
 }
 
 void
@@ -1115,7 +1118,7 @@ tty_redraw_region(struct tty *tty, const struct tty_ctx *ctx)
 	 */
 	if (tty_large_region(tty, ctx) || ctx->flags & TTY_CTX_PANE_OBSCURED) {
 		log_debug("%s: %s large region redraw", __func__, c->name);
-		ctx->redraw_cb(ctx, ctx->orupper, ctx->orlower - ctx->orupper + 1);
+		ctx->redraw_cb(ctx);
 		return;
 	}
 
@@ -1196,6 +1199,9 @@ tty_clear_line(struct tty *tty, const struct grid_cell *defaults, u_int py,
     u_int px, u_int nx, u_int bg)
 {
 	struct client		*c = tty->client;
+	struct visible_ranges	*r;
+	struct visible_range	*rr;
+	u_int			 i;
 
 	log_debug("%s: %s, %u at %u,%u", __func__, c->name, nx, px, py);
 
@@ -1204,7 +1210,7 @@ tty_clear_line(struct tty *tty, const struct grid_cell *defaults, u_int py,
 		return;
 
 	/* If genuine BCE is available, can try escape sequences. */
-	if (!tty_fake_bce(tty, defaults, bg)) {
+	if (c->overlay_check == NULL && !tty_fake_bce(tty, defaults, bg)) {
 		/* Off the end of the line, use EL if available. */
 		if (px + nx >= tty->sx && tty_term_has(tty->term, TTYC_EL)) {
 			tty_cursor(tty, px, py);
@@ -1227,9 +1233,18 @@ tty_clear_line(struct tty *tty, const struct grid_cell *defaults, u_int py,
 		}
 	}
 
-	/* Couldn't use an escape sequence, use spaces. */
-	tty_cursor(tty, px, py);
-	tty_repeat_space(tty, nx);
+	/*
+	 * Couldn't use an escape sequence, use spaces. Clear only the visible
+	 * bit if there is an overlay.
+	 */
+	r = tty_check_overlay_range(tty, px, py, nx);
+	for (i = 0; i < r->used; i++) {
+		rr = &r->ranges[i];
+		if (rr->nx != 0) {
+			tty_cursor(tty, rr->px, py);
+			tty_repeat_space(tty, rr->nx);
+		}
+	}
 }
 
 /* Clear a line, adjusting to visible part of pane. */
@@ -1238,12 +1253,22 @@ tty_clear_pane_line(struct tty *tty, const struct tty_ctx *ctx, u_int py,
     u_int px, u_int nx, u_int bg)
 {
 	struct client		*c = tty->client;
-	u_int			 l, x, rx, ry;
+	struct visible_ranges	*r;
+	struct visible_range	*ri;
+	u_int			 i, l, x, rx, ry;
 
 	log_debug("%s: %s, %u at %u,%u", __func__, c->name, nx, px, py);
 
-	if (tty_clamp_line(tty, ctx, px, py, nx, &l, &x, &rx, &ry))
-		tty_clear_line(tty, &ctx->defaults, ry, x, rx, bg);
+	if (tty_clamp_line(tty, ctx, px, py, nx, &l, &x, &rx, &ry)) {
+		r = tty_check_overlay_range(tty, x, ry, rx);
+		for (i = 0; i < r->used; i++) {
+			ri = &r->ranges[i];
+			if (ri->nx == 0)
+				continue;
+			tty_clear_line(tty, &ctx->defaults, ry, ri->px, ri->nx,
+			    bg);
+		}
+	}
 }
 
 /* Clamp area position to visible part of pane. */
@@ -1324,8 +1349,11 @@ tty_clear_area(struct tty *tty, const struct tty_ctx *ctx, u_int py,
 	if (nx == 0 || ny == 0)
 		return;
 
-	/* If BCE is available, can try to clear as a region. */
-	if (!tty_fake_bce(tty, defaults, bg)) {
+	/*
+	 * If there is an overlay or BCE is not available, cannot clear as a
+	 * region.
+	 */
+	if (c->overlay_check == NULL && !tty_fake_bce(tty, defaults, bg)) {
 		/* Use ED if clearing off the bottom of the terminal. */
 		if (px == 0 &&
 		    px + nx >= tty->sx &&
@@ -1397,28 +1425,53 @@ static void
 tty_draw_pane(struct tty *tty, const struct tty_ctx *ctx, u_int py)
 {
 	struct screen		*s = ctx->s;
-	u_int			 nx = ctx->sx, i, x, rx, ry;
+	u_int			 nx = ctx->sx, i, x, rx, ry, j;
+	struct visible_ranges	*r;
+	struct visible_range	*rr;
 
 	log_debug("%s: %s %u", __func__, tty->client->name, py);
 
 	if (~ctx->flags & TTY_CTX_WINDOW_BIGGER) {
-		tty_draw_line(tty, s, 0, py, nx, ctx->xoff, ctx->yoff + py,
-		    &ctx->style_ctx);
+		r = tty_check_overlay_range(tty, ctx->xoff, ctx->yoff + py, nx);
+		for (j = 0; j < r->used; j++) {
+			rr = &r->ranges[j];
+			if (rr->nx == 0)
+				continue;
+			tty_draw_line(tty, s, rr->px - ctx->xoff, py, rr->nx,
+			    rr->px, ctx->yoff + py, &ctx->style_ctx);
+		}
 		return;
 	}
-	if (tty_clamp_line(tty, ctx, 0, py, nx, &i, &x, &rx, &ry))
-		tty_draw_line(tty, s, i, py, rx, x, ry, &ctx->style_ctx);
+	if (tty_clamp_line(tty, ctx, 0, py, nx, &i, &x, &rx, &ry)) {
+		r = tty_check_overlay_range(tty, x, ry, rx);
+		for (j = 0; j < r->used; j++) {
+			rr = &r->ranges[j];
+			if (rr->nx == 0)
+				continue;
+			tty_draw_line(tty, s, i + rr->px - x, py, rr->nx,
+			    rr->px, ry, &ctx->style_ctx);
+		}
+	}
 }
 
 void
 tty_cmd_redrawline(struct tty *tty, const struct tty_ctx *ctx)
 {
-	u_int			 i, x, rx, ry;
+	u_int			 i, x, rx, ry, j;
+	struct visible_ranges	*r;
+	struct visible_range	*rr;
 
 	if (tty_clamp_line(tty, ctx, ctx->ocx, ctx->ocy, ctx->n,
-	    &i, &x, &rx, &ry))
-		tty_draw_line(tty, ctx->s, ctx->ocx + i, ctx->ocy, rx, x, ry,
-		    &ctx->style_ctx);
+	    &i, &x, &rx, &ry)) {
+		r = tty_check_overlay_range(tty, x, ry, rx);
+		for (j = 0; j < r->used; j++) {
+			rr = &r->ranges[j];
+			if (rr->nx == 0)
+				continue;
+			tty_draw_line(tty, ctx->s, ctx->ocx + i + rr->px - x,
+			    ctx->ocy, rr->nx, rr->px, ry, &ctx->style_ctx);
+		}
+	}
 }
 
 /* Check if character needs to be mapped for codeset. */
@@ -1455,6 +1508,36 @@ tty_check_codeset(struct tty *tty, const struct grid_cell *gc)
 	return (&new);
 }
 
+/* Check if a single character is covered by the overlay. */
+static int
+tty_check_overlay(struct tty *tty, u_int px, u_int py)
+{
+	struct visible_ranges	*r;
+
+	/*
+	 * With a single character, if there is anything visible (that is, the
+	 * range is not empty), it must be that character.
+	 */
+	r = tty_check_overlay_range(tty, px, py, 1);
+	return (!server_client_ranges_is_empty(r));
+}
+
+/* Return parts of the input range which are visible. */
+struct visible_ranges *
+tty_check_overlay_range(struct tty *tty, u_int px, u_int py, u_int nx)
+{
+	struct client	*c = tty->client;
+
+	if (c->overlay_check == NULL) {
+		server_client_ensure_ranges(&tty->r, 1);
+		tty->r.ranges[0].px = px;
+		tty->r.ranges[0].nx = nx;
+		tty->r.used = 1;
+		return (&tty->r);
+	}
+	return (c->overlay_check(c, c->overlay_data, px, py, nx));
+}
+
 #ifdef ENABLE_SIXEL
 /* Update context for client. */
 static int
@@ -1517,7 +1600,6 @@ tty_sync_start(struct tty *tty)
 	if (tty->flags & TTY_SYNCING)
 		return;
 	tty->flags |= TTY_SYNCING;
-	tty->sync_offset = EVBUFFER_LENGTH(tty->out);
 
 	if (tty_term_has(tty->term, TTYC_SYNC)) {
 		log_debug("%s sync start", tty->client->name);
@@ -1599,11 +1681,14 @@ tty_write_one(void (*cmdfn)(struct tty *, const struct tty_ctx *),
 void
 tty_cmd_insertcharacter(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client	*c = tty->client;
+
 	if ((ctx->flags & TTY_CTX_WINDOW_BIGGER) ||
 	    !tty_full_width(tty, ctx) ||
 	    tty_fake_bce(tty, &ctx->defaults, ctx->bg) ||
 	    (!tty_term_has(tty->term, TTYC_ICH) &&
-	    !tty_term_has(tty->term, TTYC_ICH1))) {
+	    !tty_term_has(tty->term, TTYC_ICH1)) ||
+	    c->overlay_check != NULL) {
 		tty_draw_pane(tty, ctx, ctx->ocy);
 		return;
 	}
@@ -1618,11 +1703,14 @@ tty_cmd_insertcharacter(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_deletecharacter(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client	*c = tty->client;
+
 	if ((ctx->flags & TTY_CTX_WINDOW_BIGGER) ||
 	    !tty_full_width(tty, ctx) ||
 	    tty_fake_bce(tty, &ctx->defaults, ctx->bg) ||
 	    (!tty_term_has(tty->term, TTYC_DCH) &&
-	    !tty_term_has(tty->term, TTYC_DCH1))) {
+	    !tty_term_has(tty->term, TTYC_DCH1)) ||
+	    c->overlay_check != NULL) {
 		tty_draw_pane(tty, ctx, ctx->ocy);
 		return;
 	}
@@ -1645,13 +1733,16 @@ tty_cmd_clearcharacter(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_insertline(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client	*c = tty->client;
+
 	if ((ctx->flags & TTY_CTX_WINDOW_BIGGER) ||
 	    !tty_full_width(tty, ctx) ||
 	    tty_fake_bce(tty, &ctx->defaults, ctx->bg) ||
 	    !tty_term_has(tty->term, TTYC_CSR) ||
 	    !tty_term_has(tty->term, TTYC_IL1) ||
 	    ctx->sx == 1 ||
-	    ctx->sy == 1) {
+	    ctx->sy == 1 ||
+	    c->overlay_check != NULL) {
 		tty_redraw_region(tty, ctx);
 		return;
 	}
@@ -1669,13 +1760,16 @@ tty_cmd_insertline(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_deleteline(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client	*c = tty->client;
+
 	if ((ctx->flags & TTY_CTX_WINDOW_BIGGER) ||
 	    !tty_full_width(tty, ctx) ||
 	    tty_fake_bce(tty, &ctx->defaults, ctx->bg) ||
 	    !tty_term_has(tty->term, TTYC_CSR) ||
 	    !tty_term_has(tty->term, TTYC_DL1) ||
 	    ctx->sx == 1 ||
-	    ctx->sy == 1) {
+	    ctx->sy == 1 ||
+	    c->overlay_check != NULL) {
 		tty_redraw_region(tty, ctx);
 		return;
 	}
@@ -1719,6 +1813,8 @@ tty_cmd_clearstartofline(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_reverseindex(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client	*c = tty->client;
+
 	if (ctx->ocy != ctx->orupper)
 		return;
 
@@ -1729,7 +1825,8 @@ tty_cmd_reverseindex(struct tty *tty, const struct tty_ctx *ctx)
 	    (!tty_term_has(tty->term, TTYC_RI) &&
 	    !tty_term_has(tty->term, TTYC_RIN)) ||
 	    ctx->sx == 1 ||
-	    ctx->sy == 1) {
+	    ctx->sy == 1 ||
+	    c->overlay_check != NULL) {
 		tty_redraw_region(tty, ctx);
 		return;
 	}
@@ -1749,6 +1846,8 @@ tty_cmd_reverseindex(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_linefeed(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client	*c = tty->client;
+
 	if (ctx->ocy != ctx->orlower)
 		return;
 
@@ -1757,7 +1856,8 @@ tty_cmd_linefeed(struct tty *tty, const struct tty_ctx *ctx)
 	    tty_fake_bce(tty, &ctx->defaults, 8) ||
 	    !tty_term_has(tty->term, TTYC_CSR) ||
 	    ctx->sx == 1 ||
-	    ctx->sy == 1) {
+	    ctx->sy == 1 ||
+	    c->overlay_check != NULL) {
 		tty_redraw_region(tty, ctx);
 		return;
 	}
@@ -1788,6 +1888,7 @@ tty_cmd_linefeed(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_scrollup(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client		*c = tty->client;
 	u_int			 i;
 
 	if ((ctx->flags & TTY_CTX_WINDOW_BIGGER) ||
@@ -1795,7 +1896,8 @@ tty_cmd_scrollup(struct tty *tty, const struct tty_ctx *ctx)
 	    tty_fake_bce(tty, &ctx->defaults, 8) ||
 	    !tty_term_has(tty->term, TTYC_CSR) ||
 	    ctx->sx == 1 ||
-	    ctx->sy == 1) {
+	    ctx->sy == 1 ||
+	    c->overlay_check != NULL) {
 		tty_redraw_region(tty, ctx);
 		return;
 	}
@@ -1825,6 +1927,7 @@ void
 tty_cmd_scrolldown(struct tty *tty, const struct tty_ctx *ctx)
 {
 	u_int		 i;
+	struct client	*c = tty->client;
 
 	if ((ctx->flags & TTY_CTX_WINDOW_BIGGER) ||
 	    (!tty_full_width(tty, ctx) && !tty_use_margin(tty)) ||
@@ -1833,7 +1936,8 @@ tty_cmd_scrolldown(struct tty *tty, const struct tty_ctx *ctx)
 	    (!tty_term_has(tty->term, TTYC_RI) &&
 	    !tty_term_has(tty->term, TTYC_RIN)) ||
 	    ctx->sx == 1 ||
-	    ctx->sy == 1) {
+	    ctx->sy == 1 ||
+	    c->overlay_check != NULL) {
 		tty_redraw_region(tty, ctx);
 		return;
 	}
@@ -1921,10 +2025,12 @@ tty_cmd_clearscreen(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_alignmenttest(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct client	*c = tty->client;
 	u_int		 i, j;
 
-	if (ctx->flags & TTY_CTX_WINDOW_BIGGER) {
-		ctx->redraw_cb(ctx, 0, ctx->sy);
+	if ((ctx->flags & TTY_CTX_WINDOW_BIGGER) ||
+	    c->overlay_check != NULL) {
+		ctx->redraw_cb(ctx);
 		return;
 	}
 
@@ -1943,9 +2049,29 @@ tty_cmd_alignmenttest(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_cell(struct tty *tty, const struct tty_ctx *ctx)
 {
+	const struct grid_cell	*gcp = ctx->cell;
+	struct screen		*s = ctx->s;
+	struct visible_ranges	*r;
+	u_int			 px, py, i, vis = 0;
+
+	px = ctx->xoff + ctx->ocx - ctx->wox;
+	py = ctx->yoff + ctx->ocy - ctx->woy;
 	if (!tty_is_visible(tty, ctx, ctx->ocx, ctx->ocy, 1, 1))
 		return;
 
+	if (gcp->data.width == 1 && !tty_check_overlay(tty, px, py))
+		return;
+	if (gcp->data.width > 1) { /* could be partially obscured */
+		r = tty_check_overlay_range(tty, px, py, gcp->data.width);
+		for (i = 0; i < r->used; i++)
+			vis += r->ranges[i].nx;
+		if (vis < gcp->data.width) {
+			tty_draw_line(tty, s, s->cx, s->cy, gcp->data.width,
+			    px, py, &ctx->style_ctx);
+			return;
+		}
+	}
+
 	if (ctx->xoff + ctx->ocx - ctx->wox > tty->sx - 1 &&
 	    ctx->ocy == ctx->orlower &&
 	    tty_full_width(tty, ctx))
@@ -1965,6 +2091,9 @@ tty_cmd_cell(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_cells(struct tty *tty, const struct tty_ctx *ctx)
 {
+	struct visible_ranges	*r;
+	struct visible_range	*ri;
+	u_int			 i, px, py, cx;
 	const char		*cp = ctx->data.data;
 	size_t			 n = ctx->data.size;
 
@@ -1983,14 +2112,27 @@ tty_cmd_cells(struct tty *tty, const struct tty_ctx *ctx)
 		    tty->cy == tty->rlower)
 			tty_draw_pane(tty, ctx, ctx->ocy);
 		else
-			ctx->redraw_cb(ctx, ctx->ocy, 1);
+			ctx->redraw_cb(ctx);
 		return;
 	}
 
 	tty_margin_off(tty);
 	tty_cursor_pane_unless_wrap(tty, ctx, ctx->ocx, ctx->ocy);
 	tty_attributes(tty, ctx->cell, &ctx->style_ctx);
-	tty_putn(tty, cp, n, n);
+
+	/* Get tty position from pane position for overlay check. */
+	px = ctx->xoff + ctx->ocx - ctx->wox;
+	py = ctx->yoff + ctx->ocy - ctx->woy;
+
+	r = tty_check_overlay_range(tty, px, py, n);
+	for (i = 0; i < r->used; i++) {
+		ri = &r->ranges[i];
+		if (ri->nx != 0) {
+			cx = ri->px - ctx->xoff + ctx->wox;
+			tty_cursor_pane_unless_wrap(tty, ctx, cx, ctx->ocy);
+			tty_putn(tty, cp + ri->px - px, ri->nx, ri->nx);
+		}
+	}
 }
 
 void
@@ -2084,8 +2226,23 @@ tty_cmd_sixelimage(struct tty *tty, const struct tty_ctx *ctx)
 void
 tty_cmd_syncstart(struct tty *tty, const struct tty_ctx *ctx)
 {
-	if (ctx->flags & TTY_CTX_SYNC)
+	struct client	*c = tty->client;
+
+	if ((ctx->flags & TTY_CTX_OVERLAY_SYNC) &&
+	    (ctx->flags & TTY_CTX_SYNC)) {
+		/*
+		 * This is an overlay and a command that moves the cursor so
+		 * start synchronized updates.
+		 */
 		tty_sync_start(tty);
+	} else if (~ctx->flags & TTY_CTX_OVERLAY_SYNC) {
+		/*
+		 * This is a pane. If there is an overlay, always start;
+		 * otherwise, only if requested.
+		 */
+		if ((ctx->flags & TTY_CTX_SYNC) || c->overlay_draw != NULL)
+			tty_sync_start(tty);
+	}
 }
 
 void
@@ -2104,6 +2261,10 @@ tty_cell(struct tty *tty, const struct grid_cell *gc,
 	if (gc->flags & GRID_FLAG_PADDING)
 		return;
 
+	/* Check if character is covered by overlay or floating pane. */
+	if (!tty_check_overlay(tty, tty->cx, tty->cy))
+		return;
+
 	/* Check the output codeset and apply attributes. */
 	gcp = tty_check_codeset(tty, gc);
 	tty_attributes(tty, gcp, style_ctx);

window-border.c

@@ -1,4 +1,4 @@
-/* $OpenBSD: window-border.c,v 1.4 2026/09/11 10:17:16 nicm Exp $ */
+/* $OpenBSD: window-border.c,v 1.3 2026/07/23 09:38:27 nicm Exp $ */
 
 /*
  * Copyright (c) 2026 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -120,10 +120,6 @@ window_get_border_cell(struct window_pane *wp, enum pane_lines pane_lines,
 		gc->attr &= ~GRID_ATTR_CHARSET;
 		utf8_copy(&gc->data, tty_acs_heavy_borders(cell_type));
 		break;
-	case PANE_LINES_ROUNDED:
-		gc->attr &= ~GRID_ATTR_CHARSET;
-		utf8_copy(&gc->data, tty_acs_rounded_borders(cell_type));
-		break;
 	case PANE_LINES_SIMPLE:
 		gc->attr &= ~GRID_ATTR_CHARSET;
 		utf8_set(&gc->data, SIMPLE_BORDERS[cell_type]);

window-copy.c

@@ -665,7 +665,7 @@ window_copy_view_init(struct window_mode_entry *wme,
 
 	data->backing = xmalloc(sizeof *data->backing);
 	screen_init(data->backing, sx, screen_size_y(base), UINT_MAX);
-	data->ictx = input_init(NULL, NULL, NULL);
+	data->ictx = input_init(NULL, NULL, NULL, NULL);
 	data->mx = data->cx;
 	data->my = screen_hsize(data->backing) + data->cy - data->oy;
 	data->showmark = 0;
@@ -768,7 +768,6 @@ window_copy_scroll(struct window_pane *wp, int sl_mpos, u_int my,
 	struct window_mode_entry	*wme = TAILQ_FIRST(&wp->modes);
 
 	if (wme != NULL) {
-		window_redraw_active_switch(wp->window, wp);
 		window_set_active_pane(wp->window, wp, 0);
 		window_copy_scroll1(wme, wp, sl_mpos, my, tty_oy, scroll_exit);
 	}

window.c

@@ -415,7 +415,6 @@ window_create(u_int sx, u_int sy, u_int xpixel, u_int ypixel)
 	TAILQ_INIT(&w->panes);
 	TAILQ_INIT(&w->z_index);
 	TAILQ_INIT(&w->last_panes);
-	TAILQ_INIT(&w->damage);
 	w->active = NULL;
 
 	w->lastlayout = -1;
@@ -469,7 +468,6 @@ window_destroy(struct window *w)
 
 	menu_destroy(w);
 	window_destroy_panes(w);
-	redraw_free_damage(w);
 
 	if (event_initialized(&w->name_event))
 		evtimer_del(&w->name_event);
@@ -693,6 +691,7 @@ window_pane_update_focus(struct window_pane *wp)
 				    c->session->attached != 0 &&
 				    (c->flags & CLIENT_FOCUSED) &&
 				    c->session->curw->window == wp->window &&
+				    c->overlay_draw == NULL &&
 				    wp->window->menu == NULL) {
 					focused = 1;
 					break;
@@ -720,7 +719,6 @@ int
 window_set_active_pane(struct window *w, struct window_pane *wp, int notify)
 {
 	struct window_pane *lastwp;
-	int		    unzoomed;
 
 	log_debug("%s: pane %%%u", __func__, wp->id);
 
@@ -728,8 +726,7 @@ window_set_active_pane(struct window *w, struct window_pane *wp, int notify)
 		return (0);
 	if (w->modal != NULL && wp != w->modal)
 		return (0);
-	unzoomed = (w->flags & WINDOW_ZOOMED) && !window_pane_is_visible(wp);
-	if (unzoomed)
+	if ((w->flags & WINDOW_ZOOMED) && !window_pane_is_visible(wp))
 		window_unzoom(w, 1);
 	lastwp = w->active;
 
@@ -746,19 +743,7 @@ window_set_active_pane(struct window *w, struct window_pane *wp, int notify)
 	}
 
 	tty_update_window_offset(w);
-
-	/*
-	 * Unzooming changes every pane's geometry and needs a full window
-	 * redraw. Otherwise, only the previous and new active pane's border
-	 * and status appearance changed, so avoid redrawing unaffected pane
-	 * content.
-	 */
-	if (unzoomed)
-		server_redraw_window(w);
-	else {
-		server_redraw_window_borders(w);
-		server_status_window(w);
-	}
+	server_redraw_window(w);
 
 	if (notify)
 		window_fire_pane_changed(w, w->active, lastwp);
@@ -1648,7 +1633,7 @@ window_pane_set_event(struct window_pane *wp)
 	    NULL, window_pane_error_callback, wp);
 	if (wp->event == NULL)
 		fatalx("out of memory");
-	wp->ictx = input_init(wp, wp->event, &wp->palette);
+	wp->ictx = input_init(wp, wp->event, &wp->palette, NULL);
 
 	bufferevent_enable(wp->event, EV_READ|EV_WRITE);
 }
@@ -2941,40 +2926,3 @@ window_pane_is_floating_with_hidden(struct window_pane *wp)
 		return (0);
 	return (1);
 }
-
-/* Report damage for a floating pane, including its border and scrollbar. */
-static void
-window_damage_floating_pane(struct window_pane *wp, int xoff, int yoff,
-    int sx, int sy)
-{
-	struct window	*w = wp->window;
-	int		 x0, x1, y0, y1, sb_left = 0, sb_right = 0;
-	struct style	*sb_sy = &wp->scrollbar_style;
-
-	if (window_pane_scrollbar_reserve(wp)) {
-		if (w->sb_pos == PANE_SCROLLBARS_LEFT)
-			sb_left = sb_sy->width + sb_sy->pad;
-		else
-			sb_right = sb_sy->width + sb_sy->pad;
-	}
-	x0 = xoff - 1 - sb_left;
-	x1 = xoff + sx + sb_right;
-	y0 = yoff - 1;
-	y1 = yoff + sy;
-	if (x0 < 0)
-		x0 = 0;
-	if (y0 < 0)
-		y0 = 0;
-	if (x1 >= x0 && y1 >= y0)
-		redraw_damage_window(w, x0, y0, x1 - x0 + 1U, y1 - y0 + 1U);
-}
-
-/* Report damage for a floating pane's old and new areas. */
-void
-window_redraw_floating_pane(struct window_pane *wp, int oxoff, int oyoff,
-    int osx, int osy)
-{
-	window_damage_floating_pane(wp, oxoff, oyoff, osx, osy);
-	window_damage_floating_pane(wp, wp->xoff, wp->yoff, wp->sx, wp->sy);
-	server_status_window(wp->window);
-}