On some Wayland configurations, the SDR white level is 203 nits and the max luminance is 10000 nits, and HDR content in the PQ range is mapped by the compositor into the actual display capabilities. We don't want to show an HDR gradient up to 10000 nits, so let's cap it to ~1000 nits in this case.
Remove a superfluous null byte at the end of ps3_hid_report_descriptor,
as it might confuse some more stricter parser.
The data in ps3_hid_report_descriptor probably comes for a libinput
recording, and sometimes those can have superfluous null byte at the
end.
This is mentioned for example in the hidreport project:
64d4067403/tools/libinput-recording-extract-hid-descriptor.py (L25-L27)
As a proof that the original HID report descriptor of the actual device
is 148 bytes long, the following lsusb capture can be compared:
http://ps3.jim.sh/sixaxis/usb/lsusb.txt
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* testevdev: Always use decimal for HID report descriptors size
The size of the HID report descriptors in the SDL_COMPILE_TIME_ASSERT
checks is specified sometimes in decimal and sometimes in octal.
Always used decimal for consistency.
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* SDL_report_descriptor: Add missing include guards in header file
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* SDL_report_descriptor: Fix some ignored return values
Fix some ignored return values resulting in incomplete error checking.
For instance:
- ParseMainItem() was always returning true because the return value of
AddInputFields() was not handled.
- ParseLocalItem() was always returning true because the return value of
AddUsage() was not handled.
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* test: Add new test program for SDL_report_descriptor code
Add support for testing the SDL_report_descriptor code by adding a new
executable to make it easier to experiment with HID report descriptor
parsing.
The main() function which originally was in
src/joystick/hidapi/SDL_report_descriptor.c is moved to a separate file
named test/testdescriptor.c in order to simplify dealing with multiple
build systems.
For instance if the main() was in
src/joystick/hidapi/SDL_report_descriptor.c the code would have to
account for the cases when the file is built as part of the library or
when it's built as part of a standalone executable, in which case the
dynamic API mechanism needs to be disabled.
This would pose a problem especially with MSVC which uses pre-compiled
headers (PCH) which do not sit well with the preprocessor logic that
would be needed, like the hacks added in test/testevdev.c
Using a completely separate source file for the standalone executable
avoids the issue, especially considering that the new file is not built
with MSVC at all.
The new test program can be built with:
cmake -DCMAKE_BUILD_TYPE=Debug -DSDL_TESTS=ON -S . -B build
make -C testdescriptor
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* testdescriptor: Fix compiler warning
Fix compiler warning:
-----------------------------------------------------------------------
.../test/testdescriptor.c: In function ‘main’:
.../test/testdescriptor.c:56:17: warning: unused variable ‘file’ [-Wunused-variable]
56 | const char *file = argv[1];
| ^~~~
-----------------------------------------------------------------------
Use the `file` variable when appropriate since it is already declared
and assigned.
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* testdescriptor: Clean up descriptor context before exiting
For correctness clean up the descriptor parsing context before exiting,
even though this is not a problem in practice for a standalone
executable.
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* testdescriptor: Exercise public API for parsing report descriptor
This gives some more coverage when running the SDL_report_descriptor
test program.
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* SDL_report_descriptor: use size_t for variables that represent buffer sizes
Using size_t type for variables that represent buffer sizes in
src/joystick/hidapi/SDL_report_descriptor.[hc] addresses possible errors
when using the functions in combination with SDL_LoadFile, like in
test/testdescriptor.c
When building with CMake on Windows x64 the compilation was failing with
the following error:
-----------------------------------------------------------------------
D:\a\SDL\SDL\test\testdescriptor.c(69): error C2220: the following warning is treated as an error
D:\a\SDL\SDL\test\testdescriptor.c(69): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data
-----------------------------------------------------------------------
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
* SDL_hidapi_xboxone: protect against passing negative size to SDL_ReadReportData
Since SDL_ReadReportData() is now using size_t for the buffer size, also
change its user HIDAPI_DriverXboxOne_HandleDescriptorReport to pass
size_t, but protecting against possible cases of passing negative values
to SDL_ReadReportData().
To do that it is enough to check that the "size" argument is not zero,
so it will never be negative when decremented (size--) a few lines
below.
Note: this just addresses a theoretical issue with future callers of
HIDAPI_DriverXboxOne_HandleDescriptorReport, the current code would be
already safe as the current caller already checks that size > 0.
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
---------
Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
This adds support for:
* System theme
* Sandbox detection
* Device form factor detection
Many things aren't properly supported yet, but changes and upgrades will happen on the Ubuntu Touch side, so SDL should automatically support more Ubuntu Touch features as time goes.
Amazon's store link was still "http://" instead of "https://", and since they
don't have the physical CD in stock anymore (and probably won't ever again), I
added a link to the album on Amazon Music, for those that want to access it.
SVE/SVE2 is a new SIMD extension for AArch64. Compared to NEON, SVE/SVE2 brings the following benefits that are good for SDL projects:
- Lane prediction: we don't have to treat the tail part of a stride separately when the width is n times the hardware vector size
- Although the performance is almost no difference from NEON when the hardware vector size is 128bits, when the hardware provides a longer vector size, e.g. 256, 512, ... 2048, we can enjoy the large performance gain without modifying the source code or recompiling a library.
The functional correctness is validated in a dedicated [qemu project](https://github.com/GorgonMeducer/aarch64_qemu_mac_template/tree/SDL-SVE2-Acceleration-Validation).
The performance is tested on [Radxa Orion 6 N](https://radxa.com/products/orion/o6n/), which provides 4x A720 and 4x A520 processors. Since the vector size is 128 bits, which is the same as NEON, the performance is almost the same (or no worse than) the NEON acceleration.
